[rotel] Support added for model RX-1052 #16486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
|
Jar for testing: After downloading, just change the file extension from zip into .jar. Waiting for Pieter's feedback. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
New version that should detect tuner input. |
jlaur
reviewed
Mar 15, 2024
bundles/org.openhab.binding.rotel/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Final version for testing: I will ask Pieter to fully validate this final version. The PR is now ready for review. |
|
Pieter confirmed to me that the last version is working well with its RX-1052 device. |
jlaur
requested changes
Mar 20, 2024
...nhab.binding.rotel/src/main/java/org/openhab/binding/rotel/internal/RotelHandlerFactory.java
Outdated
Show resolved
Hide resolved
....rotel/src/main/java/org/openhab/binding/rotel/internal/communication/RotelFlagsMapping.java
Outdated
Show resolved
Hide resolved
....rotel/src/main/java/org/openhab/binding/rotel/internal/communication/RotelFlagsMapping.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@jlaur : changes done. |
magx2
pushed a commit
to magx2/openhab2-addons
that referenced
this pull request
Mar 24, 2024
* Two new channels to enable/disable speaker A and speaker B Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr