Upgrade to Karaf 4.4.5

[holgerfriedrich]

For release notes, see:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353604&projectId=12311140

Refs: openhab/openhab-core#4133

[holgerfriedrich]

@wborn need some time to reorder the runbundles....

[wborn]

need some time to reorder the runbundles

For the itests it doesn't really matter what the bundle order is.

[wborn]

Does a local build succeed for you @holgerfriedrich? It does not for me as dynamodb fails:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! -- in org.openhab.persistence.dynamodb.internal.TestStoreMixedTypesLegacyTest
[ERROR] org.openhab.persistence.dynamodb.internal.TestStoreMixedTypesLegacyTest -- Time elapsed: 0.001 s <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.eclipse.jetty.server.handler.ResourceHandler$1
	at org.eclipse.jetty.server.handler.ResourceHandler.<init>(ResourceHandler.java:75)
	at com.amazonaws.services.dynamodbv2.local.server.DynamoDBProxyServer.setUpShell(DynamoDBProxyServer.java:58)
	at com.amazonaws.services.dynamodbv2.local.server.DynamoDBProxyServer.<init>(DynamoDBProxyServer.java:41)
	at com.amazonaws.services.dynamodbv2.local.main.ServerRunner.createServer(ServerRunner.java:127)
	at com.amazonaws.services.dynamodbv2.local.main.ServerRunner.createServerFromCommandLineArgs(ServerRunner.java:120)
	at org.openhab.persistence.dynamodb.internal.BaseIntegrationTest.newService(BaseIntegrationTest.java:199)
	at org.openhab.persistence.dynamodb.internal.BaseIntegrationTest.initService(BaseIntegrationTest.java:163)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.NoClassDefFoundError: org/eclipse/jetty/http/compression/HuffmanEncoder [in thread "main"]
	at org.eclipse.jetty.http2.hpack.HpackContext$StaticEntry.<init>(HpackContext.java:469)
	at org.eclipse.jetty.http2.hpack.HpackContext.<clinit>(HpackContext.java:144)
	at org.eclipse.jetty.http2.hpack.HpackFieldPreEncoder.getEncodedField(HpackFieldPreEncoder.java:75)
	at org.eclipse.jetty.http.PreEncodedHttpField.<init>(PreEncodedHttpField.java:103)
	at org.eclipse.jetty.http.PreEncodedHttpField.<init>(PreEncodedHttpField.java:108)
	at org.eclipse.jetty.http2.hpack.HpackEncoder.<clinit>(HpackEncoder.java:83)
	at org.eclipse.jetty.http2.hpack.HpackFieldPreEncoder.getEncodedField(HpackFieldPreEncoder.java:45)
	at org.eclipse.jetty.http.PreEncodedHttpField.<init>(PreEncodedHttpField.java:103)
	at org.eclipse.jetty.http.PreEncodedHttpField.<init>(PreEncodedHttpField.java:108)
	at org.eclipse.jetty.server.ResourceService.<clinit>(ResourceService.java:70)
	... 9 more

[holgerfriedrich]

@wborn I thought yes, but obviously I must have skipped the tests :-(
Sorry for that.
I just had to fix jetty version in http binding test, same error here. Not sure how to fix here.... The HuffmannEncoder class was moved around in Jetty....

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/failed-to-execute-goal-org-apache-karaf-tooling4-4-4-verify/154678/4

[holgerfriedrich]

@wborn It looks like dynamodb tests are the only remaining issue (mercedesme and hueemulation seem to fail due to restrictive firewall on my build server, I don't see a real problem here).
We have a transitive dependency to jetty 9.4.18, newer packages from 2.x use jetty 11 or 12. Core was not upgraded to 9.4.53.
https://mvnrepository.com/artifact/com.amazonaws/DynamoDBLocal
Jetty team has changed the HuffmanEncoder files.

Do you have any recommendation how to resolve the problem?

• Include the old jetty packages for test
• Try to upgrade to 2.x (needs some changes of dependencies, there is an update script in scripts/fetch_sdk.sh, not sure how to use it)

I have disabled the tests for dynamodb for now, possibly we should merge this way. Currently the add-on build is broken.

[wborn]

Thanks!

[wborn]

I have disabled the tests for dynamodb for now

If it is just tests maybe adding the old depenencies with scope test works. Perhaps @ssalonen can also check if dynamodb still works with the newer Jetty version?

[holgerfriedrich]

Created follow-up issue to re-enable tests for DynamoDB, #16535.