Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boschshc] Add support for Dimmer #16501

Merged
merged 1 commit into from Apr 1, 2024

Conversation

david-pace
Copy link
Member

@david-pace david-pace commented Mar 8, 2024

Adds support for Bosch Smart Home Dimmer devices.

  • Add thing type definition
  • Re-generate i18n properties file
  • Implement handler
  • Register handler in factory
  • Register dimmer in discovery
  • Add unit tests
  • Add documentation

Resolves #16241

@david-pace
Copy link
Member Author

Note: needs to be rebased after #16500 is merged.

@david-pace david-pace added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels Mar 8, 2024
@david-pace david-pace marked this pull request as ready for review March 18, 2024 08:03
@lsiepel lsiepel removed the awaiting other PR Depends on another PR label Mar 31, 2024
Adds support for Bosch Smart Home Dimmer devices.

* Add thing type definition
* Re-generate i18n properties file
* Implement handler
* Register handler in factory
* Register dimmer in discovery
* Add unit tests
* Add documentation

Signed-off-by: David Pace <dev@davidpace.de>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit b4f9736 into openhab:main Apr 1, 2024
2 of 3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 1, 2024
@david-pace david-pace deleted the 16241-boschshc-dimmer branch April 1, 2024 10:28
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Adds support for Bosch Smart Home Dimmer devices.

Signed-off-by: David Pace <dev@davidpace.de>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
Adds support for Bosch Smart Home Dimmer devices.

Signed-off-by: David Pace <dev@davidpace.de>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[boschshc] Support for Dimmer
2 participants