[orbitbhyve] Handle null location attribute in devices json #16525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
lolodomo
requested changes
Mar 16, 2024
| @@ -210,6 +211,9 @@ public List<OrbitBhyveDevice> getDevices() { | |||
| updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, | |||
| "Get devices returned response status: " + response.getStatus()); | |||
| } | |||
| } catch (JsonSyntaxException e) { | |||
| logger.info("Exception parsing devices json: {}", e.getMessage(), e); | |||
There was a problem hiding this comment.
DEBUG level would be more appropriate, especially if you log the full stack trace.
There was a problem hiding this comment.
Yes, I think that's fair. Previously before the exception was caught, it would just fail silently. Now the bridge will go offline, which will be a clue to enable debug.
Note in my latest commit I'm also catching JsonSyntaxException in the getDevice method because it will fail in the same way.
Signed-off-by: Mark Hilbush <mark@hilbush.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some "devices" responses contain a null value in the
locationattribute. Json parsing failed because JsonObject will not deserialize a null value. Also added a check forJsonSyntaxExceptionand logged the stack trace to better be able to track down parsing issues.BTW, I noticed that
locationis not used anywhere in the binding. So, an alternative would be to just remove it from the DTO. However, I still think it's a good idea to catchJsonSyntaxExceptionand log the stack trace to be able to track down parsing issues.This doesn't seem critical enough to cherry pick to 4.1.x.