Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Thing properties were no more provided #16530

Merged
merged 7 commits into from Mar 17, 2024

Conversation

clinique
Copy link
Contributor

Resolves #16529

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo as a code owner March 16, 2024 18:51
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from lolodomo March 16, 2024 19:28
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested a review from jlaur March 16, 2024 20:41
Corrected call order for afterNewData

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
@lolodomo
Copy link
Contributor

Last code looks good to me but build failed.

@clinique
Copy link
Contributor Author

clinique commented Mar 17, 2024

Last code looks good to me but build failed.

Yes, I saw that but it seems to be outside my PR. I'm going to push a small change to retrigger it.

Signed-off-by: clinique <gael@lhopital.org>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Mar 17, 2024
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique self-assigned this Mar 17, 2024
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 17, 2024
@lolodomo
Copy link
Contributor

@jlaur : is it ok for you?

@jlaur
Copy link
Contributor

jlaur commented Mar 17, 2024

@jlaur : is it ok for you?

Yes, my comment was resolved nicely. I have not reviewed in detail or tested, but assuming you have reviewed and @clinique tested. 🙂

@lolodomo lolodomo merged commit 9af5bd0 into openhab:main Mar 17, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 17, 2024
@clinique clinique deleted the netatmo_16529 branch March 17, 2024 22:54
jlaur pushed a commit to jlaur/openhab-addons that referenced this pull request Mar 23, 2024
Signed-off-by: clinique <gael@lhopital.org>
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Mar 24, 2024
Signed-off-by: clinique <gael@lhopital.org>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[netatmo] Thing properties are no more provided
4 participants