[lutron] Implement button press notifications for Picos from LEAP #16550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Cutrer <cody@cutrer.us>
lolodomo
added
the
enhancement
lolodomo
reviewed
Mar 29, 2024
...ding.lutron/src/main/java/org/openhab/binding/lutron/internal/handler/LeapBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
@ccutrer : before merging, I will wait for few days so that official binding maintainers can give a feedback. |
|
No ffeedback so I assume CODEOWNERS file is outdated for this binding. |
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
…enhab#16550) * [lutron] implement button press notifications for Picos from LEAP * reverse equality check for null safety Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only tested this with a PJ2-3BRL connecting to a Caseta SmartBridge 2. But I'm pretty sure I handled all of the id translation correctly for other types of Picos that don't happen to have sequential button ids.
I used pylutron_caseta to guide me somewhat in implementing.