Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus.sungrow] Add missing sungrow bundle #16557

Merged
merged 1 commit into from Mar 22, 2024
Merged

[modbus.sungrow] Add missing sungrow bundle #16557

merged 1 commit into from Mar 22, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 22, 2024 •
edited

Fixes #16558

@wborn wborn added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Mar 22, 2024
@wborn wborn requested a review from a team as a code owner March 22, 2024 09:56
@wborn
[modbus.sungrow] Add missing sungrow bundle
8b9b264 
Fixes openhab#16558

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the add-missing-sungrow-bundle branch from 4b4376d to 8b9b264 Compare March 22, 2024 09:57
@wborn wborn mentioned this pull request Mar 22, 2024
Closed
@wborn wborn requested a review from soenkekueper March 22, 2024 10:01
jlaur
jlaur approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit d860327 into openhab:main Mar 22, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Mar 22, 2024
@wborn wborn deleted the add-missing-sungrow-bundle branch March 22, 2024 12:09
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Mar 24, 2024
@wborn @magx2
[modbus.sungrow] Add missing sungrow bundle (openhab#16557)
a389b1a 
Fixes openhab#16558

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@soenkekueper soenkekueper Awaiting requested review from soenkekueper

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

oh4.2M1 missing sungrow binding
2 participants
@wborn @jlaur