Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shelly] Enable accumulated channels for Shelly Pro 3EM #16566

Merged
merged 1 commit into from Mar 24, 2024
Merged

[shelly] Enable accumulated channels for Shelly Pro 3EM #16566

merged 1 commit into from Mar 24, 2024

Conversation

leifbladt
Copy link
Contributor

@leifbladt leifbladt commented Mar 24, 2024 •
edited

Description

The Shelly Pro 3EM does not show the accumulated channels on the device, although the values are transferred from the device.

The reason seems to be this commit. The Pro 3EM has no internal relay (only available as an add-on), unlike the 3EM and the Pro EM.

Fixes #16552
openHAB Community: Discussion

@leifbladt leifbladt force-pushed the fix-accumulated-channels-shelly-pro-3em branch 4 times, most recently from e8a74dd to f0144a5 Compare March 24, 2024 10:35
@leifbladt
Enable accumulated channels for Shelly Pro 3EM
0a68e05 
Signed-off-by: Leif Bladt <leif.bladt@gmx.de>
@leifbladt leifbladt force-pushed the fix-accumulated-channels-shelly-pro-3em branch from f0144a5 to 0a68e05 Compare March 24, 2024 10:38
@leifbladt leifbladt marked this pull request as ready for review March 24, 2024 11:12
@markus7017
Copy link
Contributor

LGTM

@markus7017 markus7017 requested a review from lsiepel March 24, 2024 14:49
@markus7017 markus7017 added the bug An unexpected problem or unintended behavior of an add-on label Mar 24, 2024
markus7017
markus7017 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@markus7017 markus7017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit fd882ff into openhab:main Mar 24, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 24, 2024
@leifbladt
Copy link
Contributor Author

@markus7017 @lolodomo Thanks for your fast feedback and approval. Is there any chance to backport this fix to the 4.1.x branch?

lolodomo pushed a commit that referenced this pull request Mar 29, 2024
@leifbladt @lolodomo
Enable accumulated channels for Shelly Pro 3EM (#16566)
0fbfe29 
Signed-off-by: Leif Bladt <leif.bladt@gmx.de>
@lolodomo lolodomo added the patch A PR that has been cherry-picked to a patch release branch label Mar 29, 2024
@lolodomo
Copy link
Contributor

@markus7017 @lolodomo Thanks for your fast feedback and approval. Is there any chance to backport this fix to the 4.1.x branch?

Done

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/3772

@proggprod
Copy link

This isn't fixed. I have two Shelly Pro EM50 and I don't have totalKWH for either meter1 or meter2, and the accumulatedWTotal is always 0.

@lsiepel
Copy link
Contributor

lsiepel commented Apr 18, 2024

This isn't fixed. I have two Shelly Pro EM50 and I don't have totalKWH for either meter1 or meter2, and the accumulatedWTotal is always 0.

Please raise an issue with all relevant details if you believe this is somehow bugged.

@proggprod
Copy link

Please raise an issue

I thought this was the issuse that had come from my initial report on the openhab forum. You think I should open a new issue again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@markus7017 markus7017 markus7017 approved these changes

@lsiepel lsiepel Awaiting requested review from lsiepel

Assignees

@leifbladt leifbladt

Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[shelly] Shelly Pro 3EM is missing accumulated (total) channels
6 participants
@leifbladt @markus7017 @lolodomo @openhab-bot @proggprod @lsiepel