Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Fix ClassCastException #16573

Merged
merged 1 commit into from Mar 25, 2024
Merged

[netatmo] Fix ClassCastException #16573

merged 1 commit into from Mar 25, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Mar 24, 2024 •
edited

This solves the ClassCastException identified here

Extracted from #16489

@clinique
Enhance getActiveChildren()
79610ce 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique added the bug An unexpected problem or unintended behavior of an add-on label Mar 24, 2024
@clinique clinique self-assigned this Mar 24, 2024
@clinique clinique requested a review from lolodomo as a code owner March 24, 2024 18:29
@clinique
Copy link
Contributor Author

@jlaur : this one is ready for your review

@clinique clinique requested a review from jlaur March 24, 2024 18:30
@jlaur jlaur changed the title [netatmo] NPE in CommonInterface [netatmo] Fix ClassCastException Mar 24, 2024
jlaur
jlaur approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. @lolodomo - would you like to have a look as well?

@lolodomo lolodomo merged commit 9dd2827 into openhab:main Mar 25, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Mar 25, 2024
@clinique clinique deleted the netatmo_typecast_error branch March 25, 2024 08:20
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/netatmo-bridge-offline-99-of-time/149168/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@jlaur jlaur jlaur approved these changes

Assignees

@clinique clinique

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clinique @openhab-bot @lolodomo @jlaur