-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linky] Resurrect the binding #16586
Conversation
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@lolodomo : this is ready for your review. |
I compile and test that today. |
The bundle does not start due to the change of version of org.jsoup:
Is it possible to avoid this change of version ? |
Some other bindings are using the same version (Verisure IIRW) - it should work and works in the dev environment. On top of that previous version is signaled with a security issue, reason why I thought it would be a good move. I'll do as you prefer |
I just put the built jar in my addons folder. I am running a recent snapshot, number 4004. |
Does it work if you install the SMGW binding, for example (to fulfill the dependency)? |
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/linky-communication-error/132889/41 |
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@lolodomo : you're ready to go, I reverted json dependency to the original version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
Thank you a lot Gael, I will test it with next snapshot tomorrow. |
And I will cherry pick it in 4.1.x |
* Change lincs entrypoint Signed-off-by: gael@lhopital.org <gael@lhopital.org>
I confirm it works. Bravo Gael. |
Merci Laurent ! |
* Change lincs entrypoint Signed-off-by: gael@lhopital.org <gael@lhopital.org> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
The entry point for the authentication and further data requests changed.
Bumped jsoup dependency
Resolves #16585