Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[upnpcontrol] Catch IAE when Album Art URI is invalid #16597

Merged
merged 1 commit into from Apr 1, 2024
Merged

[upnpcontrol] Catch IAE when Album Art URI is invalid #16597

merged 1 commit into from Apr 1, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 1, 2024

Fixes #16595

@wborn
[upnpcontrol] Catch IAE when Album Art URI is invalid
a82d00b 
Fixes openhab#16595

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Apr 1, 2024
@wborn wborn requested a review from mherwege as a code owner April 1, 2024 06:44
@wborn wborn requested a review from a team April 1, 2024 06:44
lsiepel
lsiepel approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit a9c0f9e into openhab:main Apr 1, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 1, 2024
@wborn wborn deleted the upnpcontrol-catch-iae branch April 1, 2024 07:49
mherwege
mherwege reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
@wborn @lo92fr
[upnpcontrol] Catch IAE when Album Art URI is invalid (openhab#16597)
1c48402 
Fixes openhab#16595

Signed-off-by: Wouter Born <github@maindrain.net>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
@wborn @adr001db
[upnpcontrol] Catch IAE when Album Art URI is invalid (openhab#16597)
480fd2b 
Fixes openhab#16595

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherwege mherwege mherwege left review comments

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[upnpcontrol] Error when parsing URI
3 participants
@wborn @lsiepel @mherwege