Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jdbc] Provide better MySQL datatype for DateTimeType #16604

Merged
merged 1 commit into from Apr 2, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 2, 2024

See analysis here: #15697 (comment)
And test results here: #15697 (comment)

I can currently only test MySQL, so I have scoped the fix accordingly, although other implementations may suffer from something similar.

Resolves #15697
Regression of openhab/openhab1-addons#4605 (in MySQL, both DATETIME and TIMESTAMP support microsecond precision)

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Apr 2, 2024
@jlaur jlaur requested a review from a team as a code owner April 2, 2024 20:03
@jlaur jlaur marked this pull request as draft April 2, 2024 20:48
Resolves openhab#15697

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the 15697-jdbc-mysql-datetimetype branch from c08c8db to 9d6a777 Compare April 2, 2024 20:51
@jlaur jlaur marked this pull request as ready for review April 2, 2024 20:51
@lolodomo lolodomo merged commit 9a178cf into openhab:main Apr 2, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 2, 2024
@jlaur jlaur deleted the 15697-jdbc-mysql-datetimetype branch April 3, 2024 18:30
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Resolves openhab#15697

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
adr001db pushed a commit to adr001db/openhab-addons that referenced this pull request May 12, 2024
Resolves openhab#15697

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JDBC] MySQL OH DateTime items sets DB value field to TimeStamp instead of DateTime
2 participants