New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] Add Roborock S7/S7MaxV mop mode #16608
Conversation
This adds the mop mode feature found in the Roborock S7 vacuum cleaners. Signed-off-by: Ruediger Sopp <ruediger.sopp@gmail.com>
23ea982
to
c687f8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to have a full list of possible mop modes? These could be added as option to the channel-type, making translation / UI-support possible.
Thanks for your contribution! Indeed suggest to add the options , so in the UI you don't see the numbers like 300 but indeed a proper description. Likewise, I think the option is still missing in the translation file: |
Signed-off-by: Ruediger Sopp <ruediger.sopp@gmail.com>
Signed-off-by: Ruediger Sopp <ruediger.sopp@gmail.com>
Thanks for the suggestions! I just added the options for the mop mode. Maybe, it would be a good idea to also add options for the other modes of the vaccum (fan power, water box mode) in another PR? |
yes, it it, at least for the water box mode.. |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
* [miio] Add Roborock S7/S7MaxV mop mode Signed-off-by: Ruediger Sopp <ruediger.sopp@gmail.com>
This PR adds the mop mode feature found in the Roborock S7 vacuum cleaners.
Closes #16607