Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persistence.jpa] Pin to Java 17 #16612

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

holgerfriedrich
Copy link
Member

This is a workaround to allow compiling with Java 21.
Folder is pinned to create Java 17 code.

A PR #16591 is has been opened to upgrade base libraries to a version compatible with Java 21.
I do not expect it to be merged soon, as we need testing before we can proceed.
This is why the workaround should be merged in the meantime.

Refs:
openhab/openhab-distro#1590
openhab/openhab-distro#1640

This is a workaround to allow compiling with Java 21.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 2e4886a into openhab:main Apr 5, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 5, 2024
@holgerfriedrich holgerfriedrich deleted the pr-j21-fixes branch April 5, 2024 19:13
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this pull request Apr 5, 2024
Support Java 21

- Upgrade openjpa from 3.2.2 to 4.0.0
- Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
- Migrate javax.el to jakarta.el-api 6.0.0-RC1
- Revert workaround for Java 21, openhab#16612

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
This is a workaround to allow compiling with Java 21.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-addons that referenced this pull request May 25, 2024
Support Java 21

- Upgrade openjpa from 3.2.2 to 4.0.0
- Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
- Migrate javax.el to jakarta.el-api 6.0.0-RC1
- Revert workaround for Java 21, openhab#16612

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
lsiepel pushed a commit that referenced this pull request May 28, 2024
Support Java 21

- Upgrade openjpa from 3.2.2 to 4.0.0
- Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
- Migrate javax.el to jakarta.el-api 6.0.0-RC1
- Revert workaround for Java 21, #16612

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
Support Java 21

- Upgrade openjpa from 3.2.2 to 4.0.0
- Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
- Migrate javax.el to jakarta.el-api 6.0.0-RC1
- Revert workaround for Java 21, openhab#16612

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants