[ecobee] Improve handling of error code 14 #16613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Hilbush <mark@hilbush.com>
|
For reference: This enhances #16467. |
jlaur
added
enhancement
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Mark Hilbush <mark@hilbush.com>
adr001db
pushed a commit
to adr001db/openhab-addons
that referenced
this pull request
May 9, 2024
Signed-off-by: Mark Hilbush <mark@hilbush.com> Signed-off-by: Alexander Drent <81358972+adr001db@users.noreply.github.com>
adr001db
added a commit
to adr001db/openhab-addons
that referenced
this pull request
May 10, 2024
This reverts commit 159c3e9.
adr001db
pushed a commit
to adr001db/openhab-addons
that referenced
this pull request
May 12, 2024
Signed-off-by: Mark Hilbush <mark@hilbush.com> Signed-off-by: Alexander Drent <81358972+adr001db@users.noreply.github.com> Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
adr001db
added a commit
to adr001db/openhab-addons
that referenced
this pull request
May 12, 2024
This reverts commit 159c3e9. Signed-off-by: Alexander Drent <Alex@Drent-ict.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of error code 14 by forcing a token refresh rather that closing/creating the oauth client service.
@jlaur This is what we talked about previously, and it seems to be working fine for me. It had some issues the first time it executed for me (it eventually worked), but I think it's because Ecobee was restarting servers multiple times. Since then it has worked flawlessly.
I don't think there's a compelling need to cherry pick this for 4.1.x since 4.1.2 is working fine with the oauth client service close/create. But that's your call.