Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lifx] Add support for new LIFX products #16618

Merged
merged 3 commits into from Apr 6, 2024

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 6, 2024

Allows for discovering all the new LIFX products and their features including:

* LIFX Ceiling
* LIFX Outdoor Neon
* LIFX PAR38
* LIFX Round/Square Path
* LIFX Round Spot

See:

* https://github.com/LIFX/products/blob/master/products.json
* https://www.lifx.com/products/neon-flex-16ft-outdoor
* https://www.lifx.com/products/supercolor-1600lm-par38
* https://www.lifx.com/products/spot-light-round
* https://www.lifx.com/products/path-light-round
* https://www.lifx.com/products/path-light-square

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the enhancement An enhancement or new feature for an existing add-on label Apr 6, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just to be sure, nothing to be mentioned in the README?

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Member Author

wborn commented Apr 6, 2024

Just to be sure, nothing to be mentioned in the README?

I've added the new lights so it's easier to see they are supported. 👍

Signed-off-by: Wouter Born <github@maindrain.net>
@lolodomo lolodomo merged commit 79f71ee into openhab:main Apr 6, 2024
3 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Apr 6, 2024
@wborn wborn deleted the lifx-add-new-products branch April 6, 2024 12:42
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
* [lifx] Add support for new LIFX products

Allows for discovering all the new LIFX products and their features including:

* LIFX Ceiling
* LIFX Outdoor Neon
* LIFX PAR38
* LIFX Round/Square Path
* LIFX Round Spot

See:

* https://github.com/LIFX/products/blob/master/products.json
* https://www.lifx.com/products/neon-flex-16ft-outdoor
* https://www.lifx.com/products/supercolor-1600lm-par38
* https://www.lifx.com/products/spot-light-round
* https://www.lifx.com/products/path-light-round
* https://www.lifx.com/products/path-light-square

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants