Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Provide unit hint for water consumption channel #16621

Merged
merged 1 commit into from Apr 7, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 6, 2024

Test report here: #16614 (comment)

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Apr 6, 2024
@jlaur jlaur requested a review from kgoderis as a code owner April 6, 2024 15:17
@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 6, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 0e32ad7 into openhab:main Apr 7, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 7, 2024
@jlaur jlaur deleted the miele-water-consumption-unit-hint branch April 7, 2024 12:23
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants