Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[energidataservice] Restrict CO₂ emission datasets to price area DK1/DK2 #16649

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Apr 13, 2024

Avoid trying to request CO₂ emission data for price areas outside Denmark.

No data would be found, which would result in the Thing showing as OFFLINE with description "No records" (without impact on updates for other channels though).

When linking a CO₂ emission channel while configured price area is not DK*, a warning will be logged.

Regression of #16330

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Apr 13, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 92cc61c into openhab:main Apr 14, 2024
3 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Apr 14, 2024
@jlaur jlaur deleted the energidataservice-co2-only-for-dk branch April 14, 2024 09:51
lo92fr pushed a commit to lo92fr/openhab-addons that referenced this pull request Apr 30, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants