[airq] Improve error handling #16694
Merged
+269
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
fwolter
added
the
enhancement
lsiepel
reviewed
Apr 28, 2024
...es/org.openhab.binding.airq/src/main/java/org/openhab/binding/airq/internal/AirqHandler.java
Show resolved
Hide resolved
|
Thanks! |
lo92fr
pushed a commit
to lo92fr/openhab-addons
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation shows "probably wrong pasword" on most errors, but not all of them are related to a wrong password. E.g. a network error or failing of the decryption caused by limited JVM crypto strength, due to US import restrictions 🙈.
Also, some null warnings were fixed, JSON syntax errors are handled, and network operations in
initialize()were removed.And when the connection failed, the ThingStatus was flapping between ONLINE and OFFLINE, although a connection has never been established.