Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tado] Revert #16686 #16793

Merged
merged 1 commit into from
May 23, 2024
Merged

[tado] Revert #16686 #16793

merged 1 commit into from
May 23, 2024

Conversation

holgerfriedrich
Copy link
Member

Downgrade swagger-codegen-maven-plugin to old version. Add warning to pom file.

Reverts #16686 due to incompatibility showing up only during runtime.

@holgerfriedrich
[tado] Revert openhab#16686
f19b302 
Downgrade swagger-codegen-maven-plugin to old version.
Add warning to pom file.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels May 23, 2024
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/illegalargumentexception-tadomodeterminationcondition-declares-multiple-json-fields-named-type/156112/7

andrewfg
andrewfg approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jlaur
jlaur approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit b5375fe into openhab:main May 23, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone May 23, 2024
@holgerfriedrich holgerfriedrich deleted the pr-plugins-tado-revert branch May 23, 2024 17:51
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/146

@lolodomo lolodomo mentioned this pull request May 25, 2024
Closed
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 15, 2024
@holgerfriedrich @psmedley
[tado] Revert openhab#16686 (openhab#16793)
c5073ca 
Downgrade swagger-codegen-maven-plugin to old version.
Add warning to pom file.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewfg andrewfg andrewfg approved these changes

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@holgerfriedrich @openhab-bot @andrewfg @jlaur