Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hue] Retry once on timeout for GET requests to the bridge (API v1) #16902

Merged
merged 1 commit into from
Jun 22, 2024
Merged

[hue] Retry once on timeout for GET requests to the bridge (API v1) #16902

merged 1 commit into from
Jun 22, 2024

Conversation

lolodomo
Copy link
Contributor

Fix #16723

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[hue] API v1: retry once on timeout for GET requests to the bridge
67045f2 
Fix openhab#16723

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jun 22, 2024
@lolodomo
Copy link
Contributor Author

lolodomo commented Jun 22, 2024 •
edited
Loading

In the last 7 days, I got 219 timeouts to the hue bridge.
The new retry mechanism resolved 95% of these failures (only 11 failed again after the retry).
So it is a massive improvement.

My refresh interval is set to its default, that is 10s. That means 60 480 refreshes in 7 days, each refresh being several requests to the bridge. That means around 0.36% of my refreshes (not requests to the bridge) (219 / 60 480) went in timeout.

@andrewfg for information

lsiepel
lsiepel approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit d2466d5 into openhab:main Jun 22, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone Jun 22, 2024
@lolodomo lolodomo deleted the hue_retry branch June 22, 2024 11:26
@jlaur jlaur changed the title [hue] API v1: retry once on timeout for GET requests to the bridge [hue] Retry once on timeout for GET requests to the bridge (API v1) Jun 22, 2024
@andrewfg
Copy link
Contributor

That means around 0.36% of my refreshes (not requests to the bridge) (219 / 60 480) went in timeout.

I am pleased you got an improvement. By reference the V2 bridge with API V2 has zero timeout events. (So probably your V1 bridge has reached the edge of its capabilities; and as Philips / Signify extends the lamp features, the trend would probably only deteriorate..)

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jun 29, 2024
@lolodomo @psmedley
[hue] API v1: retry once on timeout for GET requests to the bridge (o…
082fe7a 
…penhab#16902)

Fix openhab#16723

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@andrewfg andrewfg Awaiting requested review from andrewfg andrewfg is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[hue] Bridge (v1) going OFFLINE and then ONLINE frequently due to connection lost
3 participants
@lolodomo @andrewfg @lsiepel