[folderwatcher] Folder Watcher Binding initial contribution #4940

goopilot · 2019-02-19T18:15:58Z

This is initial contribution of FTP FolderWatcher binding discussed here:
https://github.com/openhab/openhab2-addons/issues/4547 and here https://github.com/openhab/openhab2-addons/pull/4892
It's purpose is to monitor specific FTP(S) and local folder and trigger channel with new file names.

Fixes #4547

I'm asking community support to review code style and binding logic since it's my first binding and first experience with Java.

ToDo: SFTP, HTTP(S) folders monitoring

https://openhab.jfrog.io/openhab/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.folderwatcher/2.5.5-SNAPSHOT/org.openhab.binding.folderwatcher-2.5.5-SNAPSHOT.jar

Hilbrand · 2019-02-19T19:01:50Z

Just don't open a new pull request everytime you have problems with git. It is totally unnecessary. Just fix you're branch or ask for help. Everytime you open a new pull request we have to look at all sources again and would loose any comments. For one thing it means I'm not going to review this PR anytime soon as I can't trust you keep reopening the pr costing me valuable time because I have to double check everything.

goopilot · 2019-02-19T19:34:06Z

Sorry for that. That is my first time doing PR and working with git. I'm done with messing around now. No more adjustments unless they are requested.

t-8ch · 2019-02-23T16:50:17Z

addons/binding/org.openhab.binding.folderwatcher/ESH-INF/i18n/folderwatcher_xx_XX.properties

@@ -0,0 +1,13 @@
+# FIXME: please substitute the xx_XX with a proper locale, ie. de_DE


This file does nothing

t-8ch · 2019-02-23T16:51:18Z

addons/binding/org.openhab.binding.folderwatcher/ESH-INF/thing/thing-types.xml

@@ -0,0 +1,137 @@
+<?xml version="1.0" encoding="UTF-8"?>


Wrong comments and indentation

t-8ch · 2019-02-23T16:54:10Z

addons/binding/org.openhab.binding.folderwatcher/ESH-INF/thing/thing-types.xml

+
+
+	<!-- Sample Thing Type -->
+    <thing-type id="localfolder">


Does it make sense to have specfic types for local and ftp files?
The binding could support arbitrary types of folders using URLs as configuration.

Perhaps. That will require URL parser to extract configuration parameters.

Yep. This is more of an architectural decision, your choice.
(You could find a URL parser in java.net.URL)

t-8ch · 2019-02-23T16:54:47Z

...er/src/main/java/org/openhab/binding/folderwatcher/internal/FolderWatcherHandlerFactory.java

+@Component(configurationPid = "binding.folderwatcher", service = ThingHandlerFactory.class)
+public class FolderWatcherHandlerFactory extends BaseThingHandlerFactory {
+
+    // = Collections.singleton(THING_TYPE_FTPFOLDER)


...erwatcher/src/main/java/org/openhab/binding/folderwatcher/internal/common/WatcherCommon.java

t-8ch · 2019-02-23T17:13:30Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+
+    @Override
+    public void handleCommand(ChannelUID channelUID, Command command) {
+        if (CHANNEL_FILENAME.equals(channelUID.getId())) {


t-8ch · 2019-02-23T17:14:04Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+            throws IOException {
+        String dirToList = parentDir;
+        Calendar fileTimestamp = null;
+        Calendar cal = Calendar.getInstance();


don't use Calendar. Use java.time.Instant

t-8ch · 2019-02-23T17:14:12Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+                ftp.logout();
+                ftp.disconnect();
+            } catch (IOException e) {
+                logger.debug("Error terminating FTP connection");


log the exception

t-8ch · 2019-02-23T17:15:33Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+                            // do nothing
+                        }
+                    }
+                    logger.debug("Can't conect: {}", e.getMessage());


Use explicit exception logging

no need for "{}", e.getMessage(), just: logger.debug("Can't connect", e)

t-8ch · 2019-02-23T17:16:24Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+                        triggerChannel(CHANNEL_FILENAME, newFtpFile);
+
+                        try {
+                            Thread.sleep(3000);


same as with the local watcher

goopilot · 2019-02-28T02:41:31Z

@t-8ch Thanks for all your comments, what's my next step? Do I fix my code and push it to my git? How will you know that it's being addressed?

t-8ch · 2019-02-28T08:01:38Z

You fix your code and push the new commit to your master branch on GitHub. It will be added automatically to this PR.

Keep this PR open!

When you are done just write a message.

t-8ch · 2019-03-03T10:33:54Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+    @Nullable
+    private FolderLocalWatcherConfiguration config;
+    @Nullable
+    private WatcherCommon FileTools = new WatcherCommon();


This is not nullable, right? (It will go away anyways when making the WatcherCommon methods static.

t-8ch · 2019-03-03T10:34:18Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+    @Nullable
+    private ScheduledFuture<?> executionJob;
+    @Nullable
+    private ArrayList<String> currentLocalListing = new ArrayList<String>();


The two arrays should not be nullable, no?

t-8ch · 2019-03-03T10:34:27Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+        try {
+            previousLocalListing = FileTools.InitStorage(currentLocalListingFile);
+        } catch (IOException e) {
+            logger.debug("Can't write file {}.", currentLocalListingFile);


log the exeption

t-8ch · 2019-03-03T10:35:05Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+                        TimeUnit.SECONDS);
+            });
+        } else {
+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.CONFIGURATION_ERROR);


Add a message, which configuration is broken.

t-8ch · 2019-03-03T10:36:46Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+                triggerChannel(CHANNEL_LOCALFILENAME, newLocalFile);
+
+                try {
+                    Thread.sleep(3000);


How did your rule access the filename?
If it gets it from the trigger event directly it should work (I think)

t-8ch · 2019-03-03T10:38:01Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+                        currentLocalListingFile);
+            } catch (IOException e1) {
+
+                logger.debug("Error geeting new file names");


Log the exception.

t-8ch · 2019-03-03T10:42:29Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+    private ScheduledFuture<?> executionJob, initJob;
+    @Nullable
+    private FTPClient ftp;
+    @Nullable


These seem not be be nullable

t-8ch · 2019-03-03T10:45:01Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+        try {
+            previousFtpListing = FileTools.InitStorage(currentFtpListingFile);
+        } catch (IOException e) {
+            logger.debug("Can't write file {}.", currentFtpListingFile);


exception logging

t-8ch · 2019-03-03T10:45:56Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+                        TimeUnit.SECONDS);
+            });
+        } else {
+            updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.CONFIGURATION_ERROR);


Message for the status

t-8ch · 2019-03-03T10:47:43Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+                            // do nothing
+                        }
+                    }
+                    logger.debug("Can't conect: {}", e.getMessage());


no need for "{}", e.getMessage(), just: logger.debug("Can't connect", e)

t-8ch · 2019-03-03T18:18:46Z

All triggerevents should end up in events.log. Can you see it there correctly?

goopilot · 2019-03-03T18:21:31Z

All triggerevents should end up in events.log. Can you see it there correctly?

Yes, I saw it in events.log correctly.

goopilot · 2019-03-03T20:25:28Z

@t-8ch fixed most of comments. Please tell me if I'm going into right direction.

t-8ch · 2019-03-03T20:26:22Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+        try {
+            previousLocalListing = WatcherCommon.initStorage(currentLocalListingFile);
+        } catch (IOException e) {
+            logger.debug("Can't write file: {} error: {}", currentLocalListingFile, e);


Don't log the error explicitly.

@t-8ch Previously it was suggested to do explicit logging. Could you clarify please?

Ah sorry. For exceptions always use the implicit last argument

logger.debug("foo: {}", someObject, exception);

No need for a placeholder there.

goopilot · 2019-03-05T06:50:47Z

Finished fixing latest remarks

t-8ch · 2019-03-05T20:00:06Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+                currentLocalListing.addAll(listFiles(RootDir, config.listHiddenLocal, config.listRecursiveLocal));
+            } catch (IOException e) {
+
+                logger.debug("Can't read directory: ", config.localDir, e);


This logging is missing one format parameter

t-8ch · 2019-03-05T20:00:36Z

...r/src/main/java/org/openhab/binding/folderwatcher/internal/handler/FolderWatcherHandler.java

+        try {
+            previousFtpListing = WatcherCommon.initStorage(currentFtpListingFile);
+        } catch (IOException e) {
+            logger.debug("Can't write file: ", currentFtpListingFile, e);


logging parameter

@t-8ch done

goopilot · 2019-03-22T06:04:21Z

@t-8ch did you have a chance to review latest changes? I hope it looks better now.

t-8ch · 2019-03-22T19:01:16Z

@goopilot Yep, looks fine to me.

goopilot · 2019-03-25T14:08:44Z

@goopilot Yep, looks fine to me.

What it the next step for me?

t-8ch · 2019-03-25T14:15:37Z

@goopilot Now you are in the same boat as me :-)
We have to wait for one of the maintainers to review and approve it.

goopilot · 2019-03-25T15:16:17Z

@t-8ch Thanks for quick response.

openhab-bot · 2019-03-26T19:01:22Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/folderwatcher-folder-watcher-binding/71149/1

davidgraeff

thanks. I have left some inline comments.

Unfortunately you need to migrate this binding to the new buildsystem before we can merge. See the sticky issue for more information.

davidgraeff · 2019-04-02T15:52:22Z

addons/binding/org.openhab.binding.folderwatcher/ESH-INF/thing/thing-types.xml

+            </parameter>
+        </config-description>
+    </thing-type>
+</thing:thing-descriptions>


Have a look for missing newlines. You will see them as icon in the files changed tab here on github.

davidgraeff · 2019-04-02T15:52:49Z

...er/src/main/java/org/openhab/binding/folderwatcher/internal/FolderWatcherHandlerFactory.java

+            return new FolderWatcherHandler(thing);
+        }
+
+        if (THING_TYPE_LOCALFOLDER.equals(thingTypeUID)) {


should be "else if"

davidgraeff · 2019-04-02T15:53:30Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+    private final Logger logger = LoggerFactory.getLogger(FolderLocalWatcherHandler.class);
+
+    @Nullable
+    private FolderLocalWatcherConfiguration config;


please use the pattern private @Nullable ...

davidgraeff · 2019-04-02T15:54:29Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+        File[] fileList;
+        ArrayList<String> dirList = new ArrayList<String>();
+
+        // create new file


Don't comment the obvious. remove those single line comments and add a javadoc to the method instead and explain what is going on here (as this is a central method anyway)

done, Javadoc still todo

davidgraeff · 2019-04-02T15:54:46Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+            try {
+                currentLocalListing.addAll(listFiles(RootDir, config.listHiddenLocal, config.listRecursiveLocal));
+            } catch (IOException e) {
+


remove empty line

davidgraeff · 2019-04-02T15:54:49Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+            }
+
+            for (String newLocalFile : diffLocalListing) {
+


remove empty line

davidgraeff · 2019-04-02T15:56:02Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/FolderLocalWatcherHandler.java

+            try {
+                WatcherCommon.saveNewListing(diffLocalListing, currentLocalListingFile);
+            } catch (IOException e2) {
+                logger.debug("Can't save new listing into file: ", e2);


If you just want the message of an exception use e2.getMessage(). Sometimes that makes sense.
If the exception is really exceptionally like in unexpected you want the exception object itself like you have done it here, so that the stacktrace is logged.

davidgraeff · 2019-04-02T15:57:46Z

@t-8ch You said you are in the same boat, what is your binding that requires a review?

t-8ch · 2019-04-02T16:00:04Z

@davidgraeff #4629, you already reviewed it earlier today :-)

goopilot · 2019-08-12T21:46:01Z

@davidgraeff Sorry for long delay. I have problems migrating to new buildsystem so I'm thinking of simply setup new Eclipse IDE and copy-pasted source code of this binding. It's not so much in the end.
What would be the latest instruction of setting up Eclipse? The one at https://www.openhab.org/docs/developer/ide/eclipse.html says "We are currently reworking how to setup a perfect development environment. A new step by step guide will appear here soon." Can I still use it?

kaikreuzer · 2019-08-16T17:53:36Z

@goopilot https://www.openhab.org/docs/developer/ide/eclipse.html is up-to-date and should provide you a working IDE setup.
For infos on how to best migrate to the new build system, please check https://github.com/openhab/openhab2-addons/issues/5005#issuecomment-467973902.

TravisBuddy · 2019-08-28T02:10:49Z

Travis tests were successful

Hey @goopilot,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

goopilot · 2019-08-30T02:29:20Z

@davidgraeff I think I finally migrated to new binding system. What will be the next step?

J-N-K · 2019-12-31T21:51:11Z

It seems that this got out of sight. @goopilot are you willing to finish this one? If so, I can do review in the next days.

goopilot · 2020-05-03T17:06:51Z

Ok, should be better now

cpmeister · 2020-05-04T17:27:01Z

...in/java/org/openhab/binding/folderwatcher/internal/config/FtpFolderWatcherConfiguration.java

+ */
+@NonNullByDefault
+public class FtpFolderWatcherConfiguration {
+    public String ftpAddress = new String();


Don't use new String() instead just use an empty string literal. Please update all the others as well.

Suggested change

public String ftpAddress = new String();

public String ftpAddress = "";

cpmeister · 2020-05-04T17:27:14Z

.../java/org/openhab/binding/folderwatcher/internal/config/LocalFolderWatcherConfiguration.java

+ */
+@NonNullByDefault
+public class LocalFolderWatcherConfiguration {
+    public String localDir = new String();


Suggested change

public String localDir = new String();

public String localDir = "";

cpmeister · 2020-05-04T17:28:49Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+            if (config.secureMode.equals("NONE")) {
+                ftp = new FTPClient();
+            } else {
+                switch (config.secureMode) {
+                    case "NONE":
+                        ftp = new FTPClient();
+                        break;
+                    case "IMPLICIT":
+                        ftp = new FTPSClient(true);
+                        break;
+                    case "EXPLICIT":
+                        ftp = new FTPSClient(false);
+                        break;
+                }
+            }


Suggested change

if (config.secureMode.equals("NONE")) {

ftp = new FTPClient();

} else {

switch (config.secureMode) {

case "NONE":

ftp = new FTPClient();

break;

case "IMPLICIT":

ftp = new FTPSClient(true);

break;

case "EXPLICIT":

ftp = new FTPSClient(false);

break;

}

}

switch (config.secureMode) {

case "NONE":

ftp = new FTPClient();

break;

case "IMPLICIT":

ftp = new FTPSClient(true);

break;

case "EXPLICIT":

ftp = new FTPSClient(false);

break;

}

cpmeister · 2020-05-04T17:30:51Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+                return;
+            } catch (IOException e) {
+                updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, e.getMessage());
+            }
+            return;


These return statements aren't needed since you are already at the end of the method.

Suggested change

return;

} catch (IOException e) {

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, e.getMessage());

}

return;

} catch (IOException e) {

updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, e.getMessage());

}

cpmeister · 2020-05-04T17:31:30Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+    }
+
+    private void connectionKeepAlive() {
+        if (ftp.isConnected() == false) {


Suggested change

if (ftp.isConnected() == false) {

if (!ftp.isConnected()) {

cpmeister · 2020-05-04T17:41:17Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/LocalFolderWatcherHandler.java

+    private void refreshFolderInformation() {
+        final String rootDir = config.localDir;
+        try {
+            currentLocalListing.clear();


To avoid any concurrency issues I would suggest just creating a new list each time instead of trying to reuse the old instance.

cpmeister · 2020-05-04T17:43:33Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+                if (!ftpRootDir.startsWith("/")) {
+                    ftpRootDir = "/" + ftpRootDir;
+                }
+                currentFtpListing.clear();


cpmeister · 2020-05-04T17:46:37Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+                long diff = ChronoUnit.HOURS.between(file.getTimestamp().toInstant(), dateNow);
+
+                if (diff < config.diffHours) {
+                    file.setName(dirToList + "/" + currentFileName);


I'm not too familiar with the FTP library so can you tell me why you are setting the file name here?

not sure, probably left-overs from troubleshooting

TravisBuddy · 2020-05-04T22:39:40Z

Travis tests were successful

Hey @goopilot,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister · 2020-05-04T22:47:40Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

@@ -239,7 +231,7 @@ private void refreshFTPFolderInformation() {
                if (!ftpRootDir.startsWith("/")) {
                    ftpRootDir = "/" + ftpRootDir;
                }
-                currentFtpListing.clear();
+                List<String> currentFtpListing = new ArrayList<>();


You also need to call this.currentFtpListing = currentFtpListing; some where later in this method, or is the currentFtpListing field no longer needed?

Yes, this is only used in the current function, so i removed global declaration and will only keep it locally

cpmeister · 2020-05-04T22:48:03Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/LocalFolderWatcherHandler.java

@@ -109,7 +108,7 @@ public void dispose() {
    private void refreshFolderInformation() {
        final String rootDir = config.localDir;
        try {
-            currentLocalListing.clear();
+            List<String> currentLocalListing = new ArrayList<>();


Yes, this is only used in the current function, so i removed global declaration and will only keep it locally

J-N-K · 2020-05-05T18:53:07Z

bundles/org.openhab.binding.folderwatcher/NOTICE

+
+== Source Code
+
+https://github.com/openhab/openhab2-addons


Suggested change

https://github.com/openhab/openhab2-addons

https://github.com/openhab/openhab-addons

J-N-K · 2020-05-05T18:58:23Z

...in/java/org/openhab/binding/folderwatcher/internal/config/FtpFolderWatcherConfiguration.java

+@NonNullByDefault
+public class FtpFolderWatcherConfiguration {
+    public String ftpAddress = "";
+    public int ftpPort;


Suggested change

public int ftpPort;

public int ftpPort = 21;

also applies to the other parameters with default value

@J-N-K do I really need to do this? Isn't it redundant? What's the point of having default value in thing-types.xml then? I don't see this in other bindings.
I've just tested it. When I create thing without specifying ftpPort at all it still sets to 21 even with "public int ftpPort;"

Which don‘t? Should be fixed there. The compiler can‘t know that and should show a warning if it is left uninitialized.

https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.binding.amazondashbutton/src/main/java/org/openhab/binding/amazondashbutton/internal/config/AmazonDashButtonConfig.java
or
https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.binding.airquality/src/main/java/org/openhab/binding/airquality/internal/AirQualityConfiguration.java
I'm sure there are more

On the other hand some other bindings have initialization, so I'm confused.
As I mentioned above even without specifying parameter value in thing config it is using default values as per thing-types.xml. Maybe openhab-core is handling this?

Anyway please let me know the final decision. I'll adjust accordingly.

@J-N-K did you have a chance to look at it?

@J-N-K I'm waiting for a decision on this. Can we have another pair of eyes to review this? I don't think we need to initialize variables here since we have default values in thing-types.xml.

J-N-K · 2020-05-05T19:03:09Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+                    "Polling interval can't be null or negative");
+        }
+
+        if (!config.secureMode.matches("(?i)NONE|IMPLICIT|EXPLICIT")) {


I think it would be better to create an enum for that. You can look https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.binding.mail/src/main/java/org/openhab/binding/mail/internal/config/BaseConfig.java and https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/org.openhab.binding.mail/src/main/java/org/openhab/binding/mail/internal/ServerSecurity.java how to do that

@J-N-K great, in that case I won't need this check at all

J-N-K · 2020-05-05T19:04:28Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+                    "Connection timeout can't be negative");
+            return;
+        }
+        if (config.ftpPort < 0) {


if you place limits on the parameter in the XML, you can skip the check here (also below)

@J-N-K this doesn't work for some reason. Maybe if I add thing via Paper UI that will work, but when I add it via config file I can enter negative value and while debugging I can see that value as negative as well.

IMO this is a bug in openhab-core then.

J-N-K · 2020-05-05T19:06:00Z

...rc/main/java/org/openhab/binding/folderwatcher/internal/handler/FtpFolderWatcherHandler.java

+            ftp.setConnectTimeout(config.connectionTimeout * 1000);
+
+            try {
+                if (config.ftpPort > 0) {


the default is automatically used, so you can always ftp.connect(config.ftpAddress, config.ftpPort);

J-N-K · 2020-05-05T19:06:41Z

.../main/java/org/openhab/binding/folderwatcher/internal/handler/LocalFolderWatcherHandler.java

+            return;
+        }
+
+        if (config.pollIntervalLocal > 0) {


J-N-K · 2020-05-05T19:07:28Z

bundles/org.openhab.binding.folderwatcher/src/main/resources/ESH-INF/thing/thing-types.xml

+				<description>Address of FTP server</description>
+				<context>network-address</context>
+			</parameter>
+			<parameter name="ftpPort" type="integer" min="1" max="65535">


I see you already have the limits set. The framework makes sure that these limits are observed.

J-N-K · 2020-05-05T19:08:19Z

bundles/org.openhab.binding.folderwatcher/src/main/resources/ESH-INF/thing/thing-types.xml

+				<description>Allow listing of sub folders</description>
+				<advanced>true</advanced>
+			</parameter>
+			<parameter name="connectionTimeout" type="integer" min="1" unit="s">


see above, if there is a limit, no need to check that

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

TravisBuddy · 2020-07-07T06:35:32Z

Travis tests have failed

Hey @goopilot,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

J-N-K · 2020-10-31T14:35:02Z

@goopilot Any news here?

kaikreuzer · 2021-01-12T21:21:44Z

Closing this PR as it is not in a mergeable state. Please follow the instructions to port this PR to the main branch for openHAB 3.

goopilot requested a review from a team as a code owner February 19, 2019 18:15

wborn added the new binding If someone has started to work on a binding. For a new binding PR. label Feb 20, 2019

wborn changed the title ~~[FolderWatcher] Initial contribution~~ [folderwatcher] Folder Watcher Binding initial contribution Feb 20, 2019

t-8ch reviewed Feb 23, 2019

View reviewed changes

t-8ch reviewed Mar 3, 2019

View reviewed changes

t-8ch reviewed Mar 5, 2019

View reviewed changes

davidgraeff reviewed Apr 2, 2019

View reviewed changes

davidgraeff self-assigned this Apr 2, 2019

cpmeister requested changes May 4, 2020

View reviewed changes

J-N-K reviewed May 5, 2020

View reviewed changes

J-N-K requested changes May 5, 2020

View reviewed changes

kaikreuzer force-pushed the 2.5.x branch from 536fc42 to 3ab1af1 Compare June 21, 2020 16:12

Alexandr Salamatov added 10 commits July 7, 2020 01:19

fixing code review items

0cf404b

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

fixing code review items

f45b9ab

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

More code review related changes

b945a62

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Renaming thing classes and fixing null checks warnings

d5e2b0f

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Code review related changes

6c88d5e

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Code review related changes.

0e2d35a

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Readme

d8e5308

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Readme

c38de72

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

Edit POM

0fd74ff

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

POM

0e06145

Signed-off-by: Alexandr Salamatov <wpgnetworks@gmail.com>

kaikreuzer added migrate to OH3 and removed migrate to OH3 labels Sep 20, 2020

J-N-K added the awaiting feedback label Oct 31, 2020

J-N-K unassigned davidgraeff Dec 25, 2020

J-N-K added stale As soon as a PR is marked stale, it can be removed 6 months later. and removed awaiting feedback labels Dec 25, 2020

kaikreuzer closed this Jan 12, 2021

		@@ -0,0 +1,13 @@
		# FIXME: please substitute the xx_XX with a proper locale, ie. de_DE

	public String ftpAddress = new String();
	public String ftpAddress = "";

	public String localDir = new String();
	public String localDir = "";

	https://github.com/openhab/openhab2-addons
	https://github.com/openhab/openhab-addons

[folderwatcher] Folder Watcher Binding initial contribution #4940

[folderwatcher] Folder Watcher Binding initial contribution #4940

Conversation

goopilot commented Feb 19, 2019 • edited Loading

Hilbrand commented Feb 19, 2019

goopilot commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goopilot commented Feb 28, 2019 • edited Loading

t-8ch commented Feb 28, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

t-8ch commented Mar 3, 2019 via email

goopilot commented Mar 3, 2019

goopilot commented Mar 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goopilot commented Mar 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goopilot commented Mar 22, 2019

t-8ch commented Mar 22, 2019

goopilot commented Mar 25, 2019

t-8ch commented Mar 25, 2019

goopilot commented Mar 25, 2019

openhab-bot commented Mar 26, 2019

davidgraeff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidgraeff commented Apr 2, 2019

t-8ch commented Apr 2, 2019

goopilot commented Aug 12, 2019

kaikreuzer commented Aug 16, 2019

TravisBuddy commented Aug 28, 2019

Travis tests were successful

goopilot commented Aug 30, 2019

J-N-K commented Dec 31, 2019

goopilot commented May 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

goopilot commented Feb 19, 2019 •

edited

Loading

goopilot commented Feb 28, 2019 •

edited

Loading