Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transform.javascript] Migrate to bnd build #5229

Merged
merged 1 commit into from
Mar 31, 2019
Merged

[transform.javascript] Migrate to bnd build #5229

merged 1 commit into from
Mar 31, 2019

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 24, 2019

Migrates the Javascript Transformation add-on to the bnd build.

@wborn wborn requested a review from a team as a code owner March 24, 2019 17:15
@davidgraeff
Copy link
Member

davidgraeff commented Mar 24, 2019 •
edited
Loading

I know of one PR or soon coming PR that is working on the javascript transformation.

@wborn
Copy link
Member Author

wborn commented Mar 24, 2019

Is it also about migrating the bundle to the bnd build? 😉

@davidgraeff
Copy link
Member

No. But it is rude to cause a merge conflict. Additionally we do not have a working guideline for Eclipse IDE development. If we throw the new buildsystem at people in between their contribution, they will probably quit that contribution.

@martinvw
Copy link
Member

No. But it is rude to cause a merge conflict. Additionally we do not have a working guideline for Eclipse IDE development. If we throw the new buildsystem at people in between their contribution, they will probably quit that contribution.

So you would propose to delay this migration until after that PR?

@davidgraeff davidgraeff mentioned this pull request Mar 24, 2019
Closed
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 25, 2019
@davidgraeff davidgraeff added awaiting other PR Depends on another PR infrastructure Build system and Karaf related issues and PRs labels Mar 26, 2019
@maggu2810 maggu2810 mentioned this pull request Mar 29, 2019
Closed
@wborn
[transform.javascript] Migrate to bnd build
4423c6b 
Migrates the Javascript Transformation add-on to the bnd build.

Signed-off-by: Wouter Born <github@maindrain.net>
@davidgraeff davidgraeff removed the awaiting other PR Depends on another PR label Mar 31, 2019
@davidgraeff davidgraeff merged commit a44d851 into openhab:master Mar 31, 2019
@wborn wborn deleted the transform.javascript-bnd branch March 31, 2019 13:23
@wborn
Copy link
Member Author

wborn commented Mar 31, 2019

I guess we can't wait forever for other PRs to be created some day?

@davidgraeff
Copy link
Member

davidgraeff commented Mar 31, 2019 •
edited
Loading

Yup. And it is not much work to copy the file over if there is indeed some work done already.
And Markus is back and the outstanding issues of the demo-app are fixed in his repo, so we have a working environment again.

@wborn wborn added this to the 2.5 milestone Apr 14, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
@wborn @Pshatsillo
[transform.javascript] Migrate to bnd build (openhab#5229)
a45e72e 
Migrates the Javascript Transformation add-on to the bnd build.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
@wborn @ne0h
[transform.javascript] Migrate to bnd build (openhab#5229)
01ba2d7 
Migrates the Javascript Transformation add-on to the bnd build.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgraeff davidgraeff davidgraeff approved these changes

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wborn @davidgraeff @martinvw