-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MQTT] Migrate to bnd #5240
[MQTT] Migrate to bnd #5240
Conversation
* Split mqtt.generic into mqtt.generic+mqtt.homie+mqtt.homeassistant * open up more API on mqtt.generic to be public for other mqtt bundles to use them * Fix unit tests * Probably fix integration tests (they do not run for me) Signed-off-by: David Graeff <david.graeff@web.de>
It doesn't build on Travis CI:
|
Travis CI now has another error @davidgraeff :
|
* Fix random persistence test failure of the embedded broker (sometimes the file was not unlocked) Signed-off-by: David Graeff <david.graeff@web.de>
0c79b2a
to
69bbfe3
Compare
All green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm.
I'll merge right away as it fixes the build - would be nice if you could create a follow up PR that corrects the NOTICE files.
@@ -0,0 +1,44 @@ | |||
This content is produced and maintained by the Eclipse SmartHome project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an old NOTICE file as it talks about ESH.
@@ -0,0 +1,44 @@ | |||
This content is produced and maintained by the Eclipse SmartHome project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an old NOTICE file as it talks about ESH.
Hello @davidgraeff, it's me again! (Sorry for the many messages) I'm trying the latest openHAB 2.5.0 SNAPSHOT version and I have found the following error after installing the MQTT binding: Long log error, click here to see it
Should I create a new issue or is it fine here? Thank you very much for your work, man! PS: I have reduced the number of lines of the error message, here you have the long version: https://pastebin.com/14RHjbd5 |
Please create a new Issue. This part is enough:
|
* [MQTT] Migrate to bnd * Split mqtt.generic into mqtt.generic+mqtt.homie+mqtt.homeassistant * open up more API on mqtt.generic to be public for other mqtt bundles to use them * Fix unit tests * Probably fix integration tests (they do not run for me) Signed-off-by: David Graeff <david.graeff@web.de> Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
* [MQTT] Migrate to bnd * Split mqtt.generic into mqtt.generic+mqtt.homie+mqtt.homeassistant * open up more API on mqtt.generic to be public for other mqtt bundles to use them * Fix unit tests * Probably fix integration tests (they do not run for me) Signed-off-by: David Graeff <david.graeff@web.de> Signed-off-by: Maximilian Hess <mail@ne0h.de>
This is mostly a migration PR, but unfortunately the diff is still very huge.
Because this was once a ESH extension, the tests a very extensive and should cover all functionality.
The following happened: