[telegram] Telegram Binding initial contribution #5677

ZzetT · 2019-06-02T16:48:49Z

This binding shall work as a replacement for the old OH1 Telegram Actions.
It supports not only sending messages, but also receiving them. The base for the implementation is the TelegramBot library.

User Belgadon (Jens) initially started the work on that binding which still used the old OH1 telegram actions for sending messages. I removed this dependency by using the new OH2 actions and "tried" to migrate it to the new build environement.

The development of that binding was discussed in that thread.

Although I still didn't completly manage to get it running with the latest build environemnt, I was told in the forum to create a PR anyway.
The problems that I still have are either OSGI errors when I click "Resolve" in the bnd demo app or
when I add:

  <properties>
    <bnd.importpackage>org.telegram.telegrambots.*;resolution:="optional"</bnd.importpackage>
  </properties>

then I get ClassNotFoundExceptions at runtime after adding a new Telegram thing.
One more thing to note here, IMHO it should not be necessary to also add a dependency to "telegrambots-meta" in the pom.xml (only telegrambots should be required), but if I remove that I get an error that this is missing.

Please note that the binding is using an apache client instead of a jetty client, but this issue was discussed already and agreed by @davidgraeff .

So, before continuing the work on more features, we need the approval that the library can be integrated into the OH2 environment and what needs to be configured to get it running again. Then, I hope that we can add a few more features in separate PRs for this binding.
Especially two things are currently missing compared to the old Telegram actions:

sending photos located on a webserver that requires username/password
support of html markup (should be easy to realize)

Currently, a beta version of that binding was released to several testers in the forum which however was only based on the old build environement.

Signed-off-by: Alexander Krasnogolowy alexkrasno@hotmail.com

openhab-bot · 2019-06-02T20:06:52Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/announcing-some-improvements-to-the-homekit-plugin-for-openhab2/62729/117

J-N-K

The problem with the bnd resolver may be that the libraries are not OSGi-libraries and require wrapping. I think that BND cannot do that on the fly. #5503 will help with this. This will work in KARAF because wrapping (as requested on the feature.xml) is available.

Adding optional to bnd.importpackage is wrong. You need these classes, they are not optional but required. As a workaround you can add the libraries to the /lib directory. But please do not commit these files.

The library is MIT licensed, I do not see any problem in using it. I didn't check why you use apache http client, can you add a note to this PR? It's easier to find in case someone wants to look it up.

bundles/org.openhab.binding.telegram/NOTICE

bom/openhab-addons/pom.xml

ZzetT · 2019-06-02T21:12:58Z

The library is MIT licensed, I do not see any problem in using it. I didn't check why you use apache http client, can you add a note to this PR? It's easier to find in case someone wants to look it up.

I'm not using the apache http client, but the Telegram library does. I tried to rewrite it, but there were a lot of changes necessary and it would be a big effort to keep it up to date with the original library.

J-N-K · 2019-06-02T21:21:35Z

Ok with me as well. Don‘t rewrite external libs.

ZzetT · 2019-06-03T19:09:47Z

Adding optional to bnd.importpackage is wrong. You need these classes, they are not optional but required. As a workaround you can add the libraries to the /lib directory. But please do not commit these files.

But then do I need this bnd importpackage at all? I found only very few bindings that have this. And some others also use an external library but don't have this bnd statement.

Sorry, I accidentally removed it now. Shall I just remove the optional attribute?

J-N-K · 2019-06-03T19:21:26Z

This is only for very special cases with embedded libraries. You don‘t need it.

J-N-K · 2019-06-06T17:25:42Z

Is there anything missing from me here?

bundles/org.openhab.extensionservice.marketplace.automation/pom.xml

kaikreuzer · 2019-06-08T15:57:51Z

Is there anything missing from me here?

@J-N-K There is still a "changes requested" review from you here - so yes, if you are satisfied, you should change it to an approval.

J-N-K · 2019-06-08T16:06:47Z

Mhm. Is there any better way to remove "requests changes"? I only looked at the infrastructure part, not at the code.

kaikreuzer · 2019-06-08T16:09:15Z

There is usually also a "dismiss review" button as an option.

TravisBuddy · 2019-10-24T09:30:44Z

Travis tests were successful

Hey @ZzetT,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

clinique · 2019-10-24T14:32:20Z

Why is lastMessageDate a String channel ?

- converted lastMessageDate channel type from String to DateItem - exceptions are now reported to the logger as a warning - in case of a 401 error during getUpdates the thing will go offline because it usually means that the thing configuration (botToken) is wrong - fixed mixed tabs and spaces Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

TravisBuddy · 2019-11-05T22:18:16Z

Travis tests were successful

Hey @ZzetT,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

ZzetT · 2019-11-05T22:27:53Z

Why is lastMessageDate a String channel ?

Thanks for the hint, I changed that now.

From my side I would be ready to merge it to the master unless you guys want to have another look. Since the last review a few things have changed (library replacement).

bundles/org.openhab.binding.telegram/pom.xml

bundles/org.openhab.binding.telegram/src/main/feature/feature.xml

bundles/org.openhab.binding.telegram/pom.xml

...openhab.binding.telegram/src/main/java/org/openhab/binding/telegram/bot/TelegramActions.java

...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java

bundles/org.openhab.binding.telegram/src/main/resources/ESH-INF/thing/thing-types.xml

- removed gson as a dependency/feature.xml - removed dead code comment - fixed thing labels - code style Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

TravisBuddy · 2019-11-06T16:20:52Z

Travis tests were successful

Hey @ZzetT,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand

LGTM; @J-N-K You approved some time ago. If you're ok we can merge this binding.

kaikreuzer

We already have 3 approvals and there was still a pending one from me - so let's get it merged! Thanks to everyone involved!!!

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com> Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>

ZzetT requested a review from a team as a code owner June 2, 2019 16:48

J-N-K requested changes Jun 2, 2019

View reviewed changes

bundles/org.openhab.binding.telegram/NOTICE Show resolved Hide resolved

bom/openhab-addons/pom.xml Outdated Show resolved Hide resolved

J-N-K added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 3, 2019

ZzetT requested review from andylintner, clinique, davidgraeff, digitaldan, gbicskei, kaikreuzer, nikotanghe and ssalonen as code owners June 3, 2019 20:42

wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 3, 2019

wborn changed the title ~~[telegram] Initial Contribution~~ [telegram] Telegram Binding initial contribution Jun 3, 2019

wborn added the new binding If someone has started to work on a binding. For a new binding PR. label Jun 3, 2019

davidgraeff approved these changes Jun 6, 2019

View reviewed changes

kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 7, 2019

kaikreuzer requested changes Jun 7, 2019

View reviewed changes

bundles/org.openhab.extensionservice.marketplace.automation/pom.xml Outdated Show resolved Hide resolved

J-N-K approved these changes Jun 8, 2019

View reviewed changes

Hilbrand removed request for JueBag, octa22, limdul79, mgeramb, bobadair, fruggy83, gbicskei and klocsson October 24, 2019 09:23

Hilbrand requested changes Nov 5, 2019

View reviewed changes

incporated finding from Hilbrand:

7e9c349

- removed gson as a dependency/feature.xml - removed dead code comment - fixed thing labels - code style Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

ZzetT requested review from Hilbrand and kaikreuzer November 6, 2019 16:37

Hilbrand approved these changes Nov 6, 2019

View reviewed changes

kaikreuzer approved these changes Nov 7, 2019

View reviewed changes

kaikreuzer merged commit 8b3922b into openhab:master Nov 7, 2019

thewiep pushed a commit to thewiep/openhab-addons that referenced this pull request Nov 23, 2019

[telegram] Telegram Binding initial contribution (openhab#5677)

9f70ded

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

roieg pushed a commit to roieg/openhab-addons that referenced this pull request Nov 28, 2019

[telegram] Telegram Binding initial contribution (openhab#5677)

e12b03d

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

wborn added this to the 2.5 milestone Dec 7, 2019

Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Dec 8, 2019

[telegram] Telegram Binding initial contribution (openhab#5677)

cf7d85a

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

roieg pushed a commit to roieg/openhab-addons that referenced this pull request Dec 25, 2019

[telegram] Telegram Binding initial contribution (openhab#5677)

15d76ab

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

roieg pushed a commit to roieg/openhab-addons that referenced this pull request Dec 26, 2019

[telegram] Telegram Binding initial contribution (openhab#5677)

19a34eb

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020

[telegram] Telegram Binding initial contribution (openhab#5677)

c1e1ac9

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com> Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>

hww3 pushed a commit to hww3/openhab2-addons that referenced this pull request Feb 22, 2020

[telegram] Telegram Binding initial contribution (openhab#5677)

dc8e9cd

Signed-off-by: Alexander Krasnogolowy <alexkrasno@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[telegram] Telegram Binding initial contribution #5677

[telegram] Telegram Binding initial contribution #5677

ZzetT commented Jun 2, 2019 •

edited

openhab-bot commented Jun 2, 2019

J-N-K left a comment

ZzetT commented Jun 2, 2019

J-N-K commented Jun 2, 2019

ZzetT commented Jun 3, 2019

J-N-K commented Jun 3, 2019

J-N-K commented Jun 6, 2019

kaikreuzer commented Jun 8, 2019

J-N-K commented Jun 8, 2019

kaikreuzer commented Jun 8, 2019

TravisBuddy commented Oct 24, 2019

clinique commented Oct 24, 2019

TravisBuddy commented Nov 5, 2019

ZzetT commented Nov 5, 2019

TravisBuddy commented Nov 6, 2019

Hilbrand left a comment

kaikreuzer left a comment

[telegram] Telegram Binding initial contribution #5677

[telegram] Telegram Binding initial contribution #5677

Conversation

ZzetT commented Jun 2, 2019 • edited

openhab-bot commented Jun 2, 2019

J-N-K left a comment

Choose a reason for hiding this comment

ZzetT commented Jun 2, 2019

J-N-K commented Jun 2, 2019

ZzetT commented Jun 3, 2019

J-N-K commented Jun 3, 2019

J-N-K commented Jun 6, 2019

kaikreuzer commented Jun 8, 2019

J-N-K commented Jun 8, 2019

kaikreuzer commented Jun 8, 2019

TravisBuddy commented Oct 24, 2019

Travis tests were successful

clinique commented Oct 24, 2019

TravisBuddy commented Nov 5, 2019

Travis tests were successful

ZzetT commented Nov 5, 2019

TravisBuddy commented Nov 6, 2019

Travis tests were successful

Hilbrand left a comment

Choose a reason for hiding this comment

kaikreuzer left a comment

Choose a reason for hiding this comment

ZzetT commented Jun 2, 2019 •

edited