Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upb] UPB Binding initial contribution #6742

Merged
merged 28 commits into from
Sep 18, 2020
Merged

[upb] UPB Binding initial contribution #6742

merged 28 commits into from
Sep 18, 2020

Conversation

marcusb
Copy link
Contributor

@marcusb marcusb commented Jan 2, 2020

No description provided.

@TravisBuddy
Copy link

TravisBuddy commented Jan 2, 2020

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests have failed

Hey @marcusb,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

2nd Build

Expand here
Single addon pull request: Building org.openhab.binding.upb
[WARNING] The POM for com.sun.xml.bind:jaxb-core:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.sun.xml.bind:jaxb-impl:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector (file:/home/travis/.m2/repository/com/sun/xml/bind/jaxb-impl/2.2.11/jaxb-impl-2.2.11.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Empty report will not be appended to the summary report.
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/message/UPBMessage.java:[72,1766] Unlikely argument type byte for get(Object) on a Map<Integer,UPBMessage.Command>
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingHandler.java:[171,6270] The value of the local variable channel is not used
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingHandler.java:[205,7440] Potential null pointer access: The method getChannelTypeUID() may return null
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBController.java:[39,1373] The value of the field UPBController.ioHandler is not used
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[222,8928] Potential null pointer access: The variable in may be null at this location
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[325,12793] Potential null pointer access: The method getOutputStream() may return null
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[390,15178] Potential null pointer access: The variable out may be null at this location
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/pom.xml [0:0]: Unused Import-Package instructions: [io.swagger.annotations.*, javax.annotation.security.*, org.eclipse.jdt.annotation.*, org.openhab.core.automation.annotation.*, com.google.common.*] 
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/pom.xml [0:0]: Export org.openhab.binding.upb.handler,  has 1,  private references [org.openhab.binding.upb.internal.message]
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
     [java] JVM args ignored when same JVM is used.
     [java] Warnings generated: 1
[INFO] Individual report appended to summary report.
[DEBUG] /home/travis/build/openhab/openhab-addons/target/old_Merge.xml  > report/create_html.xslt  null >  /home/travis/build/openhab/openhab-addons/target/summary_report.html
[ERROR] Code Analysis Tool has found: 
 14 error(s)! 
 16 warning(s) 
 7 info(s)
[WARNING] org.openhab.binding.upb.handler.SerialPIMHandler$SerialIoThread.java:[213]
Avoid throwing raw exception types.
[ERROR] org.openhab.binding.upb.discovery.UPBDiscoveryService.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.discovery.UPBDiscoveryService.java:[26]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.handler.UPBIoHandler.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.UPBIoHandler.java:[24]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.handler.UPBThingHandler.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.UPBThingHandler.java:[44]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.handler.UPBThingHandler.java:[94]
Remove empty line after opening brace
[ERROR] org.openhab.binding.upb.handler.SerialPIMHandler.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.SerialPIMHandler.java:[55]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.handler.SerialPIMHandler.java:[178]
Comment matches to-do format '(TODO)|(FIXME)'.
[WARNING] org.openhab.binding.upb.handler.SerialPIMHandler.java:[181]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.handler.SerialPIMHandler.java:[183]
Name 'ENABLE_MESSAGE_MODE_CMD' must match pattern '^[a-z][a-zA-Z0-9]*$'.
[WARNING] org.openhab.binding.upb.handler.SerialPIMHandler.java:[355]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.handler.VirtualThingHandler.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.VirtualThingHandler.java:[34]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.handler.UPBThingChannel.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.UPBThingChannel.java:[24]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.handler.PIMHandler.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.handler.PIMHandler.java:[39]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.handler.PIMHandler.java:[65]
Comment matches to-do format '(TODO)|(FIXME)'.
[DEBUG] org.openhab.binding.upb.handler.PIMHandler.java:[70]
Comment matches to-do format '(TODO)|(FIXME)'.
[ERROR] org.openhab.binding.upb.internal.UPBController.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.internal.UPBController.java:[37]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.internal.UPBHandlerFactory.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.internal.UPBHandlerFactory.java:[47]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.internal.message.MessageBuilder.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.internal.message.MessageBuilder.java:[23]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] org.openhab.binding.upb.internal.message.ControlWord.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.internal.message.ControlWord.java:[29]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.internal.message.UPBMessage.java:[]
Logger should be non-static field. Change this field (logger) to non-static field.
[ERROR] org.openhab.binding.upb.internal.message.UPBMessage.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.internal.message.UPBMessage.java:[29]
Classes/Interfaces should be annotated with @NonNullByDefault
[DEBUG] org.openhab.binding.upb.internal.message.UPBMessage.java:[92]
Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ERROR] org.openhab.binding.upb.UPBDevice.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[ERROR] org.openhab.binding.upb.Constants.java:[2]
Header line doesn't match pattern ^ \* Copyright \(c\) 2010-2020 Contributors to the openHAB project$
[WARNING] org.openhab.binding.upb.Constants.java:[23]
Classes/Interfaces should be annotated with @NonNullByDefault
[ERROR] Failed to execute goal org.openhab.tools.sat:sat-plugin:0.8.0:report (sat-all) on project org.openhab.binding.upb: 
[ERROR] Code Analysis Tool has found 14 error(s)! 
[ERROR] Please fix the errors and rerun the build.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.openhab.binding.upb

@Hilbrand Hilbrand added new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Jan 3, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @marcusb,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

2nd Build

Expand here
Single addon pull request: Building org.openhab.binding.upb
[WARNING] The POM for com.sun.xml.bind:jaxb-core:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.sun.xml.bind:jaxb-impl:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector (file:/home/travis/.m2/repository/com/sun/xml/bind/jaxb-impl/2.2.11/jaxb-impl-2.2.11.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[INFO] Empty report will not be appended to the summary report.
[WARNING] COMPILATION WARNING : 
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/message/UPBMessage.java:[72,1766] Unlikely argument type byte for get(Object) on a Map<Integer,UPBMessage.Command>
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingHandler.java:[171,6270] The value of the local variable channel is not used
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/UPBThingHandler.java:[205,7440] Potential null pointer access: The method getChannelTypeUID() may return null
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBController.java:[39,1373] The value of the field UPBController.ioHandler is not used
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[222,8928] Potential null pointer access: The variable in may be null at this location
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[325,12793] Potential null pointer access: The method getOutputStream() may return null
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/handler/SerialPIMHandler.java:[390,15178] Potential null pointer access: The variable out may be null at this location
[ERROR] COMPILATION ERROR : 
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[30,1129] The import org.openhab.binding.upb.discovery cannot be resolved
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[65,2652] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[65,2695] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[83,3619] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[83,3650] UPBDiscoveryService cannot be resolved to a type
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project org.openhab.binding.upb: Compilation failure: Compilation failure: 
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[30,1129] The import org.openhab.binding.upb.discovery cannot be resolved
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[65,2652] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[65,2695] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[83,3619] UPBDiscoveryService cannot be resolved to a type
[ERROR] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.upb/src/main/java/org/openhab/binding/upb/internal/UPBHandlerFactory.java:[83,3650] UPBDiscoveryService cannot be resolved to a type
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.openhab.binding.upb

@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@marcusb marcusb closed this Jan 8, 2020
@marcusb marcusb reopened this Jan 8, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@marcusb marcusb force-pushed the upb2 branch 3 times, most recently from 0f9b280 to 3223e85 Compare January 8, 2020 02:30
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcusb,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests have failed

Hey @marcusb,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

1st Build

Expand here
fatal: Invalid symmetric difference expression 041f10b8e9bcc66cd1154afe5a8cca254653dc04...c7bb5ebff65a609265c9aae3f3a1284aea97a214
fatal: Invalid symmetric difference expression 041f10b8e9bcc66cd1154afe5a8cca254653dc04...c7bb5ebff65a609265c9aae3f3a1284aea97a214
Build all
  1/246| openHAB 2 Add-ons 2.5.1-SNAPSHOT
  2/246| openHAB Add-ons :: BOM 2.5.1-SNAPSHOT
  3/246| openHAB Add-ons :: BOM :: Runtime Index 2.5.1-SNAPSHOT
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] openHAB 2 Add-ons                                                  [pom]
[INFO] openHAB Add-ons :: BOM                                             [pom]
[INFO] openHAB Add-ons :: BOM :: Runtime Index                            [jar]
[INFO] openHAB Add-ons :: BOM :: Test Index                               [jar]
[INFO] openHAB Add-ons :: BOM :: openHAB Core Index                       [jar]
[INFO] openHAB Add-ons :: Bundles                                         [pom]
[INFO] openHAB Add-ons :: Bundles :: Airquality Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: AirVisual Node Air Quality Monitor Binding [jar]
[INFO] openHAB Add-ons :: Bundles :: AllPlay Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Amazon Dash Button Binding           [jar]
[INFO] openHAB Add-ons :: Bundles :: Amazon Echo Control Binding          [jar]
[INFO] openHAB Add-ons :: Bundles :: Ambient Weather Binding              [jar]
[INFO] openHAB Add-ons :: Bundles :: Astro Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: Atlona Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Autelis Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: AVM FRITZ! Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: BigAssFan Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Bluetooth Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: BlueGiga Bluetooth Adapter           [jar]
[INFO] openHAB Add-ons :: Bundles :: BlueZ Bluetooth Adapter              [jar]
[INFO] openHAB Add-ons :: Bundles :: Blukii Bluetooth Adapter             [jar]
[INFO] openHAB Add-ons :: Bundles :: RuuviTag Bluetooth Adapter           [jar]
[INFO] openHAB Add-ons :: Bundles :: Bosch Indego Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: BoseSoundTouch Binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: Buienradar Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Chromecast Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: CM11A Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: CoolMasterNet Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: Daikin Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Dark Sky Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Dresden Elektronik deCONZ Binding    [jar]
[INFO] openHAB Add-ons :: Bundles :: Denon / Marantz Binding              [jar]
[INFO] openHAB Add-ons :: Bundles :: Digiplex/EVO Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: DigitalSTROM Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: D-Link Smart Home Binding            [jar]
[INFO] openHAB Add-ons :: Bundles :: DMX Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Doorbird Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: DSCAlarm Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: DSMR Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: DwdUnwetter Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: EleroTransmitterStick Binding        [jar]
[INFO] openHAB Add-ons :: Bundles :: EnOcean Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: EnturNo Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: evohome Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Exec Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Feed Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Feican Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Folding Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Foobot Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Freebox Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Fronius Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: FSInternetRadio Binding              [jar]
[INFO] openHAB Add-ons :: Bundles :: FTP Upload Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Gardena Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Map        [jar]
[INFO] openHAB Add-ons :: Bundles :: GlobalCache Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: GPSTracker Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: GROHE ONDUS Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: HarmonyHub Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: HDanywhere Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Hunter Douglas PowerView Binding     [jar]
[INFO] openHAB Add-ons :: Bundles :: Helios Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Heos Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Homematic Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: HP Printer Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: hue Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Hydrawise Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Hyperion Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: iAquaLink Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: iCloud Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: IHC Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: innogy Smarthome Binding             [jar]
[INFO] openHAB Add-ons :: Bundles :: IPP Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: IRtrans Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: JeeLink Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Keba Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: KM200 Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: KNX Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Kodi Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Konnected Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Kostal Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: LaMetric Time Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: Leap Motion Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: LG HomBot Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: LG TV Serial Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: LG webOS Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: LIFX Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: LIRC Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: LinuxInput Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Log Reader Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Loxone Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Lutron Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Mail Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: MaxCube Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: mcp23017 Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: MELCloud Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: meteoblue Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: meteostick Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Miele Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: Xiaomi Mi Smart Home Binding         [jar]
[INFO] openHAB Add-ons :: Bundles :: Xiaomi Mi IO Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: Millheat Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Milight Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Minecraft Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: Modbus Transport               [jar]
[INFO] openHAB Add-ons :: Bundles :: Modbus Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: MQTT Broker Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: MQTT Things and Channels             [jar]
[INFO] openHAB Add-ons :: Bundles :: MQTT HomeAssistant Convention        [jar]
[INFO] openHAB Add-ons :: Bundles :: MQTT Homie Convention                [jar]
[INFO] openHAB Add-ons :: Bundles :: Nanoleaf Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Neato Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: Neeo Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: NeoHub Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Nest Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Netatmo Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Network Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Network UPS Tools Binding            [jar]
[INFO] openHAB Add-ons :: Bundles :: Nibe Heatpump Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: NibeUplink Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Nikobus Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Niko Home Control Binding            [jar]
[INFO] openHAB Add-ons :: Bundles :: NTP Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Nuki Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Oceanic Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: OmnikInverter Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: OneBusAway Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: OneWireGPIO Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: OneWire Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Onkyo Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: OpenGarage Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: OpenSprinkler Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: OpenUV Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: OpenWeatherMap Binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: Orvibo Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: ParadoxAlarm Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: Pentair Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: PHC Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: PioneerAvr Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: pixometer Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: PJLink Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: PLCLogo Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Plugwise Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Powermax Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Pulseaudio Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Pushbullet Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: RegoHeatPump Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: Rfxcom Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: RME Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Robonect Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Rotel Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: RotelRa1x Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Russound Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: SamsungTV Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Satel Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: Seneye Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: senseBox Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: SerialButton Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: Shelly Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Siemens RDS Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: Sinope Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Silvercrest Wifi Socket Binding      [jar]
[INFO] openHAB Add-ons :: Bundles :: SleepIQ Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: SMA EnergyMeter Binding              [jar]
[INFO] openHAB Add-ons :: Bundles :: Smartmeter Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: SNMP Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: SolarEdge Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Solar-Log Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: SomfyTahoma Binding                  [jar]
[INFO] openHAB Add-ons :: Bundles :: Sonos Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: SonyAudio Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Sony Projector Binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: Spotify Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: SqueezeBox Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Synop Analyzer Binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: Systeminfo Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Tado Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Tankerkoenig Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: Telegram Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Tellstick Binding                    [jar]
[INFO] openHAB Add-ons :: Bundles :: Tesla Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: Toon Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: TP-Link Smart Home Binding           [jar]
[INFO] openHAB Add-ons :: Bundles :: TRÅDFRI Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: UniFi Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: UPB Binding                          [jar]
[INFO] openHAB Add-ons :: Bundles :: Somfy URTSI II binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: ValloxMV Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Vektiva Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Volvo On Call Binding                [jar]
[INFO] openHAB Add-ons :: Bundles :: Velbus Binding                       [jar]
[INFO] openHAB Add-ons :: Bundles :: Vitotronic Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: WeatherCompany Binding               [jar]
[INFO] openHAB Add-ons :: Bundles :: WeatherUnderground Binding           [jar]
[INFO] openHAB Add-ons :: Bundles :: Wemo Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: WiFiLED Binding                      [jar]
[INFO] openHAB Add-ons :: Bundles :: Windcentrale Binding                 [jar]
[INFO] openHAB Add-ons :: Bundles :: XMLTV Binding                        [jar]
[INFO] openHAB Add-ons :: Bundles :: XMPPClient Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: Yamaha Receiver Binding              [jar]
[INFO] openHAB Add-ons :: Bundles :: Yeelight Binding                     [jar]
[INFO] openHAB Add-ons :: Bundles :: Zoneminder Binding                   [jar]
[INFO] openHAB Add-ons :: Bundles :: ZWay Binding                         [jar]
[INFO] openHAB Add-ons :: Bundles :: Extension Service :: Eclipse IoT Marketplace [jar]
[INFO] openHAB Add-ons :: Bundles :: Extension Service :: Eclipse IoT Marketplace (Automation) [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: Homekit                        [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: Hue Emulation Service          [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: ImperiHome Integration Service [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: Java Sound Support             [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: NEEO Integration               [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: openHAB Cloud Connector        [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: MQTT Broker Moquette           [jar]
[INFO] openHAB Add-ons :: Bundles :: IO :: Web Audio Support              [jar]
[INFO] openHAB Add-ons :: Bundles :: Persistence Service :: MapDB         [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Binary To JSON [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Exec       [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: JavaScript [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Jinja      [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: JSonPath   [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: RegEx      [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Scale      [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: XPath      [jar]
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Xslt       [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: Google Cloud Text-to-Speech [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: macOS Text-to-Speech        [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: Mary Text-to-Speech         [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: Pico Text-to-Speech         [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: Polly Text-to-Speech        [jar]
[INFO] openHAB Add-ons :: Bundles :: Voice :: VoiceRSS Text-to-Speech     [jar]
[INFO] openHAB Add-ons :: BOM :: openHAB Add-ons                          [pom]
[INFO] openHAB Add-ons :: Features :: Karaf                               [pom]
[INFO] openHAB Add-ons :: Features :: Karaf :: Add-ons External           [pom]
[INFO] openHAB Add-ons :: Features :: Karaf :: Add-ons                [feature]
[INFO] openHAB Add-ons :: Integration Tests                               [pom]
[INFO] openHAB Add-ons :: Integration Tests :: Astro Binding Tests        [jar]
[INFO] openHAB Add-ons :: Integration Tests :: AVM FRITZ! Binding Tests   [jar]
[INFO] openHAB Add-ons :: Integration Tests :: Feed Binding Tests         [jar]
[INFO] openHAB Add-ons :: Integration Tests :: hue Binding Tests          [jar]
[INFO] openHAB Add-ons :: Integration Tests :: MaxCube Binding Tests      [jar]
[INFO] openHAB Add-ons :: Integration Tests :: Nest Binding Tests         [jar]
[INFO] openHAB Add-ons :: Integration Tests :: NTP Binding Tests          [jar]
[INFO] openHAB Add-ons :: Integration Tests :: Systeminfo Binding Tests   [jar]
[INFO] openHAB Add-ons :: Integration Tests :: TRÅDFRI Binding            [jar]
[INFO] openHAB Add-ons :: Integration Tests :: Wemo Binding Tests         [jar]
[INFO] openHAB Add-ons :: Integration Tests :: Hue Emulation Service Tests [jar]
[INFO] openHAB Add-ons :: Integration Tests :: MapDB Persistence Tests    [jar]
[INFO] 
[INFO] -----------< org.openhab.addons:org.openhab.addons.reactor >------------
[INFO] Building openHAB 2 Add-ons 2.5.1-SNAPSHOT                        [1/246]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ org.openhab.addons.reactor ---
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ org.openhab.addons.reactor ---
[INFO] 
[INFO] --- directory-maven-plugin:0.3.1:directory-of (directories) @ org.openhab.addons.reactor ---
[INFO] Directory of org.openhab.addons:org.openhab.addons.reactor set to: /home/travis/build/openhab/openhab-addons
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ org.openhab.addons.reactor ---
[INFO] Installing /home/travis/build/openhab/openhab-addons/pom.xml to /home/travis/.m2/repository/org/openhab/addons/org.openhab.addons.reactor/2.5.1-SNAPSHOT/org.openhab.addons.reactor-2.5.1-SNAPSHOT.pom
[INFO] 
[INFO] -------< org.openhab.addons.bom:org.openhab.addons.reactor.bom >--------
[INFO] Building openHAB Add-ons :: BOM 2.5.1-SNAPSHOT                   [2/246]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ org.openhab.addons.reactor.bom ---
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ org.openhab.addons.reactor.bom ---
[INFO] 
[INFO] --- directory-maven-plugin:0.3.1:directory-of (directories) @ org.openhab.addons.reactor.bom ---
[INFO] Directory of org.openhab.addons:org.openhab.addons.reactor set to: /home/travis/build/openhab/openhab-addons
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ org.openhab.addons.reactor.bom ---
[INFO] Installing /home/travis/build/openhab/openhab-addons/bom/pom.xml to /home/travis/.m2/repository/org/openhab/addons/bom/org.openhab.addons.reactor.bom/2.5.1-SNAPSHOT/org.openhab.addons.reactor.bom-2.5.1-SNAPSHOT.pom
[INFO] 
[INFO] ----< org.openhab.addons.bom:org.openhab.addons.bom.runtime-index >-----
[INFO] Building openHAB Add-ons :: BOM :: Runtime Index 2.5.1-SNAPSHOT  [3/246]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for openHAB 2 Add-ons 2.5.1-SNAPSHOT:
[INFO] 
[INFO] openHAB 2 Add-ons .................................. SUCCESS [  1.210 s]
[INFO] openHAB Add-ons :: BOM ............................. SUCCESS [  0.509 s]
[INFO] openHAB Add-ons :: BOM :: Runtime Index ............ FAILURE [  1.253 s]
[INFO] openHAB Add-ons :: BOM :: Test Index ............... SKIPPED
[INFO] openHAB Add-ons :: BOM :: openHAB Core Index ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles ......................... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Airquality Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: AirVisual Node Air Quality Monitor Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: AllPlay Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Amazon Dash Button Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Amazon Echo Control Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Ambient Weather Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Astro Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Atlona Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Autelis Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: AVM FRITZ! Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: BigAssFan Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Bluetooth Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: BlueGiga Bluetooth Adapter SKIPPED
[INFO] openHAB Add-ons :: Bundles :: BlueZ Bluetooth Adapter SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Blukii Bluetooth Adapter SKIPPED
[INFO] openHAB Add-ons :: Bundles :: RuuviTag Bluetooth Adapter SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Bosch Indego Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: BoseSoundTouch Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Buienradar Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Chromecast Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: CM11A Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: CoolMasterNet Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Daikin Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Dark Sky Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Dresden Elektronik deCONZ Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Denon / Marantz Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Digiplex/EVO Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: DigitalSTROM Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: D-Link Smart Home Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: DMX Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Doorbird Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: DSCAlarm Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: DSMR Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: DwdUnwetter Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: EleroTransmitterStick Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: EnOcean Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: EnturNo Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: evohome Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Exec Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Feed Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Feican Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Folding Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Foobot Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Freebox Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Fronius Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: FSInternetRadio Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: FTP Upload Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Gardena Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Map SKIPPED
[INFO] openHAB Add-ons :: Bundles :: GlobalCache Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: GPSTracker Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: GROHE ONDUS Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: HarmonyHub Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: HDanywhere Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Hunter Douglas PowerView Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Helios Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Heos Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Homematic Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: HP Printer Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: hue Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Hydrawise Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Hyperion Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: iAquaLink Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: iCloud Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IHC Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: innogy Smarthome Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IPP Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IRtrans Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: JeeLink Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Keba Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: KM200 Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: KNX Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Kodi Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Konnected Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Kostal Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LaMetric Time Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Leap Motion Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LG HomBot Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LG TV Serial Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LG webOS Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LIFX Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LIRC Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: LinuxInput Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Log Reader Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Loxone Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Lutron Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Mail Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MaxCube Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: mcp23017 Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MELCloud Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: meteoblue Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: meteostick Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Miele Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Xiaomi Mi Smart Home Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Xiaomi Mi IO Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Millheat Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Milight Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Minecraft Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: Modbus Transport SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Modbus Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MQTT Broker Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MQTT Things and Channels SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MQTT HomeAssistant Convention SKIPPED
[INFO] openHAB Add-ons :: Bundles :: MQTT Homie Convention  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Nanoleaf Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Neato Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Neeo Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: NeoHub Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Nest Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Netatmo Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Network Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Network UPS Tools Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Nibe Heatpump Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: NibeUplink Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Nikobus Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Niko Home Control Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: NTP Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Nuki Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Oceanic Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OmnikInverter Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OneBusAway Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OneWireGPIO Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OneWire Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Onkyo Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OpenGarage Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OpenSprinkler Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OpenUV Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: OpenWeatherMap Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Orvibo Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: ParadoxAlarm Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Pentair Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: PHC Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: PioneerAvr Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: pixometer Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: PJLink Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: PLCLogo Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Plugwise Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Powermax Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Pulseaudio Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Pushbullet Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: RegoHeatPump Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Rfxcom Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: RME Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Robonect Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Rotel Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: RotelRa1x Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Russound Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SamsungTV Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Satel Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Seneye Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: senseBox Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SerialButton Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Shelly Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Siemens RDS Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Sinope Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Silvercrest Wifi Socket Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SleepIQ Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SMA EnergyMeter Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Smartmeter Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SNMP Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SolarEdge Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Solar-Log Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SomfyTahoma Binding .. SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Sonos Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SonyAudio Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Sony Projector Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Spotify Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: SqueezeBox Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Synop Analyzer Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Systeminfo Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Tado Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Tankerkoenig Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Telegram Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Tellstick Binding .... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Tesla Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Toon Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: TP-Link Smart Home Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: TRÅDFRI Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: UniFi Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: UPB Binding .......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Somfy URTSI II binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: ValloxMV Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Vektiva Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Volvo On Call Binding  SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Velbus Binding ....... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Vitotronic Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: WeatherCompany Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: WeatherUnderground Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Wemo Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: WiFiLED Binding ...... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Windcentrale Binding . SKIPPED
[INFO] openHAB Add-ons :: Bundles :: XMLTV Binding ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: XMPPClient Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Yamaha Receiver Binding SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Yeelight Binding ..... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Zoneminder Binding ... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: ZWay Binding ......... SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Extension Service :: Eclipse IoT Marketplace SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Extension Service :: Eclipse IoT Marketplace (Automation) SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: Homekit ........ SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: Hue Emulation Service SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: ImperiHome Integration Service SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: Java Sound Support SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: NEEO Integration SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: openHAB Cloud Connector SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: MQTT Broker Moquette SKIPPED
[INFO] openHAB Add-ons :: Bundles :: IO :: Web Audio Support SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Persistence Service :: MapDB SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Binary To JSON SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Exec SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: JavaScript SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Jinja SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: JSonPath SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: RegEx SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Scale SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: XPath SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Transformation Service :: Xslt SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: Google Cloud Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: macOS Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: Mary Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: Pico Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: Polly Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: Bundles :: Voice :: VoiceRSS Text-to-Speech SKIPPED
[INFO] openHAB Add-ons :: BOM :: openHAB Add-ons .......... SKIPPED
[INFO] openHAB Add-ons :: Features :: Karaf ............... SKIPPED
[INFO] openHAB Add-ons :: Features :: Karaf :: Add-ons External SKIPPED
[INFO] openHAB Add-ons :: Features :: Karaf :: Add-ons .... SKIPPED
[INFO] openHAB Add-ons :: Integration Tests ............... SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Astro Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: AVM FRITZ! Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Feed Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: hue Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: MaxCube Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Nest Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: NTP Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Systeminfo Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: TRÅDFRI Binding SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Wemo Binding Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: Hue Emulation Service Tests SKIPPED
[INFO] openHAB Add-ons :: Integration Tests :: MapDB Persistence Tests SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  9.293 s
[INFO] Finished at: 2020-01-08T02:31:02Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project org.openhab.addons.bom.runtime-index: Could not resolve dependencies for project org.openhab.addons.bom:org.openhab.addons.bom.runtime-index:jar:2.5.1-SNAPSHOT: Failed to collect dependencies at org.openhab.core.bom:org.openhab.core.bom.runtime:pom:2.5.0 -> org.eclipse.orbit.bundles:io.github.classgraph:jar:4.8.35.v20190528-1517: Failed to read artifact descriptor for org.eclipse.orbit.bundles:io.github.classgraph:jar:4.8.35.v20190528-1517: Could not transfer artifact org.eclipse.orbit.bundles:io.github.classgraph:pom:4.8.35.v20190528-1517 from/to sonatype (https://oss.sonatype.org/content/repositories/releases/): Access denied to: https://oss.sonatype.org/content/repositories/releases/org/eclipse/orbit/bundles/io.github.classgraph/4.8.35.v20190528-1517/io.github.classgraph-4.8.35.v20190528-1517.pom -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.openhab.addons.bom.runtime-index
travis_time:end:07efb018:start=1578450650060886872,finish=1578450662750988653,duration=12690101781,event=script

@tofof
Copy link

tofof commented Jan 20, 2020

Can you provide a JAR for testing?

@marcusb
Copy link
Contributor Author

marcusb commented Jan 20, 2020

@tofof A jar is available from the CI build

@bracklanna
Copy link

End-user testing data point here: I've tried installing & testing this UPB binding on a brand-new, clean install of OH 2.5.1. stand-alone under Mac OS X 10.14.6. Working fine in limited testing so far. Additional details at this post.

@bracklanna
Copy link

@marcusb - you might want to pick a number of appropriate Reviewers and prompt them to look over this PR, using the "Reviewers" field at the upper left of your GitHub web browser session?

Screen Shot 2020-02-18 at 2 05 56 PM

Signed-off-by: Marcus Better <marcus@better.se>
@marcusb
Copy link
Contributor Author

marcusb commented Sep 13, 2020

CI build seems to be successful but timing out just at the end.

@Hilbrand Hilbrand added cre Coordinated Review Effort and removed awaiting feedback labels Sep 13, 2020
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just 2 comments.

@fwolter fwolter self-assigned this Sep 13, 2020
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed your code and here is my feedback. Only some minor things.

Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
When a receive timeout is configured, a read() on the serial input
will return -1 if the timeout elapses with no data available. We
should not treat this as EOF. Also, by waking up the serial thread
every 100ms, we can shut it down gracefully.

Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Signed-off-by: Marcus Better <marcus@better.se>
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 18, 2020
@Hilbrand
Copy link
Member

@fwolter Can you can a last look and merge if deemed oke?

@fwolter fwolter merged commit 41e5ff3 into openhab:2.5.x Sep 18, 2020
@marcusb marcusb deleted the upb2 branch September 20, 2020 23:30
@marcusb
Copy link
Contributor Author

marcusb commented Sep 20, 2020

Thanks for the reviews!

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
Signed-off-by: Marcus Better <marcus@better.se>
@hmerk hmerk mentioned this pull request Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cre Coordinated Review Effort new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants