[shelly]Enhancements and bug fixes #6764

markus7017 · 2020-01-05T03:47:46Z

This PR includes all changes from #6592 and replaces it. PR #6592 has been closed.

Signed-off-by: markus7017 markus7017@gmail.com

…hs new PR Signed-off-by: markus7017 <markus7017@gmail.com>

TravisBuddy · 2020-01-05T03:51:20Z

Travis tests have failed

Hey @markus7017,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

2nd Build

Expand here

Single addon pull request: Building org.openhab.binding.shelly
[ERROR] Failed to execute goal org.commonjava.maven.plugins:directory-maven-plugin:0.3.1:directory-of (directories) on project org.openhab.binding.shelly: Cannot find directory for project: org.openhab.addons:org.openhab.addons.reactor -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

Signed-off-by: markus7017 <markus7017@gmail.com>

TravisBuddy · 2020-01-05T04:22:43Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

markus7017 · 2020-01-05T04:32:22Z

PR #6728 will solve most of the Travis warnings

Signed-off-by: markus7017 <markus7017@gmail.com>

TravisBuddy · 2020-01-05T23:08:20Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: markus7017 <markus7017@gmail.com>

…into 2.5.x

TravisBuddy · 2020-01-07T14:33:41Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

markus7017 · 2020-01-10T02:09:29Z

@kaikreuzer Who will be the 2nd reviewer?

TravisBuddy · 2020-01-18T19:16:09Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Markus Michels <markus7017@gmail.com>

kaikreuzer · 2020-02-01T23:03:16Z

Well, just delete your local 2.5.x branch, rename shelly-snapshot-2.5.x to 2.5.x and do a force push. That should bring this PR to the code revision you have on your shelly-snapshot-2.5.x branch.

kaikreuzer · 2020-02-01T23:03:44Z

Alternatively do a cherry pick of the new commits from shelly-snapshot-2.5.x to 2.5.x and do a normal push.

marked as advanced; Typos in properties corrected Signed-off-by: Markus Michels <markus7017@gmail.com>

TravisBuddy · 2020-02-02T14:31:14Z

Travis tests have failed

Hey @markus7017,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

1st Build

Expand here

Single addon pull request: Building org.openhab.binding.shelly
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyHttpApi.java:[485,21051] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/pom.xml [0:0]: Unused Export-Package instructions: [org.openhab.*] 
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/pom.xml [0:0]: Unused Import-Package instructions: [io.swagger.annotations.*, javax.annotation.security.*, org.eclipse.jdt.annotation.*, org.openhab.core.automation.annotation.*, org.openhab.*, com.google.common.*] 
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
[ERROR] Code Analysis Tool has found: 
 1 error(s)! 
 11 warning(s) 
 4 info(s)
[WARNING] org.openhab.binding.shelly.internal.ShellyHandlerFactory.java:[153]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.api.ShellyEventServlet.java:[124]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[116]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[220]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[291]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.discovery.ShellyDiscoveryParticipant.java:[169]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[132]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[304]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[388]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[749]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyColorUtils.java:[152]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[ERROR] ESH-INF.thing.channels.xml:[263]
There were whitespace characters used for indentation. Please use tab characters instead
[ERROR] Failed to execute goal org.openhab.tools.sat:sat-plugin:0.9.0:report (sat-all) on project org.openhab.binding.shelly: 
[ERROR] Code Analysis Tool has found 1 error(s)! 
[ERROR] Please fix the errors and rerun the build.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.openhab.binding.shelly

### 2nd Build

Expand here

Single addon pull request: Building org.openhab.binding.shelly
[WARNING] The POM for com.sun.xml.bind:jaxb-core:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.sun.xml.bind:jaxb-impl:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector (file:/home/travis/.m2/repository/com/sun/xml/bind/jaxb-impl/2.2.11/jaxb-impl-2.2.11.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int)
WARNING: Please consider reporting this to the maintainers of com.sun.xml.bind.v2.runtime.reflect.opt.Injector
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/coap/ShellyCoapJSonDTO.java:[119,3730] The constructor Integer(int) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/ShellyUtils.java:[103,3483] The method setScale(int, int) from the type BigDecimal is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/ShellyUtils.java:[103,3511] The field BigDecimal.ROUND_HALF_DOWN is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api/ShellyHttpApi.java:[485,21051] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyRelayHandler.java:[379,18527] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyRelayHandler.java:[381,18726] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyRelayHandler.java:[438,21575] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyRelayHandler.java:[442,21916] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyColorUtils.java:[182,5385] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyLightHandler.java:[402,20647] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyLightHandler.java:[501,26078] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyLightHandler.java:[505,26219] The constructor Double(double) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java:[424,19770] The constructor Integer(int) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java:[425,19878] The constructor Integer(int) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/coap/ShellyCoapHandler.java:[348,15899] The constructor Integer(int) is deprecated
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/pom.xml [0:0]: Unused Export-Package instructions: [org.openhab.*] 
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.shelly/pom.xml [0:0]: Unused Import-Package instructions: [io.swagger.annotations.*, javax.annotation.security.*, org.eclipse.jdt.annotation.*, org.openhab.core.automation.annotation.*, org.openhab.*, com.google.common.*] 
[WARNING] Could not find file feature file features/karaf/openhab-addons/src/main/feature/feature.xml
[ERROR] Code Analysis Tool has found: 
 1 error(s)! 
 11 warning(s) 
 4 info(s)
[WARNING] org.openhab.binding.shelly.internal.ShellyHandlerFactory.java:[153]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.api.ShellyEventServlet.java:[124]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[116]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[220]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.coap.ShellyCoapHandler.java:[291]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.discovery.ShellyDiscoveryParticipant.java:[169]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[132]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[304]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[388]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyBaseHandler.java:[749]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[WARNING] org.openhab.binding.shelly.internal.handler.ShellyColorUtils.java:[152]
Avoid catching NullPointerException; consider removing the cause of the NPE.
[ERROR] ESH-INF.thing.channels.xml:[263]
There were whitespace characters used for indentation. Please use tab characters instead
[ERROR] Failed to execute goal org.openhab.tools.sat:sat-plugin:0.9.0:report (sat-all) on project org.openhab.binding.shelly: 
[ERROR] Code Analysis Tool has found 1 error(s)! 
[ERROR] Please fix the errors and rerun the build.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :org.openhab.binding.shelly

Signed-off-by: Markus Michels <markus7017@gmail.com>

TravisBuddy · 2020-02-02T14:40:24Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

markus7017 · 2020-02-02T14:41:26Z

@kaikreuzer Ok, should be ready to continue. Last change is setting status UNKNOWN on initialization and this shows up here and in my 2.5.x branch.

kaikreuzer · 2020-02-02T18:38:11Z

...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java

+     * @param status Shelly device status
+     * @return true: one or more inputs were updated
+     */
+    @SuppressWarnings({ "null", "unused" })


Why do you have to suppress unused? Can't you simply remove unused variables?
Also, please try to avoid null suppressions and rather refactor the code to be fully null-safe.
Ok, if you address this in a future PR, no blocker wrt merging now.

because Eclipse sometimes just report BS

example: For this statement Eclipse reports a redundant null check

Strong thingName = properties.get(PROPERTY_SERVICE_NAME) != null ? properties.get(PROPERTY_SERVICE_NAME).toLowerCase() : thingType;
how to resolved those warnings?

Which is correct, because theoretically another thread could meanwhile remove the property before you call the get.
This should solve those issues:

String thingName = properties.get(PROPERTY_SERVICE_NAME); thingName = thingName!=null ? thingName.toLowerCase() : thingType;

nope, now it's "thingName!=null"

Then probably this way:

String serviceName = properties.get(PROPERTY_SERVICE_NAME); String thingName = serviceName!=null ? serviceName.toLowerCase() : thingType;

That's anyhow cleaner than my previous suggestion.

bundles/org.openhab.binding.shelly/src/main/resources/ESH-INF/config/config.xml

bundles/org.openhab.binding.shelly/src/main/resources/ESH-INF/thing/channels.xml

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 · 2020-02-02T22:33:06Z

@kaikreuzer done

TravisBuddy · 2020-02-02T22:33:08Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-02-02T22:35:03Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: markus7017 <markus7017@gmail.com>

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>

Signed-off-by: markus7017 <markus7017@gmail.com>

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>

This is derived from PR openhab#6592 - to get a clean status I open t…

2dc6151

…hs new PR Signed-off-by: markus7017 <markus7017@gmail.com>

markus7017 mentioned this pull request Jan 5, 2020

[shelly] Add channel for button events #6548

Closed

Adapted to 2.5.1-SNAPSHOT

4b2eb43

Signed-off-by: markus7017 <markus7017@gmail.com>

markus7017 mentioned this pull request Jan 5, 2020

[shelly][WIP] V2.5-2 (fixes & enhancements for the 2.5 release version) #6592

Closed

Remove brightsnessAutoOn from non-light things; PREPARING 2.5.1 final

5f35a90

Signed-off-by: markus7017 <markus7017@gmail.com>

Hilbrand added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Jan 6, 2020

markus7017 changed the title ~~[shelly][WIP] Version 2.5.1 enhancements and bug fixes~~ [shelly]Version 2.5.1 enhancements and bug fixes Jan 6, 2020

markus7017 removed the work in progress A PR that is not yet ready to be merged label Jan 6, 2020

markus7017 requested a review from kaikreuzer January 6, 2020 18:00

markus7017 added 2 commits January 7, 2020 07:39

doc/* removed

8a59b40

Signed-off-by: markus7017 <markus7017@gmail.com>

Merge branch '2.5.x' of https://github.com/openhab/openhab-addons.git …

6a0e327

…into 2.5.x

markus7017 added work in progress A PR that is not yet ready to be merged and removed work in progress A PR that is not yet ready to be merged labels Jan 11, 2020

markus7017 mentioned this pull request Feb 1, 2020

[shelly] RGBW2 : Updating colors from Coap doesn't work [solved] #6949

Closed

property updated fixed

9b0f00b

Signed-off-by: Markus Michels <markus7017@gmail.com>

some more debugging on HttpUtil exception, ext. temp sensor channels

574ff0b

marked as advanced; Typos in properties corrected Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 changed the title ~~[shelly]Version 2.5.1 enhancements and bug fixes~~ [shelly]Enhancements and bug fixes Feb 2, 2020

Set initial status to UNKNOWN rather than keeping INITIALIZING

7024475

Signed-off-by: Markus Michels <markus7017@gmail.com>

kaikreuzer requested changes Feb 2, 2020

View reviewed changes

markus7017 added 2 commits February 2, 2020 23:28

alarm type WAEK_SIGNAL removed as requested by review

d3d13e8

Signed-off-by: Markus Michels <markus7017@gmail.com>

cleanup of removed channels

6318ee1

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 requested a review from kaikreuzer February 2, 2020 22:33

kaikreuzer approved these changes Feb 4, 2020

View reviewed changes

kaikreuzer merged commit e78b117 into openhab:2.5.x Feb 4, 2020

markus7017 mentioned this pull request Feb 9, 2020

[shelly] Support for Duo, EM3, DW, Smoke, Addon; new CoAP-based updates; bug fixes #6985

Merged

andibraeu pushed a commit to andibraeu/openhab-addons that referenced this pull request Feb 17, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

73f8ec9

Signed-off-by: markus7017 <markus7017@gmail.com>

leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

84bcd5a

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>

Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

e16d1ef

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

9162780

Signed-off-by: markus7017 <markus7017@gmail.com>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

85dcf42

Signed-off-by: markus7017 <markus7017@gmail.com>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

22f709f

Signed-off-by: markus7017 <markus7017@gmail.com>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

30dce7a

Signed-off-by: markus7017 <markus7017@gmail.com>

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

1cd70d0

Signed-off-by: markus7017 <markus7017@gmail.com>

DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020

[shelly]Enhancements and bug fixes (openhab#6764)

3738daf

Signed-off-by: markus7017 <markus7017@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>

markus7017 deleted the 2.5.x branch May 26, 2022 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[shelly]Enhancements and bug fixes #6764

[shelly]Enhancements and bug fixes #6764

markus7017 commented Jan 5, 2020 •

edited

TravisBuddy commented Jan 5, 2020

TravisBuddy commented Jan 5, 2020

markus7017 commented Jan 5, 2020

TravisBuddy commented Jan 5, 2020

TravisBuddy commented Jan 7, 2020

markus7017 commented Jan 10, 2020

TravisBuddy commented Jan 18, 2020

kaikreuzer commented Feb 1, 2020

kaikreuzer commented Feb 1, 2020

TravisBuddy commented Feb 2, 2020

TravisBuddy commented Feb 2, 2020

markus7017 commented Feb 2, 2020

kaikreuzer Feb 2, 2020

markus7017 Feb 2, 2020

markus7017 Feb 3, 2020

kaikreuzer Feb 4, 2020

markus7017 Feb 4, 2020 •

edited

kaikreuzer Feb 5, 2020 •

edited

markus7017 commented Feb 2, 2020

TravisBuddy commented Feb 2, 2020

TravisBuddy commented Feb 2, 2020

[shelly]Enhancements and bug fixes #6764

[shelly]Enhancements and bug fixes #6764

Conversation

markus7017 commented Jan 5, 2020 • edited

TravisBuddy commented Jan 5, 2020

Travis tests have failed

2nd Build

TravisBuddy commented Jan 5, 2020

Travis tests were successful

markus7017 commented Jan 5, 2020

TravisBuddy commented Jan 5, 2020

Travis tests were successful

TravisBuddy commented Jan 7, 2020

Travis tests were successful

markus7017 commented Jan 10, 2020

TravisBuddy commented Jan 18, 2020

Travis tests were successful

kaikreuzer commented Feb 1, 2020

kaikreuzer commented Feb 1, 2020

TravisBuddy commented Feb 2, 2020

Travis tests have failed

1st Build

TravisBuddy commented Feb 2, 2020

Travis tests were successful

markus7017 commented Feb 2, 2020

kaikreuzer Feb 2, 2020

Choose a reason for hiding this comment

markus7017 Feb 2, 2020

Choose a reason for hiding this comment

markus7017 Feb 3, 2020

Choose a reason for hiding this comment

kaikreuzer Feb 4, 2020

Choose a reason for hiding this comment

markus7017 Feb 4, 2020 • edited

Choose a reason for hiding this comment

kaikreuzer Feb 5, 2020 • edited

Choose a reason for hiding this comment

markus7017 commented Feb 2, 2020

TravisBuddy commented Feb 2, 2020

Travis tests were successful

TravisBuddy commented Feb 2, 2020

Travis tests were successful

markus7017 commented Jan 5, 2020 •

edited

markus7017 Feb 4, 2020 •

edited

kaikreuzer Feb 5, 2020 •

edited