[tradfri] Added basic support for IKEA blinds FYRTUR and KADRILJ #6977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com>
Signed-off-by: Manuel Raffel <manidu@outlook.com>
- Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
enhancement
J-N-K
requested changes
Feb 11, 2020
| "TRADFRI bulb E27 WS clear 950lm", "TRADFRI bulb GU10 WS 400lm", "TRADFRI bulb E14 WS opal 400lm", | ||
| "FLOALT panel WS 30x30", "FLOALT panel WS 60x60", "FLOALT panel WS 30x90", | ||
| "TRADFRI bulb E12 WS opal 400lm" }; | ||
| private static final List<String> COLOR_TEMP_MODELS = Collections |
There was a problem hiding this comment.
Yes, good point. Why not use a Set here. I changed it.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
approved these changes
Feb 11, 2020
|
Travis fails in itest (doesn't run at all). How do we want to handle that? I have seen that in a lot (all?) of PR lately when it comes to itests. |
|
At least for TRADFRI we ignored them last time (e.g. #6544). |
andibraeu
pushed a commit
to andibraeu/openhab-addons
that referenced
this pull request
Feb 17, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
leluna
pushed a commit
to leluna/openhab2-addons
that referenced
this pull request
Mar 21, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner
pushed a commit
to Hans-Reiner/openhab2-addons
that referenced
this pull request
Apr 11, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
…nhab#6977) * Adds basic support for IKEA smart blinds FYRTUR and KADRILJ * adds the "blind" thing and associated data * temporarily assigned zigbee id "0999", needs review Signed-off-by: Manuel Raffel <manidu@outlook.com> * Restores ISO 8859-1 encoding of .properties file Signed-off-by: Manuel Raffel <manidu@outlook.com> * - Incorporated review comments - Added discovery - Added check for percent values - Aplied formatter - Fixed unit tests Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added repeater Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added TRADFRI open/close remote Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Refactoring of discovery service Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Added handling for STOP command Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> * Incorporated changes from review Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Co-authored-by: Manuel <manraf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6167
Test version: org.openhab.binding.tradfri-2.5.2-SNAPSHOT.zip
Also-by: Manuel Raffel manidu@outlook.com
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de