[dreamscreen][WIP] Initial contribution #6984

markus7017 · 2020-02-09T13:17:18Z

The binding controls the DreamScreen devices. DreamScreen provides Amibilight feature to TVs without that feature. Somehow comparable to Hyperion, but as ready-to-use kit with WiFi and an app to control the devices.

This binding integrates DreamScreen devices into openHAB.

Initial checkin for DreamScreen binding on behalf of Bruce Brouwer, the initial contributor of this binding.

Signed-off-by: Markus Michels markus7017@gmail.com

TravisBuddy · 2020-02-09T13:20:49Z

Travis tests have failed

Hey @markus7017,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

1st Build

Expand here

Single addon pull request: Building org.openhab.binding.dreamscreen
[ERROR] [ERROR] Could not find the selected project in the reactor: :org.openhab.binding.dreamscreen @ 
[ERROR] Could not find the selected project in the reactor: :org.openhab.binding.dreamscreen -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException

### 2nd Build

Expand here

Single addon pull request: Building org.openhab.binding.dreamscreen
[WARNING] The POM for com.sun.xml.bind:jaxb-core:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[WARNING] The POM for com.sun.xml.bind:jaxb-impl:jar:2.2.11 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details
[ERROR] [ERROR] Could not find the selected project in the reactor: :org.openhab.binding.dreamscreen @ 
[ERROR] Could not find the selected project in the reactor: :org.openhab.binding.dreamscreen -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException

TravisBuddy · 2020-02-09T14:11:45Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-02-12T19:01:41Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K · 2020-03-08T08:24:22Z

Thanks for your contribution. Please add documentation. Thanks. Marking at as work-in-progress until then. Remove that after you're done.

D3ltorohd · 2020-03-15T19:12:00Z

Hello, i have a dreamscreen 4k controller to. So when i can help testing that binding, i will do that.

Hilbrand · 2020-09-02T16:09:49Z

@markus7017 What is the status of this binding? The code looks fine. I can review if you want to finish this. Briefly looking a see only minor issues to improve. Most work would be to complete the README.
You'll need to do a rebase (and push force) to fix the merge conflicts.

markus7017 · 2020-09-03T20:02:02Z

@Hilbrand ok, let's go. I could update the README and do the rebase after finishing a small PR for Shelly.

Hilbrand

Here is my review.

bundles/org.openhab.binding.dreamscreen/src/main/feature/feature.xml-e

...screen/src/main/java/org/openhab/binding/dreamscreen/internal/DreamScreenDatagramServer.java

...dreamscreen/src/main/java/org/openhab/binding/dreamscreen/internal/DreamScreenEnumScene.java

....dreamscreen/src/main/java/org/openhab/binding/dreamscreen/internal/DreamScreenEnumMode.java

...ava/org/openhab/binding/dreamscreen/internal/DreamScreenDynamicStateDescriptionProvider.java

bundles/org.openhab.binding.dreamscreen/src/main/resources/ESH-INF/thing/thing-types.xml

Signed-off-by: Markus Michels <markus7017@gmail.com>

TravisBuddy · 2020-09-04T21:30:18Z

Travis tests have failed

Hey @markus7017,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 · 2020-09-04T21:32:32Z

@Hilbrand rebase is done

TravisBuddy · 2020-09-04T21:34:23Z

Travis tests were successful

Hey @markus7017,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Markus Michels <markus7017@gmail.com>

Hilbrand

Just 1 small code comment left (Besides the readme 😉)

...g.dreamscreen/src/main/java/org/openhab/binding/dreamscreen/internal/DreamScreenHandler.java

bundles/pom.xml

d8ahazard · 2020-09-09T01:38:20Z

Fingers crossed that this goes live soon! Looking forward to controlling my DS devices with Ghome.

Hilbrand · 2020-09-13T14:43:35Z

Ok. I've added the label OH3 so we can see it status.

Signed-off-by: Markus Michels <markus7017@gmail.com>

thing config groupId; minor refact Signed-off-by: Markus Michels <markus7017@gmail.com>

Connect ID is 4, not 6. My mistake. Add device ID of 7 for DS solo. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Literally just copypaste the DS HD definitions and change the ID. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Remove all references/calls/passes to "off". Offset is always zero, treat it as such. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Decode our device type when receiving a message and store it in the super. This way, when we get state messages, we know the correct offsets from which to grab data. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Can't make them final as we may need to change them. Could probably be loaded better, this was just the first thing I came up with. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

…e as well... Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Fixes and additions.

kaikreuzer · 2021-01-12T21:26:42Z

Closing this PR as it is not in a mergeable state. Please follow the instructions to port this PR to the main branch for openHAB 3.

J-N-K added the work in progress A PR that is not yet ready to be merged label Mar 8, 2020

J-N-K changed the title ~~[dreamscreen] Initial contribution~~ [WIP][dreamscreen] Initial contribution Mar 8, 2020

wborn added the new binding If someone has started to work on a binding. For a new binding PR. label Mar 15, 2020

kaikreuzer force-pushed the 2.5.x branch from 536fc42 to 3ab1af1 Compare June 21, 2020 16:12

Hilbrand added the awaiting feedback label Sep 2, 2020

Hilbrand requested changes Sep 4, 2020

View reviewed changes

markus7017 added 3 commits September 4, 2020 22:05

Initial checkin for DreamScreen binding on behalf of Bruce Brouwer

7354785

Signed-off-by: Markus Michels <markus7017@gmail.com>

Update POM definitions to include dreamscreen binding

6cc1a1f

Signed-off-by: Markus Michels <markus7017@gmail.com>

debug adjusted

bca66b3

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 force-pushed the dreamscreen_snapshot branch from a3d5a9d to bca66b3 Compare September 4, 2020 21:27

markus7017 requested a review from a team as a code owner September 4, 2020 21:27

rebased + 2.5.9

1789ca0

Signed-off-by: Markus Michels <markus7017@gmail.com>

fwolter removed awaiting feedback work in progress A PR that is not yet ready to be merged labels Sep 5, 2020

fwolter changed the title ~~[WIP][dreamscreen] Initial contribution~~ [dreamscreen] Initial contribution Sep 5, 2020

review changes applied

6a6ca3d

Signed-off-by: Markus Michels <markus7017@gmail.com>

fwolter requested a review from Hilbrand September 6, 2020 18:56

Hilbrand requested changes Sep 6, 2020

View reviewed changes

...g.dreamscreen/src/main/java/org/openhab/binding/dreamscreen/internal/DreamScreenHandler.java Outdated Show resolved Hide resolved

Hilbrand reviewed Sep 8, 2020

View reviewed changes

bundles/pom.xml Show resolved Hide resolved

Hilbrand added the oh3 label Sep 13, 2020

markus7017 and others added 20 commits September 15, 2020 00:59

Adapter Bruce Brouwer's Initial Contribution to 2.5.9 - WIP!

1bbc308

Signed-off-by: Markus Michels <markus7017@gmail.com>

Adapter Bruce Brouwer's Initial Contribution to 2.5.9

f1550e5

Signed-off-by: Markus Michels <markus7017@gmail.com>

minor changes

41979cb

Signed-off-by: Markus Michels <markus7017@gmail.com>

item type for channels mode and scene changed to String

0647784

Signed-off-by: Markus Michels <markus7017@gmail.com>

item type for channel input changed to String

5cee2c1

Signed-off-by: Markus Michels <markus7017@gmail.com>

missing

19c63a4

Signed-off-by: Markus Michels <markus7017@gmail.com>

README updated

f0e643b

Signed-off-by: Markus Michels <markus7017@gmail.com>

new device type Connect, persist power on mode to thing properties; new

dfba37e

thing config groupId; minor refact Signed-off-by: Markus Michels <markus7017@gmail.com>

Fix Connect device ID, add solo Device ID

e661a3a

Connect ID is 4, not 6. My mistake. Add device ID of 7 for DS solo. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Add handler and thing definition for DS solo

9bda8fd

Literally just copypaste the DS HD definitions and change the ID. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Fix whitespace issues

959bbb0

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

We really, really don't need this offset stuff.

96719e8

Remove all references/calls/passes to "off". Offset is always zero, treat it as such. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Dynamically load byte offsets based on device type

c0b829f

Decode our device type when receiving a message and store it in the super. This way, when we get state messages, we know the correct offsets from which to grab data. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Add saturation, brightness, channels and methods.

60200ba

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Use product_id constants instead of hardcoding

cba5f10

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Refactor offset names, change access to static

58f2053

Can't make them final as we may need to change them. Could probably be loaded better, this was just the first thing I came up with. Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Maven/spotless cleanup

cea989d

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Add constant for magic byte

22dddec

Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Add handler for solo, not sure if we need sidekick or connect in ther…

5a10ad3

…e as well... Signed-off-by: d8ahazard <d8ahazard@gmail.com>

Merge pull request #12 from d8ahazard/dreamscreen_snapshot

4dae9f8

Fixes and additions.

kaikreuzer added migrate to OH3 and removed migrate to OH3 labels Sep 20, 2020

wborn removed the oh3 label Oct 17, 2020

kaikreuzer closed this Jan 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dreamscreen][WIP] Initial contribution #6984

[dreamscreen][WIP] Initial contribution #6984

markus7017 commented Feb 9, 2020

TravisBuddy commented Feb 9, 2020

TravisBuddy commented Feb 9, 2020

TravisBuddy commented Feb 12, 2020

J-N-K commented Mar 8, 2020

D3ltorohd commented Mar 15, 2020

Hilbrand commented Sep 2, 2020

markus7017 commented Sep 3, 2020

Hilbrand left a comment

TravisBuddy commented Sep 4, 2020

markus7017 commented Sep 4, 2020

TravisBuddy commented Sep 4, 2020

Hilbrand left a comment

d8ahazard commented Sep 9, 2020

Hilbrand commented Sep 13, 2020

kaikreuzer commented Jan 12, 2021

[dreamscreen][WIP] Initial contribution #6984

[dreamscreen][WIP] Initial contribution #6984

Conversation

markus7017 commented Feb 9, 2020

TravisBuddy commented Feb 9, 2020

Travis tests have failed

1st Build

TravisBuddy commented Feb 9, 2020

Travis tests were successful

TravisBuddy commented Feb 12, 2020

Travis tests were successful

J-N-K commented Mar 8, 2020

D3ltorohd commented Mar 15, 2020

Hilbrand commented Sep 2, 2020

markus7017 commented Sep 3, 2020

Hilbrand left a comment

Choose a reason for hiding this comment

TravisBuddy commented Sep 4, 2020

Travis tests have failed

markus7017 commented Sep 4, 2020

TravisBuddy commented Sep 4, 2020

Travis tests were successful

Hilbrand left a comment

Choose a reason for hiding this comment

d8ahazard commented Sep 9, 2020

Hilbrand commented Sep 13, 2020

kaikreuzer commented Jan 12, 2021