Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nuki] Improve Nuki ID description #7111

Merged
merged 1 commit into from Mar 7, 2020
Merged

[nuki] Improve Nuki ID description #7111

merged 1 commit into from Mar 7, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 7, 2020

Syncs the Thing description with the docs.

Fixes #7061

Is this OK @mkatter?

Fixes #7061

Signed-off-by: Wouter Born <github@maindrain.net>
@J-N-K J-N-K merged commit 105a0a9 into 2.5.x Mar 7, 2020
@wborn wborn deleted the nukiid branch March 7, 2020 17:54
@mkatter
Copy link

mkatter commented Mar 8, 2020

@wborn Absolutely - It is the same info text now like in the docs.
Thank you :)

@wborn
Copy link
Member Author

wborn commented Mar 8, 2020

Great! If we're really sure that the nukiId is always a hexadecimal string of 8 chars we could also add a pattern to the configuration parameter for validation: pattern="([0-9A-Fa-f]{8})"

@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Mar 18, 2020
@kaikreuzer kaikreuzer added this to the 2.5.3 milestone Mar 18, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Fixes openhab#7061

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nuki] Bridge Callback not working
6 participants