Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed mapdb persistence service #7183

Merged
merged 1 commit into from
Mar 16, 2020
Merged

removed mapdb persistence service #7183

merged 1 commit into from
Mar 16, 2020

Conversation

kaikreuzer
Copy link
Member

... as it is contained in #5275, not used in 2.5 and currently breaking the 3.x build.

Signed-off-by: Kai Kreuzer kai@openhab.org

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@TravisBuddy
Copy link

Travis tests were successful

Hey @kaikreuzer,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister
Copy link
Contributor

The 3.x build is in the 2.5.x branch? I thought the 3.x build is supposed to be master?

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wborn wborn merged commit fb5f36a into openhab:2.5.x Mar 16, 2020
@wborn
Copy link
Member

wborn commented Mar 16, 2020

The https://ci.openhab.org/job/openHAB-Addons-port build ports all 2.5.x add-ons to the master branch. The persistence APIs have changed in 3.x so mapdb would have to be updated for that. But that is difficult if it is still on the 2.5.x branch.

@kaikreuzer kaikreuzer added this to the 2.5.3 milestone Mar 18, 2020
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer deleted the mapdb branch November 13, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants