Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pjlink] use parameter-groups for better structure of thing parameters #7472

Merged
merged 1 commit into from Apr 26, 2020

Conversation

nils
Copy link
Contributor

@nils nils commented Apr 25, 2020

This PR adds parameter groups to the pjlinkdevice thing for a better visual structure. No new features or parameters have been introduced.

@nils nils added the enhancement An enhancement or new feature for an existing add-on label Apr 25, 2020
…s in PaperUI

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
@nils nils force-pushed the parameter-group-for-refresh branch from 9728de3 to 25c5dca Compare April 25, 2020 18:12
@TravisBuddy

This comment has been minimized.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @nils,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@nils nils requested review from J-N-K and cpmeister April 25, 2020 21:08
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit c5fdd32 into openhab:2.5.x Apr 26, 2020
@cpmeister cpmeister added this to the 2.5.5 milestone Apr 26, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
…s in PaperUI (openhab#7472)

Signed-off-by: Nils Schnabel <github@to.nilsschnabel.de>
@nils nils deleted the parameter-group-for-refresh branch November 2, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants