Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' #7728

Merged
merged 3 commits into from
May 25, 2020
Merged

[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' #7728

merged 3 commits into from
May 25, 2020

Conversation

lolodomo
Copy link
Contributor

Relative to #7722

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils'
6957f7a 
Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

This was pushed without a working maven buiuld (Maven build is currently not working due to download failures).

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K
J-N-K requested changes May 22, 2020
View reviewed changes
...owermax/src/main/java/org/openhab/binding/powermax/internal/connector/PowermaxConnector.java Outdated
@@ -63,11 +62,17 @@ protected void cleanup() {
}

if (output != null) {
IOUtils.closeQuietly(output);
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using closeQuietly is wrong here. The description clearly says, that it should only be used when normal processing failed (e.g. to close after an exception has been thrown and we are in a finally block), This is clearly not the case here. I would prefer to log something in case closing failes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bindings are doing that like that !
I have already 12 PRs to update in this case.
Is DEBUG level ok for you ?

@lolodomo
Log added in case of error while closing input/output stream
a374d10 
Singed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo
Copy link
Contributor Author

This was pushed without a working maven buiuld (Maven build is currently not working due to download failures).

Using the offline mode (mvn -o clean install), the local build succeeded.

@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
In/out streams closed when the socket is closed
5e32153 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo
Copy link
Contributor Author

@cweitkamp @J-N-K : is ok now with the error logged ? Should we log only the error message or the stack trace too ?

cweitkamp
cweitkamp approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it. Thanks.

@J-N-K feel free to merge if you agree.

@J-N-K
Copy link
Member

J-N-K commented May 25, 2020

Manually verified sign-off ok

@J-N-K J-N-K merged commit f604b41 into openhab:2.5.x May 25, 2020
@lolodomo lolodomo deleted the powermax_ioutils branch May 25, 2020 15:59
@cpmeister cpmeister added this to the 2.5.6 milestone May 25, 2020
bodiroga pushed a commit to bodiroga/openhab-addons that referenced this pull request May 26, 2020
@lolodomo @bodiroga
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
f9b8b73 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
e084fbd 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
0053b7d 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
28e73e4 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
7f7dc0c 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
9ac57f0 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
4946026 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
2054d7a 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
e15e14a 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[powermax] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
8c89903 
…nhab#7728)

* [powermax] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lolodomo @TravisBuddy @J-N-K @cweitkamp @cpmeister