[pentair] 7836-pentair binding improvements #7837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Integrated the "feature" support in to new controller groups. * Implemented controller schedules (both read and write) implementation Various other fixes * Addressed many warning/errors and cleanup * Added support for units on temperatures, power, etc. * Added intelliflo gpm fixed spelling error added intelliflo status * Added direct support for motor (when controller is not present or in service mode) * Removed apache.commons dependency * Removed gnu.io dependency. Reworked some of the state changes in the basebridgehandler. * Added auto discovery Finished schedule implementation Various other fixes Addressed many warning/errors More cleanup Updated README with changes. Added support for UOM Added intelliflo gpm fixed spelling error added intelliflo status Removed apache.commons import Removed gnu.io dependency. Reworked some of the state changes in the basebridgehandler. Added auto discovery Signed-off-by: Jeff James <jeff@james-online.com>
Travis tests were successfulHey @jsjames, |
jsjames
changed the title
This was
linked to
issues
Jun 2, 2020
cweitkamp
added
the
enhancement
|
The thingtype and channel name changes would make this PR non-backwards-compatible for existing users. Are you ok with the PR being pushed back until openHAB 3? |
|
This can wait until 3.0. It does address removing the org.apache.commons and the gnu.io library. |
Travis tests were successfulHey @jsjames, |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished schedule implementation
Various other fixes
Addressed many warning/errors
More cleanup
Updated README with changes.
Added support for UOM
Added intelliflo gpm
fixed spelling error
added intelliflo status
Removed apache.commons import
Removed gnu.io dependency. Reworked some of the state changes in the basebridgehandler.
Added auto discovery