[mqtt.generic] Clear availability subscriptions on stop #8317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
bodiroga
force-pushed
the
fix-8316-offline
branch
from
2086e2b
to
9131aec
Compare
bodiroga
changed the title
J-N-K
approved these changes
Aug 22, 2020
|
@jochen314 I would like to hear your thoughts. |
|
I guess, I missed that. The method was empty before... Could we add the call to |
Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
Sure, I didn't add it because the Homie binding doesn't make use of the availability topic feature, but it is way better to keep all three handlers synchronized. Done! 👍 |
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
This was referenced Sep 4, 2020
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Closes openhab#8316 Signed-off-by: Aitor Iturrioz <riturrioz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Home Assistant and MQTT generic things were disposed (and stopped), parent class (AbstractMQTTThingHandler)
stop()method was not called and, thus, availability subscriptions were not removed. This made the Thing stay offline in some cases, as described in #8316.The AbstractMQTTThingHandler's
stop()method has also been simplified callingclearAllAvailabilityTopics();. @jochen314, what do you think about this last change? I don't see any problem emptying the availabilityStates map of AbstractMQTTThingHandler, because theinitialize()method of both GenericThingHandler and HomeAssistantThingHandler takes care of creating the map again.Fixes #8316
Review request: @jochen314, @J-N-K, @fwolter, @cpmeister, @Hilbrand.
Signed-off-by: Aitor Iturrioz riturrioz@gmail.com