Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Some logging adjustments for data thing #8368

Merged
merged 1 commit into from Sep 3, 2020

Conversation

ssalonen
Copy link
Contributor

Resolves #6113

Also adjusted some error level logging lower since the thing status
will be updated in any case, no need to repeat it in the logs.

Ping @Rossko57 , please review

Signed-off-by: Sami Salonen ssalonen@gmail.com

Resolves openhab#6113

Also adjusted some error level logging lower since the thing status
will be updated in any case, no need to repeat it in the logs.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Aug 31, 2020
@Rossko57
Copy link
Contributor

Rossko57 commented Sep 2, 2020

Yes Sami, that looks nice, thanks

Signed-off-by: Ross Kennedy rossko@culzean.clara.co.uk

@Hilbrand Hilbrand merged commit 28203c6 into openhab:2.5.x Sep 3, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 3, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
Closes openhab#6113

Also adjusted some error level logging lower since the thing status
will be updated in any case, no need to repeat it in the logs.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Closes openhab#6113

Also adjusted some error level logging lower since the thing status
will be updated in any case, no need to repeat it in the logs.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
Closes openhab#6113

Also adjusted some error level logging lower since the thing status
will be updated in any case, no need to repeat it in the logs.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[modbus] Change some error / warn reporting
3 participants