Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alarmdecoder] Fix keypad address mask handling #8406

Merged
merged 2 commits into from Sep 8, 2020
Merged

[alarmdecoder] Fix keypad address mask handling #8406

merged 2 commits into from Sep 8, 2020

Conversation

bobadair
Copy link
Member

@bobadair bobadair commented Sep 5, 2020

This update fixes multiple issues with keypad address mask handling.
It is currently marked WIP because of on-going testing.

@bobadair
[alarmdecoder] Fix keypad address mask handling
8a44971 
Signed-off-by: Bob Adair <bob.github@att.net>
@bobadair
[alarmdecoder] Doc update
3931896 
Signed-off-by: Bob Adair <bob.github@att.net>
@bobadair bobadair added bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged labels Sep 5, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @bobadair,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When you''re done testing please remove the wip and we will merge this pr.

@bobadair bobadair removed the work in progress A PR that is not yet ready to be merged label Sep 8, 2020
@bobadair bobadair changed the title [WIP][alarmdecoder] Fix keypad address mask handling [alarmdecoder] Fix keypad address mask handling Sep 8, 2020
@bobadair
Copy link
Member Author

bobadair commented Sep 8, 2020

Thanks @Hilbrand! There were no problems reported by the people testing it, so I've removed the WIP label.

@Hilbrand Hilbrand merged commit 7730a52 into openhab:2.5.x Sep 8, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 8, 2020
@bobadair bobadair deleted the adbugfix branch September 8, 2020 22:14
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@bobadair @CSchlipp
[alarmdecoder] Fix keypad address mask handling (openhab#8406)
536a108 
Signed-off-by: Bob Adair <bob.github@att.net>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@bobadair @markus7017
[alarmdecoder] Fix keypad address mask handling (openhab#8406)
b0fbc4a 
Signed-off-by: Bob Adair <bob.github@att.net>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@bobadair @andrewfg
[alarmdecoder] Fix keypad address mask handling (openhab#8406)
1d89df0 
Signed-off-by: Bob Adair <bob.github@att.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobadair @TravisBuddy @Hilbrand