[openwebnet] add support for WHO=2 Automation #8437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0.3.0. Fixes openhab#8436 Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Travis tests were successfulHey @mvalla, |
Hilbrand
requested changes
Sep 9, 2020
There was a problem hiding this comment.
Just some comments mainly about reducing log levels. Regarding logging see also https://www.openhab.org/docs/developer/guidelines.html#f-logging
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetAutomationHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Thanks for the suggestions and quick review. I changed where requested and also minimized all INFO/WARN log messages. |
Travis tests were successfulHey @mvalla, |
Hilbrand
approved these changes
Sep 10, 2020
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
* update openwebnet4j to 0.3.0. * Closes openhab#8436 Signed-off-by: Massimo Valla <mvcode00@gmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* update openwebnet4j to 0.3.0. * Closes openhab#8436 Signed-off-by: Massimo Valla <mvcode00@gmail.com>
kaikreuzer
added
the
enhancement
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
* update openwebnet4j to 0.3.0. * Closes openhab#8436 Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for WHO=2 Automation.
Updated openwebnet4j to 0.3.0.
Fixes #8436