[revogi] Initial contribution - Resubmitted for OH3

[andibraeu]

Signed-off-by: Andreas Bräu ab@andi95.de

Revogi Binding

Due to the move to OH3 I transformed the binding, and it's now based on the OH3 main branch. The previous PR was #7029

This PR will add a new binding for Revogi's Smart Strip (SOW019). I added a thread at https://community.openhab.org/t/binding-for-revogi-smart-strip-sow019/92923

Description

If you use the Smart Strip with the Revogi Home App, you always need internet access to use this device. With this binding you can control the Smart Strip without the need of a cloud based solution in the internet.

The binding supports to switch every 6 plugs separately, retrieve statistics for each plug or switch all 6 plugs together. All of this works by sending UDP packets.

Testing

Let's wait for a first build, then I can provide a link to the built jar!

[TravisBuddy]

Hey @andibraeu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8da1e560-14ac-11eb-aff7-dd8cbeb067cc

[andibraeu]

BTW: the Jenkins build doesn't seem to checkout the PR branch. It builds for another commit and these changes aren't included. The build is failing because of another binding.

@kaikreuzer, I'm not sure if you're the right person to address this.

[kaikreuzer]

All checks green!

[andibraeu]

Thank you!
But in the jenkins build my binding doesn't appear: https://ci.openhab.org/job/PR-openHAB-Addons/222/
Is there anything configured wrong on my side?

[kaikreuzer]

That's indeed weird. I have changed the build configuration now in the hope that it works as expected - let's have a try and see!

[andibraeu]

nice, now it worked!

[kaikreuzer]

Are you sure? Why did it fail with static analysis errors on Astro tests...?

[andibraeu]

oh I see.. maybe I was a bit too fast.

will my PR be applied to the HEAD of this branch during the build? Or is it build based on the commit I used when I created my branch?

[kaikreuzer]

I've now cleaned the workspace of the build job and will try again.

will my PR be applied to the HEAD of this branch during the build?

Yes, it is merged with the head of the main branch.

[andibraeu]

Unfortunately it still fails because of the Astro Binding Integration tests

[kaikreuzer]

On other PRs, this has meanwhile disappeared. I'll try one more...

[andibraeu]

Now we've got a successful build, but it was aborted in the end:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:56 h
[INFO] Finished at: 2020-09-23T17:54:11Z
[INFO] ------------------------------------------------------------------------
Build timed out (after 180 minutes). Marking the build as aborted.

[Hilbrand]

On the older pr build @wborn had recently increased the timeout to 4 hours because a lot of pr builds did timeout.

[wborn]

I've increased it on this build job as well.

[fwolter]

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

[fwolter]

LGTM

[andibraeu]

unfortunately the build fails at the moment, it is cause by https://ci.openhab.org/job/PR-openHAB-Addons/612/org.openhab.addons.itests$org.openhab.binding.modbus.tests/consoleFull

[cpmeister]

Only a few minor changes and I think we are good to go. I'll merge as soon as it is done.