Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WLed] Initial contribution - Binding for LED strings with a large range of built in FX. #8669

Merged
merged 51 commits into from Nov 3, 2020
Merged

[WLed] Initial contribution - Binding for LED strings with a large range of built in FX. #8669

merged 51 commits into from Nov 3, 2020

Conversation

Skinah
Copy link
Contributor

@Skinah Skinah commented Oct 5, 2020 •
edited

This new openHAB binding allows you to auto discover (using mDNS) and control LED strings based on the opensource WLED project:
https://github.com/Aircoookie/WLED

It uses a Jetty HttpClientFactory instance and needs no dependencies and a number of users are reporting the 2.5.9 version is working here on the forum:
https://community.openhab.org/t/wled-a-binding-for-controlling-led-strips-and-strings-from-an-opensource-esp8266-project/87286

Precompiled jar for 2.5.9
https://github.com/Skinah/wled/releases/download/2020-10-05/wled-2.5.9.zip

Precompiled jar for 3.0.0
http://www.pcmus.com/openhab/wled/org.openhab.binding.wled-3.0.0-SNAPSHOT.zip

Signed-off-by: Matthew Skinner matt@pcmus.com

@Skinah Skinah requested a review from a team as a code owner October 5, 2020 10:19
@TravisBuddy
Copy link

TravisBuddy commented Oct 5, 2020 •
edited

Travis tests were successful

Hey @Skinah,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@cpmeister cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label Oct 5, 2020
fwolter
fwolter requested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution again! I reviewed your code and here is my feedback.

bundles/org.openhab.binding.wled/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/README.md Show resolved Hide resolved
bundles/org.openhab.binding.wled/README.md Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/src/main/feature/feature.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@Skinah
Copy link
Contributor Author

Skinah commented Oct 24, 2020

Thanks @fwolter for the review and help, I think I have now addressed all your comments.

fwolter
fwolter approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter added the cre Coordinated Review Effort label Oct 27, 2020
cpmeister
cpmeister requested changes Oct 28, 2020
View reviewed changes
...enhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedBindingConstants.java Outdated Show resolved Hide resolved
...enhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedDiscoveryService.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
...es/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/WLedHandler.java Outdated Show resolved Hide resolved
@cpmeister
Copy link
Contributor

looks like something went wrong with your branch, there are conflicts and a lot of unrelated changes...

@Skinah
Copy link
Contributor Author

Skinah commented Oct 30, 2020

looks like something went wrong with your branch, there are conflicts and a lot of unrelated changes...

Yes I am not good with git when things go wrong, don’t know why as they are unrelated to this binding with no conflicts to my binding and it got late last night so will look into it soon.

Skinah and others added 19 commits October 30, 2020 18:25
@Skinah
V3
d3f8aa8 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
formatting.
66fa166 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
V3 binding
9a536cd 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
POM fixed
a9db5de 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Add comments.
ae8d5d1 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
add to CODEOWNERS
792205f 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Comments
d334261 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Spotless and POM fixed.
e3dfba2 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Update examples to be compatible with 'Create equipment from thing' in
9588cad 
V3.x

Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Change thing type category
878f185 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
464e951 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
3114645 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/feature/feature.xml
ce88330 
Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thi…
a40b4ad 
…ng/thing-types.xml


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
6130051 
…ding/wled/internal/WLedDiscoveryService.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
23f7e6b 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
5590447 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
remove unneeded threadpool.
333b150 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Use BigDecimal.ZERO
ab70200 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah and others added 11 commits October 30, 2020 18:25
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thi…
1bb8696 
…ng/thing-types.xml


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @fwolter
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
e2869a5 
…ding/wled/internal/WLedActions.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
d9be35a 
…ding/wled/internal/WLedBindingConstants.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/resources/OH-INF/thi…
a1b02b4 
…ng/thing-types.xml


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
981e33f 
…ding/wled/internal/WLedHandler.java


command.toString()

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
e4c673a 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
a4e5a55 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
80881a5 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Use casting instead of parsing strings.
bd11f2d 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Add debug logging for discovery timeouts.
be4fe19 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
fix build error
eb1f704 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah and others added 4 commits November 1, 2020 10:51
@Skinah
Remove Paho from feature.xml
6b657c7 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
c56f019 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
@Skinah
Sync send and receive added.
66977e0 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Fix discovery bug.
dcb23e7 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah and others added 3 commits November 2, 2020 12:05
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
870821c 
…ding/wled/internal/WLedHelper.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
@Skinah
Prevent endless loop.
2af2b72 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@Skinah
Stop double init of config.
351c1fd 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Skinah and others added 2 commits November 3, 2020 20:44
@Skinah @cpmeister
Update bundles/org.openhab.binding.wled/src/main/java/org/openhab/bin…
f3fe2cd 
…ding/wled/internal/WLedHandler.java


Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
@Skinah
Fix null compiler warnings.
b1e5e3c 
Signed-off-by: Matthew Skinner <matt@pcmus.com>
@cpmeister cpmeister merged commit c49eeb2 into openhab:main Nov 3, 2020
@cpmeister cpmeister added this to the 3.0.0.M3 milestone Nov 3, 2020
@Skinah Skinah mentioned this pull request Nov 6, 2020
Closed
nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021
@Skinah @fwolter
[WLed] Initial contribution - Binding for LED strings with a large ra…
0c45653 
…nge of built in FX. (openhab#8669)

* V3
* Fix null compiler warnings.


Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021
@Skinah @fwolter @boehan
[WLed] Initial contribution - Binding for LED strings with a large ra…
4b52d48 
…nge of built in FX. (openhab#8669)

* V3
* Fix null compiler warnings.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Skinah @fwolter
[WLed] Initial contribution - Binding for LED strings with a large ra…
a27a05c 
…nge of built in FX. (openhab#8669)

* V3
* Fix null compiler warnings.

Signed-off-by: Matthew Skinner <matt@pcmus.com>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
cre Coordinated Review Effort new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
3.0.0.M3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Skinah @TravisBuddy @cpmeister @fwolter