[intesis] - added IntesisBox support #8694

hmerk · 2020-10-08T08:22:37Z

Signed-off-by: Hans-Jörg Merk github@hmerk.de
Also Signed-off-by: Rocky Amatulli rocky@amatulli.net
Also Signed-off-by: Cody Cutrer cody@cutrer.us

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

TravisBuddy · 2020-10-08T08:27:18Z

Travis tests were successful

Hey @hmerk,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

...binding.intesis/src/main/java/org/openhab/binding/intesis/internal/IntesisConfiguration.java

...nding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxIdentity.java

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

bundles/org.openhab.binding.intesis/README.md

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-19T14:51:04Z

Thanks @fwolter
I have addressed all your comments so far.

...nding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxIdentity.java

...inding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxMessage.java

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

cpmeister · 2020-10-19T17:31:01Z

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

+        this.port = port;
+    }
+
+    private class IntesisSocket {


Why is this class needed? It doesn't add any functionality so just keep track of the Socket instead.

That's how I saw it in the energenie Binding, which socket class was written by @Hilbrand . I have no clue of socket handling, so it was simply copy and paste.

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

cpmeister · 2020-10-19T17:52:46Z

Also please address the build warnings:

[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[91,17] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[95,17] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[99,17] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[134,17] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[137,17] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java:[152,27] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java:[96,13] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java:[102,25] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java:[105,25] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java:[108,25] Potential null pointer access: this expression has a '@Nullable' type
[WARNING] /home/travis/build/openhab/openhab-addons/bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java:[111,25] Potential null pointer access: this expression has a '@Nullable' type

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-21T07:52:52Z

Thanks @cpmeister for your review, I have addressed most of it, some comments left.
According to the compiler warnings, i have already added null checks, but the warnings still exist. Don't have a clue how to fix this.

hmerk · 2020-10-21T08:28:35Z

Failing build is not related to intesis binding but Feed tests...

cpmeister · 2020-10-21T18:58:56Z

According to the compiler warnings, i have already added null checks, but the warnings still exist. Don't have a clue how to fix this.

The way to fix them is to assign the @Nullable fields to a local variable and then do all your processing on that local variable instead. The null checker is operating under the assumption that a @Nullable field could be changed to null at any time by another thread.

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-22T07:28:05Z

Thanks @cpmeister I have fixed the compiler warnings and the double null check.

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-23T07:06:38Z

Thanks @cpmeister I have addressed your comments, the rssi channel will be added later today.

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-23T15:08:05Z

@cpmeister RSSI is now changed from property to be a system-channel.

...inding.intesis/src/main/java/org/openhab/binding/intesis/internal/IntesisHandlerFactory.java

...ding.intesis/src/main/java/org/openhab/binding/intesis/internal/api/IntesisBoxSocketApi.java

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk · 2020-10-24T07:57:19Z

Thanks @fwolter all comments addressed.

fwolter

LGTM

cpmeister

LGTM

hmerk · 2020-10-24T20:09:03Z

Thanks @fwolter and @cpmeister for your great support !!!

* Intesis Binding - added IntesisBox support

* Intesis Binding - added IntesisBox support Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

Intesis Binding - added IntesisBox support

a31398d

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

applied spotless

8ea1d26

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk requested review from cpmeister and Hilbrand October 8, 2020 11:23

hmerk added the enhancement An enhancement or new feature for an existing add-on label Oct 12, 2020

fwolter requested changes Oct 13, 2020

View reviewed changes

cpmeister changed the title ~~[Intesis Binding] - added IntesisBox support~~ [intesis] - added IntesisBox support Oct 15, 2020

Changes after first review

b255eec

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk requested a review from fwolter October 19, 2020 14:50

cpmeister requested changes Oct 19, 2020

View reviewed changes

Changes after second review

bf96a6f

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk requested a review from cpmeister October 21, 2020 07:53

hmerk added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 21, 2020

Fix compiler warnings

5ede918

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

cpmeister requested changes Oct 22, 2020

View reviewed changes

...ng.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java Outdated Show resolved Hide resolved

Changes after review

04cac76

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk requested a review from cpmeister October 23, 2020 07:09

Changed RSSI from property to channel

f9b0cba

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

fwolter requested changes Oct 23, 2020

View reviewed changes

Changes after next review

bab56ce

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

hmerk requested a review from fwolter October 24, 2020 07:57

fwolter approved these changes Oct 24, 2020

View reviewed changes

cpmeister approved these changes Oct 24, 2020

View reviewed changes

cpmeister merged commit 91fbe74 into openhab:main Oct 24, 2020

cpmeister added this to the 3.0.0.M2 milestone Oct 24, 2020

hmerk deleted the intesisBox branch October 25, 2020 11:45

nowaterman pushed a commit to nowaterman/openhab-addons that referenced this pull request Jan 19, 2021

[intesis] - added IntesisBox support (openhab#8694)

bd10f7d

* Intesis Binding - added IntesisBox support

boehan pushed a commit to boehan/openhab-addons that referenced this pull request Apr 12, 2021

[intesis] - added IntesisBox support (openhab#8694)

d05cf72

* Intesis Binding - added IntesisBox support Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022

[intesis] - added IntesisBox support (openhab#8694)

050f7b3

* Intesis Binding - added IntesisBox support Signed-off-by: Hans-Jörg Merk <github@hmerk.de>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[intesis] - added IntesisBox support #8694

[intesis] - added IntesisBox support #8694

hmerk commented Oct 8, 2020

TravisBuddy commented Oct 8, 2020 •

edited

Loading

hmerk commented Oct 19, 2020

cpmeister Oct 19, 2020

hmerk Oct 21, 2020

cpmeister commented Oct 19, 2020

hmerk commented Oct 21, 2020

hmerk commented Oct 21, 2020

cpmeister commented Oct 21, 2020

hmerk commented Oct 22, 2020

hmerk commented Oct 23, 2020

hmerk commented Oct 23, 2020

hmerk commented Oct 24, 2020

fwolter left a comment

cpmeister left a comment

hmerk commented Oct 24, 2020

[intesis] - added IntesisBox support #8694

[intesis] - added IntesisBox support #8694

Conversation

hmerk commented Oct 8, 2020

TravisBuddy commented Oct 8, 2020 • edited Loading

Travis tests were successful

hmerk commented Oct 19, 2020

cpmeister Oct 19, 2020

Choose a reason for hiding this comment

hmerk Oct 21, 2020

Choose a reason for hiding this comment

cpmeister commented Oct 19, 2020

hmerk commented Oct 21, 2020

hmerk commented Oct 21, 2020

cpmeister commented Oct 21, 2020

hmerk commented Oct 22, 2020

hmerk commented Oct 23, 2020

hmerk commented Oct 23, 2020

hmerk commented Oct 24, 2020

fwolter left a comment

Choose a reason for hiding this comment

cpmeister left a comment

Choose a reason for hiding this comment

hmerk commented Oct 24, 2020

TravisBuddy commented Oct 8, 2020 •

edited

Loading