[tankerkoenig] Fixed Thing repeatedly going offline #8940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2020 23:43
Incooperated check for 'null' iot to prevent NullPointerExceptions. Signed-off-by: Jürgen Baginski <opus42@gmx.de>
Fixed false parsing of OpeningTimes. Signed-off-by: Jürgen Baginski <opus42@gmx.de>
kaikreuzer
added
rebuild
|
Build failed with spotless errors. |
Signed-off-by: Jürgen Baginski <opus42@gmx.de>
|
Sorry for that one! Actually this was my first try using VSCode, which worked for running the changed code in the IDE (able to use breakpoints!!). What didn't work last nigth was directly publishing the changes to Git, however that was working now. |
J-N-K
added
rebuild
|
Is there anything that I should do? The build failed just BEFORE tankerkoenig. |
|
That‘s why I retriggered the build. I do not understand why the new tado lib is a problem so often, since it is clearly available in the repo. |
|
Yeah, the tado lib issue is annoying, I couldn't yet figure out the reason for it either... |
kaikreuzer
added
rebuild
cpmeister
approved these changes
Nov 3, 2020
|
@JueBag Please note that the issue title is what is used for the release notes later on - could you change it to something that roughly explains what situation is fixed? |
kaikreuzer
pushed a commit
that referenced
this pull request
Nov 4, 2020
* [Tankerkoenig] Update StationHandler Incooperated check for 'null' iot to prevent NullPointerExceptions. * [Tankerkoenig] Updated WebserviceHandler Fixed false parsing of OpeningTimes. * Applied a spotless check Signed-off-by: Jürgen Baginski <opus42@gmx.de> Signed-off-by: Jürgen Baginski <opus42@gmx.de>
|
Cherry-picked to 2.5.x. |
kaikreuzer
changed the title
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* [Tankerkoenig] Update StationHandler Incooperated check for 'null' iot to prevent NullPointerExceptions. * [Tankerkoenig] Updated WebserviceHandler Fixed false parsing of OpeningTimes. * Applied a spotless check Signed-off-by: Jürgen Baginski <opus42@gmx.de>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* [Tankerkoenig] Update StationHandler Incooperated check for 'null' iot to prevent NullPointerExceptions. * [Tankerkoenig] Updated WebserviceHandler Fixed false parsing of OpeningTimes. * Applied a spotless check Signed-off-by: Jürgen Baginski <opus42@gmx.de> Signed-off-by: Jürgen Baginski <opus42@gmx.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [Tankerkoenig] Update StationHandler Incooperated check for 'null' iot to prevent NullPointerExceptions. * [Tankerkoenig] Updated WebserviceHandler Fixed false parsing of OpeningTimes. * Applied a spotless check Signed-off-by: Jürgen Baginski <opus42@gmx.de> Signed-off-by: Jürgen Baginski <opus42@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8876
Fixes the problem caused by stations reporting "null" instead of "false"
Fixed faulty parsing of opening times in case of daily times ("täglich").
Signed-off-by: Jürgen Baginski opus42@gmx.de