[satel] Fixes for INT-RS module #9059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
|
has this change been made to the main branch yet? |
|
Not yet. Should I start with PR to main? |
|
Yes, please start with a PR against main. You can keep this PR in the meantime. |
|
Done: |
cpmeister
approved these changes
Nov 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes communication problems when using INT-RS bridge.
Issue is described here: https://community.openhab.org/t/satel-binding-support-announcements-and-feature-requests/56135/234
After several disconnections one of the binding threads hangs and communistion is stopped. The main change is to rely on receive timeout that can be setup for serial port instead of thread based watchdog.
Signed-off-by: Krzysztof Goworek krzysztof.goworek@gmail.com