[miio] Implement alternative MiIoQuantityTypes #9203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved way avoiding multiple entries for Unit * Test cases for the MiIoQuantityTypes class Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
cpmeister
requested changes
Dec 3, 2020
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
cpmeister
requested changes
Dec 3, 2020
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
...g.openhab.binding.miio/src/main/java/org/openhab/binding/miio/internal/MiIoQuantiyTypes.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Connor Petty <mistercpp2000@gmail.com> Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
force-pushed
the
miio-alternative_units
branch
from
01d8690
to
b18df0a
Compare
marcelrv
added
rebuild
cpmeister
approved these changes
Dec 4, 2020
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* [miio] Implement alternative MiIoQuantityTypes * Improved way avoiding multiple entries for Unit * Test cases for the MiIoQuantityTypes class * Apply suggestions from code review Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* [miio] Implement alternative MiIoQuantityTypes * Improved way avoiding multiple entries for Unit * Test cases for the MiIoQuantityTypes class * Apply suggestions from code review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [miio] Implement alternative MiIoQuantityTypes * Improved way avoiding multiple entries for Unit * Test cases for the MiIoQuantityTypes class * Apply suggestions from code review Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Co-authored-by: Connor Petty <mistercpp2000+gitsignoff@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com