[lcn] add workaround for dynamic text firmware bug #9232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0. Closes openhab#9208 Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
cpmeister
requested changes
Dec 4, 2020
| @@ -125,6 +125,11 @@ public void sendDynamicText( | |||
| text = new String(); | |||
| } | |||
|
|
|||
| // some LCN-GTxD don't display the text if it fits exactly in one chunk. Observed with GT10D 8.0. | |||
| if (text.getBytes(LcnDefs.LCN_ENCODING).length % DYN_TEXT_CHUNK_LENGTH == 0) { | |||
There was a problem hiding this comment.
The default charset varies from system to system so it is better to specify it yourself instead of using the default.
There was a problem hiding this comment.
LcnDefs.LCN_ENCODING is set to StandardCharsets.UTF_8.
There was a problem hiding this comment.
...I have no idea why I didn't notice that.
cpmeister
approved these changes
Dec 4, 2020
| @@ -125,6 +125,11 @@ public void sendDynamicText( | |||
| text = new String(); | |||
| } | |||
|
|
|||
| // some LCN-GTxD don't display the text if it fits exactly in one chunk. Observed with GT10D 8.0. | |||
| if (text.getBytes(LcnDefs.LCN_ENCODING).length % DYN_TEXT_CHUNK_LENGTH == 0) { | |||
There was a problem hiding this comment.
...I have no idea why I didn't notice that.
cpmeister
added
rebuild
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0. Closes openhab#9208
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0. Closes openhab#9208 Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0. Closes openhab#9208 Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0.
Closes #9208
Signed-off-by: Fabian Wolter github@fabian-wolter.de