[telegram] Add event channels and Answer overload #9251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
cpmeister
added
the
enhancement
cpmeister
requested changes
Dec 7, 2020
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
cpmeister
previously requested changes
Dec 9, 2020
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Show resolved
Hide resolved
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Show resolved
Hide resolved
|
I understand the need for a more generic approach otherwise the features for the Telegram binding will always be restricted by the APIs that we offer here. I think your PR is a step in the right direction. With the messageRawEvent we can now get the whole JSON file if somebody wants to use some fancy features (and we have many questions here regarding several features) The coolest thing would be if we could offer the whole Telegram library API directly to the user to make use of the advanced features. But I guess this is still not possible, but could be possible if the Java API is used for writing rules!? Otherwise, the next step would be to find a way for the user to not only have a messageRawEvent for messages received by the user but also to have a raw message that can be send to the user. |
I don't believe that is possible with a binding because it isn't possible to send anything other than a string payload, but I haven't tested this. I'm also not sure it is needed in the context of home automation. This PR will suffice on the receiving side I think.
An interesting idea... I have some additional work that adds a deleteMessage action, but I have not received input on whether I should make a separate PR or just add commits to this one yet. Would a raw send not get pretty complicated, as there are different builders for different message types or am I remembering wrong? I have some review changes to make, I'll probably get to them tomorrow. Silly things I didn't change before submitting because I am running a stripped down version without the state channels. Anyway, if you have suggestions let me know and I can add them at the same time. |
|
@CrazyIvan359 can you post what the status is? Have you made all changes and waiting for more feedback? |
|
Well I never got any input on whether multiple unrelated changes should be made in the same PR. Plus I never got around to any of the cleanup or getting the delete option added into my official work, never getting answers to my questions and lack of time meant I never did any more work on. If you have the time feel free to finish this up, it's going to be a long time before I get back to it. |
|
Sorry for the delay in my reply and thank you for the work in your contribution. The length of time to get this merged does not mean it is not valued, everyone is busy and not many people help do the reviews. I am not an expert nor someone that can merge contributions, I only help out where I can. Your changes seem to be ok'ed by the codeowner (main maintainer) which is @ZzetT and this should be quick to get moving if you finish addressing what looks to be one more area being suggested. Once done make sure you post saying it is all done and you would like it looked at again... If PR were processed quickly it would be best to only do 1 change in a single PR, but since this is not the case myself and others do multiple changes. However please be aware that making a lot of changes can cause a longer delay to have the changes approved, so making too many changes can work against the PR vs making multiple ones that are shorter and easier to review. Your coding looks good so I am not able to offer much help so it is probably pretty close to a state that can be merged. Otherwise we can mark it as a WIP until you are ready to contribute more. |
kaikreuzer
requested changes
Aug 2, 2021
There was a problem hiding this comment.
I'd also be fine to merge this, I only have a few minor change requests.
Sorry that @cpmeister dropped the ball on the review here, so that this PR was hanging so long.
...ab.binding.telegram/src/main/java/org/openhab/binding/telegram/internal/TelegramHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Skinah
reviewed
Aug 18, 2021
Comment on lines
-111
to
+112
| @ActionInput(name = "replyId") @Nullable String replyId, | ||
| @ActionInput(name = "callbackId") @Nullable String callbackId, | ||
| @ActionInput(name = "messageId") @Nullable Long messageId, |
There was a problem hiding this comment.
Does this create a breaking change?
There was a problem hiding this comment.
@CrazyIvan359 Can you answer this question?
It seems to be breaking the existing action. So if this is the case, please create a PR similar to https://github.com/openhab/openhab-distro/pull/1314/files for the distro.
|
@CrazyIvan359 Any chance we can get this sorted as I am wanting to make some changes in the binding which are in areas very close to where you have done some. |
|
@Skinah I don't have time or energy to put into this Matt, not sure when I will. If you want you can absorb the changes here into your PR or ignore my changes and whenever I have time I will update this PR with new news codebase. None of this has to do with the delays handling this PR, I understand the scale of OH and how few people there are merging PRs. |
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Kai Kreuzer <kai@openhab.org>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Kai Kreuzer <kai@openhab.org>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Kai Kreuzer <kai@openhab.org>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Kai Kreuzer <kai@openhab.org>
…/binding/telegram/internal/TelegramHandler.java Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Kai Kreuzer <kai@openhab.org>
…/binding/telegram/internal/TelegramHandler.java Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Skinah
reviewed
Sep 12, 2021
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Skinah
reviewed
Sep 12, 2021
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Skinah
reviewed
Sep 12, 2021
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Skinah
reviewed
Sep 12, 2021
bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
…/binding/telegram/internal/TelegramHandler.java Signed-off-by: Matthew Skinner <matt@pcmus.com> Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
…/thing/thing-types.xml Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
Signed-off-by: Matthew Skinner <matt@pcmus.com>
|
@CrazyIvan359 OK I have pushed some changes to your branch, as soon as what I suspect is an issue with the build system is fixed, I can see if it passes the build tests and ask someone to merge it. It is building fine on my system here. This way you get the credit for the hard work you have done and when you have time to work on the binding again you can look to new features and not trying to get this going. Thanks. |
Skinah
added
rebuild
|
@kaikreuzer I have applied your and others suggestions, refactored some depreciated code that was used and made it compile. Can you take another look to see if this can now be merged? thanks. |
dougculnane
pushed a commit
to dougculnane/openhab-addons
that referenced
this pull request
Oct 11, 2021
commit e9f0fd96b437b1b460d63a0486a2e1aea987da08
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Mon Oct 11 20:09:23 2021 +0200
clean up code
commit 37e39f62f9f1506752baff6ee7f368cda9537ead
Merge: 970bae809b 60b4dad600
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Mon Oct 11 19:15:22 2021 +0200
Merge https://github.com/openhab/openhab-addons into renault
commit 970bae809bd5ef5e75e5816ee1cdb00e82a56927
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Mon Oct 11 18:03:35 2021 +0200
Working get of battery level of car,
commit 60b4dad600ef0c1181073f99b294318549570d0c
Author: lolodomo <lg.hc@free.fr>
Date: Mon Oct 11 13:15:46 2021 +0200
[openweathermap] Bridge status set to ONLINE when no attached things (#11360)
Fix #11191
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
commit 22e8a37ee97f44a0cd018513195dc92c8b209392
Author: Sami Salonen <ssalonen@gmail.com>
Date: Mon Oct 11 13:41:35 2021 +0300
[modbus] Clarifying error messages with invalid configuration (#11292)
Resolves #10814
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
commit 01c0b199fd383e921d54807091e074b8f742c268
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sun Oct 10 20:34:55 2021 +0200
[miele] State/program/phase: Add raw channels and improve text channels (#11341)
* Add raw channels for state, program and phase.
* Provide program/phase texts when missing from XGW 3000 and for multicast.
* Consistent handling of missing program/phase text across all appliance types.
* Fix tumble dryer example configuration.
* Changed tumble dryer Finished phase text for consistency.
Fixes #11335
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit d4e15bfbd60aac8b3ea8b1a66a245bc0e5a57c43
Author: Wouter Born <github@maindrain.net>
Date: Sun Oct 10 20:30:07 2021 +0200
Remove deprecated XStream.setupDefaultSecurity calls (#11365)
The XStream.setupDefaultSecurity method is deprecated since XStream 1.4.18.
It no longer does anything, because this is the default in newer XStream versions.
Signed-off-by: Wouter Born <github@maindrain.net>
commit 3253fbece86bb74f1dea40e1b35351463438933e
Author: Wouter Born <github@maindrain.net>
Date: Sun Oct 10 11:02:53 2021 +0200
Align translation filenames with Crowdin (#11362)
Crowdin is configured to generate translations for languages without countries.
Signed-off-by: Wouter Born <github@maindrain.net>
commit 82f76b6c96b79700c9d73e5f0a6ab0195aa400de
Author: Wouter Born <github@maindrain.net>
Date: Sun Oct 10 10:52:39 2021 +0200
[ntp] Add default translations properties file (#11363)
This allows for translating the NTP Binding strings with Crowdin.
Signed-off-by: Wouter Born <github@maindrain.net>
commit d232a61c56d1037a954069f8416b6077d7f0395d
Author: mtraxiot <37993378+mtraxiot@users.noreply.github.com>
Date: Sun Oct 10 19:14:48 2021 +1100
[openhabcloud] Add required registration before connection (#11168)
commit 9e190e86672bfff9733189f2dd1711809e26d2c5
Author: Matthew Skinner <matt@pcmus.com>
Date: Sun Oct 10 19:12:18 2021 +1100
[ipcamera] Fix several issues and some improvements (#11300)
* Fixes an issue now that the binding is not polling the snapshot anymore where the jpg could return an old image from cache.
* Fixes an issue that could be caused if you spammed the refresh key whilst watching ipcamera.mjpeg
* Improvements in stopping the servlet and stopping any open streams if the pause button is pressed on a camera thing.
* Reduces memory, thread and open file descriptor resource use.
* Fixes empty passwords create bad log output for logged ffmpeg commands.
* Fix for INSTAR cameras that created a WARN about bad user/pass when setting up the alarm server.
Closes #11301
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 99f595450a5538251b25739458c0cf85579b5361
Author: lolodomo <lg.hc@free.fr>
Date: Sun Oct 10 10:04:37 2021 +0200
[powermax] Add null annotations (#11275)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
commit 2b5431df002ccfdb866a3028f4ad80092849667d
Author: Wouter Born <github@maindrain.net>
Date: Sat Oct 9 21:56:09 2021 +0200
[rrd4j] Upgrade rrd4j, improve exception handling (#11355)
* Upgrades rrd4j to 3.8
* Fixes deprecations
* Updates RRD4jChartServlet for ChartProvider API changes
* Improves RRD4jChartServlet exception handling
For the rrd4j changelog see:
https://raw.githubusercontent.com/rrd4j/rrd4j/master/changelog.txt
Related to openhab/openhab-core#2502
Signed-off-by: Wouter Born <github@maindrain.net>
commit dd432270e84b7401d8dd896e3e09a19a8cdd86de
Author: JanSchellenberg <79987070+JanSchellenberg@users.noreply.github.com>
Date: Sat Oct 9 19:58:46 2021 +0200
Update README.md (#11354)
Added the Teufel 3sixty to the Radio mode list.
commit 5132d939c66219b8b3dece0cbeb70dec174795d6
Author: Wouter Born <github@maindrain.net>
Date: Sat Oct 9 19:57:33 2021 +0200
Update bnd to 6.0.0 (#11359)
For release notes, see:
https://github.com/bndtools/bnd/wiki/Changes-in-6.0.0
Related to openhab/openhab-core#2514
Signed-off-by: Wouter Born <github@maindrain.net>
commit 798abaa4ca4904bbfeb302de4193123ba4c6669c
Author: Wouter Born <github@maindrain.net>
Date: Sat Oct 9 19:56:49 2021 +0200
Switch properties files encoding from ISO-8859-1 to UTF-8 (#11349)
* Switch properties files encoding from ISO-8859-1 to UTF-8
Crowdin will generate translations in this encoding, so this prevents a lot of diffs which makes it easier to review future Crowdin PRs.
Related to openhab/openhab-core#2298
Signed-off-by: Wouter Born <github@maindrain.net>
commit 6fab06243cd01fc116aa01d6cd0f03d800fb87a2
Author: Jürgen Pabel <juergenpabel@users.noreply.github.com>
Date: Sat Oct 9 18:32:44 2021 +0200
[feed] added channel for enclosure link on latest entry (#11345)
Signed-off-by: Juergen Pabel <juergen@pabel.net>
commit d6748cd481a96b80c6c6206e87eca8cf51506103
Author: Marcus Better <marcusb@users.noreply.github.com>
Date: Sat Oct 9 10:29:09 2021 -0400
[upb] Fix retry logic (#11342)
* [upb] Fix retry logic
The retry logic was broken so it never retried. This fixes it and adds
unit tests for the serial communication and retry behavior.
Signed-off-by: Marcus Better <marcus@better.se>
* Remove excessive log
Signed-off-by: Marcus Better <marcus@better.se>
commit becb8a48f4ddfc682fc3ad86e3c46f716a3658e5
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date: Sat Oct 9 15:35:18 2021 +0200
Added support to send an Image directly (#11346)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
commit 83fd01498aafb2da5ab046a242b801da41c05f5e
Author: dalgwen <dalgwen@users.noreply.github.com>
Date: Sat Oct 9 11:44:20 2021 +0200
[pulseaudio] Fix sink-input configuration and other (#11272) (#11276)
* [pulseaudio] Fix sink-input configuration and other small improvements (#11272)
The binding requires a parameter to activate the parsing of sink-input entries on the pulseaudio server. This patch :
- document this behaviour
- fix the parsing of these parameters if a configuration file is used (the old method of casting launched a class cast exception)
Other small improvements :
- Force a refresh/new parsing when the configuration changes
- Fix scheduled disconnection : if a sound is played during the grace period, the scheduled disconnection is postponed, not added to the last
- add a possibility to never disconnect the audio sink (in order to have a lower latency when playing sound)
Closes #11272
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
* Small fixes after proofreading
Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
commit f3fbcb622fba71ddd77c8114d08d3a7306ed3dc3
Author: Matthew Skinner <matt@pcmus.com>
Date: Sat Oct 9 19:16:23 2021 +1100
[systeminfo] Fix heap graph too high on axis. (#11351)
Was calculating the “used heap” based on max heap size and not on the currently allocated size.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit ee84f2129d6fddc425714310b0d2bfdc9f0b03cd
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Fri Oct 8 22:20:10 2021 +0200
Authentication impelmented get car data.
commit 51524badb3788f11e029c885954f5d71fe6f71d2
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Thu Oct 7 09:02:04 2021 +0200
First compileable and deployable bindning.
commit 8b1c82bb5fedc41920a302729defbd3046265c8b
Merge: ea0098f616 61324f8b96
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Thu Oct 7 09:00:36 2021 +0200
Merge branch 'main' of https://github.com/openhab/openhab-addons into renault
commit ea0098f6169e39c8af40ecc98d55224f6c397164
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Wed Oct 6 20:33:52 2021 +0200
Start Renualt binding based on renault-api in python
commit 83ef5bf10f7b4a7990e209c212680affbb6980c4
Author: Culnane Douglas <douglas.culnane@extern.a1.at>
Date: Wed Oct 6 20:31:02 2021 +0200
Start Renualt binding based on renault-api in python
commit 61324f8b96ba88057588f54271061f5ace9b409f
Author: Matthias Herrmann <matthias.mh.herrmann@gmail.com>
Date: Wed Oct 6 16:19:38 2021 +0200
Abstract over bin paths using env (#11339)
Signed-off-by: Matthias Herrmann <matthias.mh.herrmann@gmail.com>
commit 192be0def8c6fea4ddcaf967b135491e172c3482
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date: Tue Oct 5 17:56:56 2021 +0200
[darksky] Added hint about Dark Sky API deprecation (#11347)
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
commit 6b979d1b05af0f45a1734b9ee50edda59cd80867
Author: hutdev <hutdev@users.noreply.github.com>
Date: Mon Oct 4 16:33:08 2021 +0200
[netatmo] Updated dev portal URLs in 1st step of README (#11194)
URLs for the Netatmo developer portal seem to have changed
commit ccfe232d490d086e8d4a3812b1c9e3f17bfd8e45
Author: Dan Cunningham <dan@digitaldan.com>
Date: Sun Oct 3 22:41:41 2021 -0700
[myq] Fixes a serious issue that could wipe out cookies across an entire OH instance for bindings using the shared Jetty client (#11343)
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
commit 0ce4e8cb560ef57aa0952248451ae022a524e860
Author: openhab-bot <bot@openhab.org>
Date: Sun Oct 3 22:14:10 2021 +0200
New Crowdin updates (#10570)
Signed-off-by: Wouter Born <github@maindrain.net>
commit af007f43697ec14435c840fd09e3058f516effbb
Author: Bernd Weymann <bernd.weymann@gmail.com>
Date: Sun Oct 3 08:15:07 2021 +0200
[BMWConnectedDrive] Authorization fix + channel enhancements (#11213) (#11263) (#11264)
commit 437fb7f336aa816faa3252befa0de49353ed8a0e
Author: Peter Schraffl <p.schraffl@gmx.at>
Date: Sun Oct 3 01:38:28 2021 +0200
fix: Support Quantity Types (#11229)
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
commit 937a331f670f45cabaf4d31262cd9a75ec88368d
Author: Markus Michels <markus7017@gmail.com>
Date: Sat Oct 2 23:02:28 2021 +0200
[magentatv] Fix: Start UPNP listener to catch power off button, thing id in log (#11238)
* Fix: Start UPNP listener to catch power off button, thing id in log
messages
Signed-off-by: Markus Michels <markus7017@gmail.com>
* comment removed
Signed-off-by: Markus Michels <markus7017@gmail.com>
commit 8d38276dce136e0be78492707329fa004d8f0dd6
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Oct 2 19:57:22 2021 +0200
[miele] Temperature channel improvements: UoM, categories and descriptions (#11329)
* Improvements for temperature channels
Fixes #11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Added jlaur as miele binding maintainer
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix spinning speed for washing machines
Fixes #11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Added time as category for DateTime-related channels
Fixes #11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Elapsed/remaining time channels are no longer marked as advanced.
Fixes #11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fixed type for temperature item examples.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Document all states (cross-appliance).
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Improved error handling for getTemperatureState
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Split current/target temperature into two channel types for label reuse
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix possible NullPointerException
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Distinguish between oven program temperatures
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Mark oven program temperature 1 and 2 as advanced.
Fixes #11317
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit b1f412377f1a889e818b1875449772c4100bd4e9
Author: Gaël L'hopital <gael@lhopital.org>
Date: Sat Oct 2 14:16:23 2021 +0200
[Astro] Removing org.apache.commons.* (#11327)
* Removing org.apache.commons.*
Some code cleansing
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Some more code cleansing.
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Satisfy integration tests
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
* Taking in account @lolodomo feed-back
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
commit 1b80f1d492c342048dd67907f86e3304f28fdb07
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date: Thu Sep 30 22:59:54 2021 +0200
[dsmr] Fix payload length calculation for Smarty meters (#11328)
Fixes #10932
Supersedes #10933 and adds a unit test.
Also-by: Alexander Hotz <alex.hotz@gmail.com>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
commit 46e1b675cbaefe71f8c51c0da9776023903e67ee
Author: Matthias Glaub <maglnet@users.noreply.github.com>
Date: Thu Sep 30 20:59:26 2021 +0200
[influxdb] Add info that it's no good idea to override the item tag via metadata (#11316)
* add info that it's no good idea to override the item tag via metadata
closes #11288
Signed-off-by: Matthias Glaub <magl@magl.net>
commit c09991c08c13484227d85eb2de91dc1385e985b5
Author: Bernhard Bauer <bern77@gmail.com>
Date: Thu Sep 30 19:21:30 2021 +0200
[heliosventilation] reference modbus.helioseasycontrols binding (#11324)
* Update README.md
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
commit def637933bf3f996a1648589cd23d1f8f770f591
Author: Bernhard Bauer <bern77@gmail.com>
Date: Thu Sep 30 19:09:24 2021 +0200
[helioseasycontrols] reference heliosventilation binding (#11325)
* [helioseasycontrols] reference heliosventilation binding
There are two binding supporting different types of Helios ventilation systems. Cross referencing the bindings in their descriptions should help users identify the right binding for their device.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
commit 6508ac3f9fa11c65b0e7809cabea50ed6ac481e9
Author: Matthew Skinner <matt@pcmus.com>
Date: Fri Oct 1 02:48:52 2021 +1000
Bump netty.io to 4.1.68.Final (#11326)
Update to latest Netty which has 2 security fixes in it.
https://netty.io/news/2021/09/09/4-1-68-Final.html
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 48b63759d904fd30b5780ccf4da54c3224c69894
Author: Matthew Skinner <matt@pcmus.com>
Date: Thu Sep 30 17:14:31 2021 +1000
[systeminfo] Add 2 new channels for Java heap (#11322)
* Add heap measuring.
* refactor to remove apache.commons
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit b28413c6f12ac594a284cffa87fd52c1cba2e024
Author: jlaur <jacob-github@vindvejr.dk>
Date: Thu Sep 30 09:00:26 2021 +0200
[miele] Fix supercool/superfreeze for fridges/fridge-freezers (#11321)
* Fix typos.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Do not expose getTypeClass through interface.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix channel supercool for fridges and partially fix supercool/superfreeze for fridge-freezers.
Fixes #11320
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix two-way channel synchronization for supercool/superfreeze for fridge-freezer.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit ff272bc828b210784ee040564de5b975b7f35b2c
Author: Stefan Giehl <stefangiehl@gmail.com>
Date: Wed Sep 29 00:09:34 2021 +0200
[Luxtronik] Fix possible out ouf bound error for older heatpumps (#11318)
* [Luxtronik] Fix possible out ouf bound error for older heatpumps
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
* fix typo
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
commit b35c00c75230dc7d99d16c8ee71e43526e135c7c
Author: Hilbrand Bouwkamp <hilbrand@h72.nl>
Date: Tue Sep 28 18:28:15 2021 +0200
[tplinksmarthome] Added new devices EP10, EP40, KL125, and KL135 (#11282)
Closes #11156
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
commit d3d1c7ae0a5c090519f513f542ca20f6ca58be24
Author: stefan-hoehn <mail@stefanhoehn.com>
Date: Tue Sep 28 09:07:12 2021 +0200
[nanoleaf] Reimplement touch detection based on SSE, stabilize behavior, add swipe support (#11133)
* [nanoleaf] reimplement touch detection based on sse, stabilize behavior
* [nanoleaf] add swipe support
* [nanoleaf] add / tested full shapes support
Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>
commit 89ef91bad3333cb5164a87f893763701bdbb5595
Author: Wouter Born <github@maindrain.net>
Date: Mon Sep 27 22:00:01 2021 +0200
[lifx] Add channels for controlling absolute color temperature in Kelvin (#11309)
* [lifx] Add channels for controlling absolute color temperature in Kelvin
Adds an 'abstemperature' channel to all Thing Types for controlling the absolute color temperature in Kelvin.
MultiZone lights also have 'abstemperaturezone' channels that allow for controlling the color temperature of a zone in Kelvin.
These channels make it easier to use the same color temperature with lights that have a different color temperature range.
Furthermore the channel type tags have been updated which simplifies using the generated items with the semantic model.
Signed-off-by: Wouter Born <github@maindrain.net>
commit b2db32da96e229ebfa19807b8e98c01bc73b61fc
Author: Andrew Fiddian-Green <software@whitebear.ch>
Date: Mon Sep 27 09:38:13 2021 +0100
[mail] Add support for e-mail headers (#11307)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
commit 8255f29320666ef5162a4dcb681f43445d5412ac
Author: jlaur <jacob-github@vindvejr.dk>
Date: Mon Sep 27 07:58:10 2021 +0200
[danfossairunit] Fix network reliability issues and setting of all channel values to zero (#11172)
* Fix Potential null pointer accesses
* Added constants for TCP port and poll interval in seconds.
* Extract interface from DanfossAirUnitCommunicationController.
* Remove unused constants which seems to be left-overs from skeleton.
* Added constant for discovery timeout value for readability.
* Created handler subfolder for DanfossAirUnitHandler (like discovery) for consistency with other bindings.
* Handle lost connection gracefully without updating all channels to zero.
* Fix infinitly blocking network calls preventing proper error handling.
* Fix thing status being reset to ONLINE after failing to update all channels.
* Fix error handling when receiving invalid manual fan step.
Fixes #11167
Fixes #11188
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 2f4a27217f2b8b4d1b44d5953f264d065aebc541
Author: Wouter Born <github@maindrain.net>
Date: Mon Sep 27 07:33:56 2021 +0200
Fix/remove outdated "Default Tags" (#11313)
There used to be the following "Default Tags" which are no longer used in the current semantic model:
* Lighting
* Switchable
* CurrentTemperature
* TargetTemperature
* CurrentHumidity
See:
* https://www.openhab.org/docs/developer/bindings/thing-xml.html#default-tags
* https://www.openhab.org/docs/tutorial/model.html#semantic-model
Signed-off-by: Wouter Born <github@maindrain.net>
commit 0363ba45884838557c71f300012b0b9c76468e94
Author: Fabian Wolter <github@fabian-wolter.de>
Date: Mon Sep 27 07:30:16 2021 +0200
[pidcontroller] Improve logging (#11312)
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
commit 0d5ecd3417548e304376c72d04a60e9cb29a4b4b
Author: Björn Lange <bjoern.lange@udo.edu>
Date: Sun Sep 26 19:05:35 2021 +0200
[mielecloud] Increase timeout for integration tests (#11306)
Signed-off-by: Björn Lange <bjoern.lange@tu-dortmund.de>
commit b65b27a497a914c670d2f53a49e007cbd4f58bd1
Author: Matthew Skinner <matt@pcmus.com>
Date: Mon Sep 27 00:16:07 2021 +1000
Allow multi release JARs to resolve (#11303)
This allows bnd to resolve multi release jar files.
A number of people have posted they have troubles adding dependancies on the forum with this error.
`Classes found in the wrong directory: {META-INF/versions/9/module-info.class=module-info}`
Issue about it is here:
https://github.com/bndtools/bnd/issues/2227
An alternative fix is to add the following into each bindings pom.xml
```
<properties>
<bnd.fixupmessages>"Classes found in the wrong directory"; is:=warning</bnd.fixupmessages>
</properties>
```
Not sure what the correct way to handle this is but these are two ways I have tested.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 27383fcd64ec45f786f5b0ad2f2af42c2c9a180f
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 25 21:09:26 2021 +0200
Add new channels for water and power consumption for washing machines and dishwashers. (#11298)
Fixes #11297
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 8440745cebeec23bf109bc723dc4708b06fc2921
Author: Bo Biene <bo_biene@hotmail.com>
Date: Sat Sep 25 21:07:54 2021 +0200
[wolfsmartset] Initial contribution (#10751)
Signed-off-by: Bo Biene <openhab.github@biene.eu>
commit 277c65f43a866f130a660ec38189664031cff383
Author: Kai Kreuzer <kai@openhab.org>
Date: Sat Sep 25 19:10:12 2021 +0200
Make sure bridge status is set when returning from initialize (#11289)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
commit f4816f544916f5016a0419fd7fb2038d101c0bfb
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 25 16:50:24 2021 +0200
Fix coffee machine auto-discovery. (#11302)
Fixes #8779
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit c3ac604cdbe2ca4d42916638de438b8374abe2ca
Author: jlaur <jacob-github@vindvejr.dk>
Date: Wed Sep 22 21:32:32 2021 +0200
Fix IllegalArgumentException when using oven channel 'type' (#11287)
Fixes #11286
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 1f18dda30134066cb62e772b04353dc77f964929
Author: Wouter Born <github@maindrain.net>
Date: Wed Sep 22 08:35:06 2021 +0200
[modbus] Remove helioseasycontrols binding.xml causing binding identification issues (#11281)
There should only be one binding.xml file for each binding.
Fixes #8973
Signed-off-by: Wouter Born <github@maindrain.net>
commit 36b6b5b8c89a834d0f28baff51ba67e42e6d836e
Author: Wouter Born <github@maindrain.net>
Date: Wed Sep 22 08:34:09 2021 +0200
[metrics] Fix configuration PID and add file based configuration example (#11280)
Fixes #11279
Signed-off-by: Wouter Born <github@maindrain.net>
commit b2d89d8c7fc466988e0214686012e0a6de561f5e
Author: Sami Salonen <ssalonen@gmail.com>
Date: Tue Sep 21 23:01:43 2021 +0300
[modbus] DEVELOPERS.md: fix jamod dependency in demo app (#11278)
As discussed in #8551. See comment from fwolter at Sep 23 2020.:
https://github.com/openhab/openhab-addons/issues/8551#issuecomment-697237105
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
commit ff756460153b0b012f4f78d52a1b15c7e7dc75e4
Author: Sami Salonen <ssalonen@gmail.com>
Date: Tue Sep 21 22:58:54 2021 +0300
[modbus] Fix link to modbus developer documentation (#11277)
Resolves #8382
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
commit 5ae1567ba8f0c441c1cd29b0a967a52be50eda5d
Author: Oleg Vivtash <oleg@vivtash.net>
Date: Tue Sep 21 20:40:57 2021 +0300
[mikrotik] Mikrotik RouterOS Binding - Initial contribution (#10014)
* [mikrotik] Initial contribution
Build fix
Linter concerns fixed
Post-review updates
Apply suggestions from code review
Co-authored-by: Matthew Skinner <matt@pcmus.com>
[mikrotik] Byte channels UOM update
[mikrotik] UOM updates; minor improvements
[mikrotik] ThingTypes update
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Version bump, bugfix (thanks @radokristof)
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Raw uptime channel removed
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Traces removed
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Readme update
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] More Null checks
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] thing-types update
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Units update
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Readme signal update
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Rate channels unit fix
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Work on codestyle report and some compiler warnings
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] No more compiler warnings
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
* [mikrotik] Minus null check
Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
commit fd646a59bdf240058dc74065af74095aaca0c512
Author: Matthew Skinner <matt@pcmus.com>
Date: Wed Sep 22 03:39:46 2021 +1000
[ipcamera] Move to using port 8080 servlet not Netty. (#11160)
* Move to using 8080 servlet not Netty.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Add some mjpeg features to servlet.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix autofps bug
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Reached feature parity.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Cleanup serverPort from cameras.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* bug fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Refactor groups.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Bug fixes to groups
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Update readme
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Cleanup
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* clean up 2.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* bug fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Improve snapshot fetching for autofps.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Make functions synchronized.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fixes.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Abstract servlets
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix NPE warnings
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Remove ability to go child or parent folders.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* autofps improvement
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 20f8a56560ff69d4315e0a80c99a60e927e87a25
Author: Wouter Born <github@maindrain.net>
Date: Mon Sep 20 14:49:32 2021 +0200
[systeminfo] Upgrade OSHI dependency for latest fixes/improvements (#11274)
Upgrades OSHI from 4.5.2 to 5.8.2.
For all OSHI fixes and improvements, see:
https://github.com/oshi/oshi/blob/master/CHANGELOG.md#580-2021-07-18-581-2021-08-22-582-2021-09-05
Signed-off-by: Wouter Born <github@maindrain.net>
commit 02fffccdad649f06c168169f3de8ada5a93126a6
Author: Oliver Raible <38162008+ehora@users.noreply.github.com>
Date: Mon Sep 20 07:48:19 2021 +0200
[openweathermap]: Fix NPE on OneCall-API (#125740) and reduce min refreshInterval to support paid plans (#11255)
* fix NullPointerException at OneCall-API
* reduce min refreshInterval from 10 to 1 min to support paid plans
Signed-off-by: ehora <oliver.raible@yapoware.com>
commit 8e94d8d8b955b7f76889c5808c2d181906676914
Author: Stefan Giehl <stefangiehl@gmail.com>
Date: Sun Sep 19 22:32:00 2021 +0200
[LuxtronikHeatpump] Adds additional setting for heating limit temperature (#11273)
* [Luxtronik Heatpump] Adds additional setting for heating limit temperature
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
commit 27a341311e430fb7fd0a9183c01a1a8670a9f8c7
Author: Matthew Skinner <matt@pcmus.com>
Date: Mon Sep 20 06:08:13 2021 +1000
[telegram] [influxdb] Update okhttp3 lib (#11130)
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 66956d736f473cb7f503f2f3d09ca13bfa43d120
Author: ofirster <34866462+ofirster@users.noreply.github.com>
Date: Sun Sep 19 23:06:35 2021 +0300
[chamberlainmyq] Added new Close Error and Open Error Switch Items fo… (#11115)
Signed-off-by: Ofir Strull <ofir@veev.com>
commit e1e9f90da1b69954a707f300c40885a8c841af43
Author: antroids <36043354+antroids@users.noreply.github.com>
Date: Sun Sep 19 23:04:14 2021 +0300
[mqtt-homeassistant] Refactoring: fixed under_score/CamelCase usages and nullable annotations (#11120)
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
commit 2fb86d71387f4aac0d40fa29184d09490b70895a
Author: Marcel <marcel@verpaalen.com>
Date: Sun Sep 19 22:01:22 2021 +0200
[miio] Automatic create experimental support for (unsupported) miot devices (#11149)
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit b0cbefdf7ab9b6959d162f4cfb0e7ea4f6008872
Author: Thomas <thomas.schumm@yahoo.de>
Date: Sun Sep 19 21:59:19 2021 +0200
[kodi] Add channel for KODI JSON-RPC call Input.ButtonEvent (#11181)
Signed-off-by: Thomas Schumm <thomas.schumm@yahoo.de>
commit 8a7f15e232d7d584fd74393ce0674a7d9267c843
Author: Jonathan S <37658347+J0nathan-S@users.noreply.github.com>
Date: Sun Sep 19 21:55:39 2021 +0200
Added possiblity to send WOL Requests to configured Hostname, also removed unnecessary unit from Timeout Annotation in WakeOnLanPacketSenderTest (#11199)
Signed-off-by: Jonathan Saxen <jonathan@saxen.info>
commit cfdabc4060115a5414b03f575f121096ed9049cb
Author: DirkSander <DirkNilsSander@iCloud.com>
Date: Sun Sep 19 12:06:27 2021 +0200
[melcloud] Fix thing type id in documentation
commit b15403481619ecca48a3cdd5dbb03318cbd25e4e
Author: DirkSander <DirkNilsSander@iCloud.com>
Date: Sun Sep 19 12:05:17 2021 +0200
[melcloud] Fix thing type id in documentation
commit 344011c2ad7ac334d04826fb4e6f4fb072fea489
Author: Wouter Born <github@maindrain.net>
Date: Sun Sep 19 11:45:06 2021 +0200
[lifx] Support HEV clean cycle (#11262)
* Implement HEV packets
* Add colorhevlight thing type with a hevcycle channel
* Update documentation
Signed-off-by: Wouter Born <github@maindrain.net>
commit 0a7a9ae281cb5da9f30581364d11c3d72576e0d6
Author: Kai Kreuzer <kai@openhab.org>
Date: Sun Sep 19 11:40:55 2021 +0200
Rename feature.xml in order to exclude it from feature aggregation (#11266)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
commit ebd268a42e48831385569bd204ed685803641fb3
Author: Maarten Blokker <1915355+maarten-blokker@users.noreply.github.com>
Date: Sun Sep 19 11:40:16 2021 +0200
[surepetcare] Check for null before updating pet location channels (#11235)
fixes #11234
Signed-off-by: Maarten Blokker <maarten.blokker@outlook.com>
commit 0c021ec795b9c5b53b29e40fba5db36aa177fa6c
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 18 22:59:18 2021 +0200
[miele] Fix multicast and multi-protocol support (ZigBee/Wi-Fi) (#11244)
* Fix multicast and multi-protocol support (ZigBee/Wi-Fi)
* Fix channel description referring to hood but also used for oven and other appliances.
* Fix auto-discovery finding already configured things through files.
Fixes #11242
Fixes #11243
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 4aa1f146007dd9812eb8c89037d61206abf0995d
Author: Wouter Born <github@maindrain.net>
Date: Sat Sep 18 19:33:18 2021 +0200
Upgrade to Karaf 4.3.3 (#11261)
* Syncs the karaf.version so the new Maven plugin is used
* Resolves itest runbundles for the new runtime dependencies
Signed-off-by: Wouter Born <github@maindrain.net>
commit 51cb1aabd509c48dd65d1523b8c393cb6b3600bc
Author: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
Date: Sat Sep 18 09:08:00 2021 -0400
[telegram] Add event channels and Answer overload (#9251)
* Add event channels and Answer overload
Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
commit 88975dcd134f3e261d84e16e16ec72eb47a6d350
Author: maniac103 <dannybaumann@web.de>
Date: Sat Sep 18 14:32:40 2021 +0200
[homematic] Remove double press events and improve long press events for button trigger (#11186)
HM devices provide not only 'long press' events, but also 'long
press continued' (sent in configured long press interval) and 'long
press released' events. So far, those events were swallowed in the
button datapoint handler.
Improve the situation by forwarding those events to the button trigger
channel, making them usable in e.g. rules that react on button long
presses.
A double press timeout of 2 seconds is too long and disturbs single
press processing. Additionally, for double press processing to be
useful, the first press would need to be swallowed until double press
timeout elapses, which is not what happened here: the first PRESS was
sent out as SINGLE_PRESS event, making it impossible to meaningfully
distinguish the 'single press' and 'double press' events within rules.
If needed, double press handling can be implemented equally well within
a rule.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
commit cbe537a43bd611ef6dc5eb6d83da764578316252
Author: Ondrej Pecta <opecta@gmail.com>
Date: Sat Sep 18 13:56:36 2021 +0200
[somfytahoma] Fixed rssi channels creation & properties updating (#11254)
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
commit 805d56dc08e6baab74874eb683d5b04904ec94f6
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 18 13:55:04 2021 +0200
[hdpowerview] Add Hub configuration option hardRefreshBatteryLevel (#11260)
* Add Hub configuration option hardRefreshBatteryLevel for refreshing battery status more frequently.
* Explicitly update battery channels to Undefined when data is missing or invalid.
Fixes #11259
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 84ba4fc3337f31cd3f1931a83c3ae23627abf4e8
Author: mlobstein <michael.lobstein@gmail.com>
Date: Sat Sep 18 06:51:30 2021 -0500
Improve discovery service (#11258)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit 3fc7c6559c3eaae7463dde4f44f0842f4119e36b
Author: Pawel Pieczul <pieczul@gmail.com>
Date: Fri Sep 17 08:40:11 2021 +0200
Support for SHA-256 (#11240)
Signed-off-by: Pawel Pieczul <pieczul@gmail.com>
commit 30198e273ab974c0990d64e02602f44a9a8ba348
Author: Wouter Born <github@maindrain.net>
Date: Thu Sep 16 09:11:12 2021 +0200
[metrics] Add Java Management Extensions (JMX) metrics exporter (#11249)
* Add Java Management Extensions (JMX) metrics exporter
* Use groups in metrics add-on configuration
* Improve null annotations
* Update documentation
Signed-off-by: Wouter Born <github@maindrain.net>
commit ba3a9bb01a64cc6cc322d70014e813863684f6e5
Author: Wouter Born <github@maindrain.net>
Date: Wed Sep 15 19:02:17 2021 +0200
[groovyscripting] Update Groovy to 3.0.9 (#11251)
For all bugfixes and improvements, see:
http://groovy-lang.org/changelogs/changelog-3.0.9.html
Signed-off-by: Wouter Born <github@maindrain.net>
commit 357d699cdd3e3b0a957219f7cff584f582ca830b
Author: Marcel <marcel@verpaalen.com>
Date: Tue Sep 14 16:57:57 2021 +0200
[miio] add support for Smartmi Fresh Air System (zhimi.airfresh.va4&va2) (#11164)
* [miio] add support for Smartmi Fresh Air System (zhimi.airfresh.va4&va2)
Add support for
* Smartmi Fresh Air System (zhimi.airfresh.va4)
* Smartmi Fresh Air System (zhimi.airfresh.va2)
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] fix 2 commands and add some formatting
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] fix copy paste error
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] airfresh channelnames
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] merge & count devices
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit db935d3a3b269b7dbadaf4622ed28aa81a6905af
Author: mlobstein <michael.lobstein@gmail.com>
Date: Tue Sep 14 09:55:48 2021 -0500
[kaleidescape] Add configuration option to auto load metadata channels without rules (#11231)
* Add configuration option to auto load metadata channels
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Debug message
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit f0df1a45cc98e3b3e27b25c867340280d994c79f
Author: Marcel <marcel@verpaalen.com>
Date: Mon Sep 13 19:54:35 2021 +0200
[miio] Add support for Yeelight Jade Smart LED Ceiling Light (#11241)
Add support for yeelink.light.ceil26 - Yeelight Jade Smart LED Ceiling
Light C2001
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 088e2f08abc9a475cda91dafeec779602a120969
Author: Wouter Born <github@maindrain.net>
Date: Sun Sep 12 11:44:58 2021 +0200
Resolve runbundles for XStream upgrade (#11236)
Related to openhab/openhab-core#2482
Signed-off-by: Wouter Born <github@maindrain.net>
commit 962853811af510f4e488ef6bf61d4a2de301c1bd
Author: Michael Wodniok <michi@noorganization.org>
Date: Sat Sep 11 16:18:08 2021 +0200
[icalendar] Fix internal calculation for retrieving events for command tags (#11178)
* [icalendar] Fixes #11084: Different method for retrieving events
Replaced retrieval of events for CommandTags by another, already implemented method, fixing wrong behaviour in case of moved or removed events. Also updated dependencies to get this binding resolvable again.
Signed-Off-By: Michael Wodniok <michi@noorganization.org>
commit 7efc3e9e81b8405f1576ebc059d24472f59b8e07
Author: Dan Cunningham <dan@digitaldan.com>
Date: Sat Sep 11 04:41:28 2021 -0700
[myq] Switch to using oAuth for logins (#11183)
* change MyQ binding to use now required oAuth for authentication
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Clean up error handling
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Cleanup checkstyle errors
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* missing newline
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Remove unused classes
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Add token listener
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* add a redirect limit...just in case
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Don't resue the oAuth service if we have been disosed or its closed. Reduce logging verbosity.
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* Force login if we get a 401 response
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
commit f055795c2838d9a47cfdf3ab8d20e45a111fb5c3
Author: lolodomo <lg.hc@free.fr>
Date: Sat Sep 11 13:35:27 2021 +0200
[remoteopenhab] Example with a connection to myopenhab.org (#11237)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
commit d0c435b9bdca005d7f2818e273e8893329617cc5
Author: Matthew Skinner <matt@pcmus.com>
Date: Sat Sep 11 21:34:23 2021 +1000
[telegram] Fixes exceptions that stop rules/actions from finishing (#11215)
* reorder channel updates.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* catch exceptions.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Spotless fixed
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* increase timeout.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* Fix NPE in action from causing issues.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
* fix logger.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit ce8fac8df2f8a89c1a0cc395f448a6763fb6ea86
Author: lolodomo <lg.hc@free.fr>
Date: Fri Sep 10 15:07:25 2021 +0200
[linky] Removed from the distribution until it is fixed (#11233)
* [linky] Removed from the distribution until it is fixed
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Apply spotless
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
commit 195d532aa770aa69e78d103322fabe4a0295f96f
Author: Kai Kreuzer <kai@openhab.org>
Date: Thu Sep 9 09:35:14 2021 +0200
Correctly disable unstable test (#11232)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
commit 31cde42da566d264693fd7a582338fc4fa878765
Author: Marcel <marcel@verpaalen.com>
Date: Wed Sep 8 22:13:32 2021 +0200
[miio] Avoid shutting down shared executor service (#11166)
* [miio] Avoid shutting down shared executor service
* Closing #11152
* Better identify communication threads
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 0a96792a93e382a3f4daddb4d020916328dc6444
Author: dalgwen <dalgwen@users.noreply.github.com>
Date: Wed Sep 8 21:08:05 2021 +0200
[pulseaudio] Fix playing time with pulseaudio sink (#11170) (#11171)
Fixes #11170 by introducing an intelligent thread.sleep (getting the duration of the sound, if possible, then wait the appropriate time for letting the sound play). By the way, the method to get the sound duration is not as easy as I thought.
Also fix a minor issue with the last volume not propertly saved.
And fix some minor warnings by using final local variable.
Signed-off-by: Gwendal ROULLEAU <gwendal.roulleau@gmail.com>
commit 56a0449ce1b758a6c53b2e05f93c30e0efe9d8a2
Author: jlaur <jacob-github@vindvejr.dk>
Date: Wed Sep 8 20:36:59 2021 +0200
[hdpowerview] Add new battery level channel (#11206)
* Introduce new batteryLevel channel.
Fixes #11205
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 8f836a08eae6b4510ac39a3c60d02aa33808c221
Author: jlaur <jacob-github@vindvejr.dk>
Date: Wed Sep 8 20:36:03 2021 +0200
[wemo] Add dimensions for power/energy channel types for Insight Switch. (#11208)
* Add dimensions for power/energy channel types for Insight Switch.
Fixes #11207
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 5ae581f4e142efadd713fc584f869aae8c7d46ad
Author: jlaur <jacob-github@vindvejr.dk>
Date: Wed Sep 8 20:34:08 2021 +0200
Fix broken things file support. (#11218)
Fixes #8877
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit bb1ad2a45342b52d6f8e0955f3c08e0a4c08ac95
Author: Peter Schraffl <p.schraffl@gmx.at>
Date: Wed Sep 8 20:16:23 2021 +0200
fix: Add Group Definition (#11226)
Signed-off-by: Schraffl Peter <p.schraffl@gmx.at>
commit d4983c4991b1406f3960504296215285f09dc267
Author: Ron Isaacson <isaacson.ron@gmail.com>
Date: Wed Sep 8 12:58:35 2021 -0400
[powermax] Introduce some new channels for better status reporting (#10624)
* [powermax] Introduce some new channels for better status reporting
* New panel channels:
- Ringing indicator (the siren is currently sounding)
- Date/time the last message was received from the panel
- List of all active alarms and alerts (similar to panel's
Memory list, but items get removed from the list as conditions
resolve)
* New zone channels:
- Alarmed indicator (zone is in alarm, or has an alarm in memory)
- Tamper alarm indicator (same but for a tamper condition)
- Inactive indicator
- Tamper indicator (zone is actively tampered right now)
- Last status message received for this zone, and when
* Use descriptive names for zones in log messages. If you create a
Thing for a zone, it will use that Thing's label in all reporting
for that zone. If there's no Thing then it will attempt to use the
zone label from the panel (e.g. "Basement").
* Clear all channels during startup to keep from displaying stale
values loaded from persistence
* Also includes some minor SAT fixes (checkstyle, spotbugs)
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Incorporate review feedback from lolodomo
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
commit 0a1f23f98d30757f8e992967c9daef7987d8b57c
Author: TheTrueRandom <43322965+TheTrueRandom@users.noreply.github.com>
Date: Tue Sep 7 22:48:33 2021 +0200
[doorbird] fix controller id (#11190)
Signed-off-by: True Random <rantruedom@gmail.com>
commit 12fba3a5eef26f83ade3389f56cc61d87941f217
Author: Scott H <computergeek1507@users.noreply.github.com>
Date: Sun Sep 5 12:11:40 2021 -0400
Added Twitter binding (#11212)
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
commit d1171ca80999d89ee02aec4dc4cccbb6dd0e20f4
Author: Jan Vybíral <jan.vybiral1@gmail.com>
Date: Sun Sep 5 11:50:23 2021 +0200
[nuki] Opener support and discovery (#10672)
* [nuki] Opener support and discovery (#10671)
* Added Opener support
* New Smartlock channels
* Discovery support
* Secured communication using hashed token
* Improved callback handling
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed code style problems
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Id of bridge is unique for openhab instance
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Added compatibility with smart lock created by previous binding version
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Secure token configuration + threading improvements
Added configuration option to enable or disable using hashed token
for bridge API authentication.
Turning bridge offline when device request fails.
All HTTP calls made async so that openhab thread is not blocked.
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Only discover bridges which return some response
Only bridges which return 200 or 403 response are discovered.
Nuki API might return bridges which no longer exists or are on different
network and are not reachable. We do not want to put these in inbox, only those
who respond do HTTP calls.
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Changed ownership of nuki binding
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Fixed @Nullable annotations
* Fixed too many logger messages
* Rewritten configuration to use configuration class
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* NukiId moved back to configuration and switched to configuration classes in all devices
* Doorbell ringing channel switched to trigger channel
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Channel description reformatted into table
* Fixed bug where repeated bridge discovery was overwriting existing bridge properties
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed ringactionTimestamp property name
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Fixed search of changed thing in HTTP callback
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Improvements to uuid generation
* Bridge id is generated only from bridgeId property, making it stable across openhab installations
* Using InstanceUUID as unique callback identifier instead of bridge id
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Improved duplicate thing discovery
* Implemented duplicate thing detection using openHAB ThingRegistry
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
* Code review changes
* Fixed all nullable warnings
* Fixed README formatting
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
commit b37022c5d78dddd54f133bb6bdbdff7ec7298b7e
Author: Scott H <computergeek1507@users.noreply.github.com>
Date: Sun Sep 5 03:33:00 2021 -0400
[Twitter] 3.0 Twitter Binding (#10241)
* [twitter][WIP] Initial contribution
using the 1.x binding as a template, I created a new Twitter Binding.
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com> (github: computergeek1507)
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* trying to fix twitter4j dependency stuff
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* add to bundle POM
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* trying to fix build
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Fixed dependency issues, Got Actions working
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* updating readme
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* fix class name
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Fixes based on review
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* Cleanup based on review and mvn checks
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* grammar fix
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* remove Apache dependencies
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* added Null Checks based on review
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
* change null check around
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
commit 0087c8c828e812781d4e0afce4cb7bedf5c64dd3
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 4 15:49:33 2021 +0200
[hdpowerview] Add new signal strength channel (#11198)
* Add new signal strength channel.
Fixes #11197
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 3a36b1e70dc40d575144cf6f163a707b2cef375f
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sat Sep 4 15:48:19 2021 +0200
Fix channel lowBattery being updated to ON when no battery status available. (#11201)
Fixes #11200
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 6c3e937f028ec3d3c65e0b4b37c70805d38bb3d9
Author: Wouter Born <github@maindrain.net>
Date: Tue Aug 31 19:43:38 2021 +0200
[lifx] Add missing color feature to a few products (#11180)
Updates the LIFX Candle (PID 68) and LIFX Clean (PID 90, 99) products to support color features.
Signed-off-by: Wouter Born <github@maindrain.net>
commit cd69c77cd540ce058c5d9bfe87ef2ad5db5571fc
Author: mlobstein <michael.lobstein@gmail.com>
Date: Tue Aug 31 07:41:11 2021 -0500
[oppo] Remove logo from README (#11176)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit 2e8fb907ca76d99816ea35ac87727bad1ba88664
Author: Jørgen Melhus <5099412+jmelhus@users.noreply.github.com>
Date: Tue Aug 31 13:05:09 2021 +0200
[bluetooth.bluegiga] Fix CompareObjectsWithEquals findings regression causing all devices to be beacons
Signed-off-by: Jørgen Melhus <5099412+jmelhus@users.noreply.github.com>
commit fac7edc27051fd0bf5fbf042cfed3925b927f26d
Author: Marcel <marcel@verpaalen.com>
Date: Sun Aug 29 22:17:43 2021 +0200
[miio] add support for mi airfryers (careli.fryer.maf01,2&3) (#11142)
Also includes update of models names db
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 492682c5cfc8f805aadbc167908ebf78d91847f4
Author: Marcel <marcel@verpaalen.com>
Date: Sun Aug 29 20:18:31 2021 +0200
[miio] improve readme: restructure & map customizing feature (#11143)
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit b2b3ad274beed22404c92bb96db8fe695b1b81b0
Author: Mark Hilbush <mark@hilbush.com>
Date: Thu Aug 26 13:09:26 2021 -0400
API changed location of event counts (#11159)
Signed-off-by: Mark Hilbush <mark@hilbush.com>
commit 4e50a985e68a1ac2693dd58a207f0079bd328bb6
Author: jlaur <jacob-github@vindvejr.dk>
Date: Thu Aug 26 18:57:27 2021 +0200
[hdpowerview] Add new batteryVoltage channel (#11155)
* Add new batteryVoltage channel.
Fixes #11154
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Fix documentation for lowBattery.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Organized channels into two groups: Shade and Battery.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
* Revert breaking change.
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 36377a790ec0523d34318bdffc0472fb505b5f7c
Author: antroids <36043354+antroids@users.noreply.github.com>
Date: Thu Aug 26 15:46:53 2021 +0300
[mqtt-homeassistant] MQTT Homeassistant test concurrency bug fixed (#11161)
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Co-authored-by: Anton Kharuzhy <antroids@gmail.com>
commit 81989112d16813fe9d53c27e73f67a236feb7157
Author: mlobstein <michael.lobstein@gmail.com>
Date: Tue Aug 24 12:05:32 2021 -0500
Fix equalsIgnoreCase issue (#11140)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit 5ce27e34074cbb8f7b110de8d6700a4bb58ffe49
Author: mlobstein <michael.lobstein@gmail.com>
Date: Tue Aug 24 12:04:17 2021 -0500
Fix equalsIgnoreCase issue (#11141)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit be176547679d7af39d90b607c3c94bfab8366b7e
Author: jlaur <jacob-github@vindvejr.dk>
Date: Tue Aug 24 18:59:35 2021 +0200
Renamed channel manual_fan_speed to manual_fan_step for consistency. (#11147)
Fixes #10621
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 5cb228570d990aab7517df9d51a4a1931676584f
Author: Mark Hilbush <mark@hilbush.com>
Date: Tue Aug 24 08:44:02 2021 -0400
Fix parsing to handle when volume is a float (#11151)
Signed-off-by: Mark Hilbush <mark@hilbush.com>
commit 498852217318c9ed94cbd8147659e70dcd2e90aa
Author: OneYellowLemon <66096725+OneYellowLemon@users.noreply.github.com>
Date: Mon Aug 23 15:51:40 2021 -0400
Make spacing consistent (#11145)
Signed-off-by: OneYellowLemon <66096725+OneYellowLemon@users.noreply.github.com>
commit 73f7a86dd827bc93d6b78cc1bdaffb0159d80de5
Author: kennetn <kennetn@gmail.com>
Date: Sun Aug 22 12:04:33 2021 +0200
[irobot] Minor readme corrections (#11124)
* Minor readme corrections
Minor clarification originally described here https://community.openhab.org/t/irobot-9xx-on-openhab/17774/196
Signed-off-by: kennetn <kennetn@gmail.com>
commit aee601cc3dea597090cecba1b3e4e5e20e6150e2
Author: Julio Vilmar Gesser <jgesser@gmail.com>
Date: Sun Aug 22 07:02:10 2021 -0300
[semsportal] Fix lastUpdate parse format to accept the format provided by the inverter (#11127)
* Fixed lastUpdate date formating
Signed-off-by: Julio Gesser <jgesser@gmail.com>
commit 14cd779530c41749395a726d929d05f158607227
Author: Allan Seidel <akseidel@users.noreply.github.com>
Date: Sun Aug 22 04:58:38 2021 -0500
Update README.md (#11131)
Corrected the humidifier mode label.
commit bf94b06d0bf7b7c0e00c161c4d31bdb872422431
Author: Ryz <mirco.heitmann@gmail.com>
Date: Sun Aug 22 11:57:25 2021 +0200
Changed minimum Z-Way polling interval to 1 second. (#11122)
Signed-off-by: Ryz <mirco.heitmann@gmail.com>
commit 300ed046a89cfaad402ee351e62325fcb379c2d0
Author: Matthew Skinner <matt@pcmus.com>
Date: Sun Aug 22 19:54:34 2021 +1000
[telegram] Send message if a file download fails and bug fixes. (#11125)
* Send message when pic/vid/ani fails to DL
* Upgrade lib to 5.2.0 and fix error.
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit c084ec3a5b68a9ccfffee4e2dcdd3b18ecf4778a
Author: Anders Alfredsson <30875102+pacive@users.noreply.github.com>
Date: Sun Aug 22 11:53:11 2021 +0200
Fix IndexOutOfBoundsException in aggregator function (#11113)
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
commit 9fed16d8bb6381f950f2444f041cce9894b16685
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sun Aug 22 11:52:05 2021 +0200
[danfossairunit] Change Humidity channel type from Number to Number:Dimensionless (#11121)
* Change Humidity channel from Number to Number:Dimensionless
* Fix documentation for temperature channels.
Fixes #9755
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 44538c5409118dbda8a07163a2785821a6c13d6a
Author: jlaur <jacob-github@vindvejr.dk>
Date: Sun Aug 22 11:50:33 2021 +0200
[danfossairunit] Add channel descriptions and categories (#11129)
* Use system default channel type for battery level.
* Add channel categories where applicable
* Add missing channel descriptions (and fix two existing)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
commit 5f6d9b91efb182c3c33271f4963aa19d0d1fbe71
Author: Stefan Giehl <stefangiehl@gmail.com>
Date: Sun Aug 22 11:49:33 2021 +0200
Fix/update channels for setting hot water target temperature (#11135)
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
commit b6aa401cf9fa3a6ac7c854c04e75cd1cdbf2ada6
Author: Stefan Triller <t2000@users.noreply.github.com>
Date: Sun Aug 22 11:45:55 2021 +0200
[robonect] Channel for distance from charging station on remote start (#11137)
New channel "status-distance" that shows the distance of the robot from
its charging station while it is searching for the remote starting point.
Signed-off-by: Stefan Triller <github@stefantriller.de>
commit 02d8e43d376c696139f32feaa78abd8d8b99b8c6
Author: Jan Gustafsson <jannegpriv@gmail.com>
Date: Mon Aug 16 14:06:16 2021 +0200
Fix for #10982 - Binding not working properly HANDLER_REGISTERING_ERROR (#11108)
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
commit 62f169d6491f4c847ad11dd47280e56c339d3a6c
Author: Marcel <marcel@verpaalen.com>
Date: Mon Aug 16 14:03:33 2021 +0200
[miio] map improvement cropping and customizable colors/parameters (#11110)
* [miio] make robo map drawing customizable
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] Add cropping possibility for vacuum map
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* miio minor edit
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 0d286e7a89e554b1ab0669cf16b554dc060948b9
Author: Marcel <marcel@verpaalen.com>
Date: Mon Aug 16 14:02:09 2021 +0200
[miio] improve/add properties for qmi powerstrip (#11118)
improve mija vacuum channels
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 3a7835e122d190cdac9800e1fdc4613a505f6776
Author: antroids <36043354+antroids@users.noreply.github.com>
Date: Sun Aug 15 12:48:26 2021 +0300
[mqtt-homeassistant] climate.mqtt support (#10690)
* MQTT.Homeassistant Climate support
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant synthetic config test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant refactoring
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant discovery test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant thing handler test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant switch test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Climate test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant author header added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant copyright header added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test fixed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test fixed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant test infrastructure updated. Added tests with mqtt publishing and commands posting.
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant fixed Climate#send_if_off handling
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant do not filter the power command
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant climate unit test added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* Update bundles/org.openhab.binding.mqtt.homeassistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/DiscoverComponents.java
Redundant annotation removed
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* MQTT.Homeassistant Redundant @Nullable annotations removed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Unit tests added for all components
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Unit tests stability fix
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant @NonNullByDefault removed from Device, config.dto package created
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Climate author added
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant Device.sw_version renamed
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
* MQTT.Homeassistant tests wait timeout increased to 10s
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Co-authored-by: antroids <antroids@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
commit 9f09db1f18bf465e47d4793350d30b3fce905974
Author: Marcel <marcel@verpaalen.com>
Date: Sat Aug 14 13:40:36 2021 +0200
[miio] add support for Mi Smart Standing Fan 2 (dmaker.fan.p18) (#11106)
closing #11053
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 5d6fa4a460ea66b29258bdde39b0263b6906480c
Author: mlobstein <michael.lobstein@gmail.com>
Date: Sat Aug 14 06:39:11 2021 -0500
Update Nuvo README (#11107)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit 1321049973d339bc662f582bcbc2ac5faf6a968c
Author: mlobstein <michael.lobstein@gmail.com>
Date: Wed Aug 11 05:06:40 2021 -0500
Add Roku TV channels (#11087)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
commit a93b56f2d33d2b74bc568555087283398f352569
Author: Christoph Weitkamp <github@christophweitkamp.de>
Date: Wed Aug 11 12:03:11 2021 +0200
[openweathermap] Fix ozone mapping in DTO (#11086)
- Fix ozone mapping in DTO
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
commit 333e7d2ef28f3d1bf20a6c6a2283045809b85374
Author: Matthew Skinner <matt@pcmus.com>
Date: Wed Aug 11 20:02:19 2021 +1000
Fix IndexOutOfBoundsException and remove Sleep. (#11089)
Signed-off-by: Matthew Skinner <matt@pcmus.com>
commit 9f35e7ba314f61c2f5e6efe32ab028445ec6ceb6
Author: Michael B <bredmich@users.noreply.github.com>
Date: Wed Aug 11 12:00:30 2021 +0200
Added inverted info for rollershutters (#11094)
Currently openHAB and the CCU are using different values for the same state of a rollershutter.
Added information about this under Troubleshooting and listed some examples.
Signed-off-by: Michael Bredehorn <michael@bredehorn.nrw>
commit 497c09ee05b4b2022d2831e0b91ea115c550a361
Author: Sami Salonen <ssalonen@gmail.com>
Date: Wed Aug 11 12:57:26 2021 +0300
[dynamodb] AWS setup guidance updated in docs (#11092)
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
commit 8dbe57947d8bf756f9fc78f1307779f4543ca4b4
Author: Marcel <marcel@verpaalen.com>
Date: Wed Aug 11 11:56:09 2021 +0200
[miio] add moppath & carpet area to robomap (#11097)
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
commit 8e7f4a0e419838aa744ea6e4b953cc789e445681
Aut…
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* Add event channels and Answer overload Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Add event channels and Answer overload Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* Add event channels and Answer overload Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
|
Can someone help to describe what is the breaking change introduced by this PR ? |
|
See what was changed in lines 109 to 112 of I do not understand why/reasons the changes were made as this is not my PR, I tagged it as to my eyes and @kaikreuzer also asked the question for more info on this section. |
|
Ok, I added something for that: |
|
I took another look and it appears that it was overloaded with a backwards compatible action. I am pretty sure this has no breaking changes and both the old and the new will work. |
Yes, I have the same feeling after looking at the code changes. |
volkmarnissen
pushed a commit
to volkmarnissen/openhab-addons
that referenced
this pull request
Mar 3, 2022
* Add event channels and Answer overload Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Add event channels and Answer overload Signed-off-by: Michael Murton <6764025+CrazyIvan359@users.noreply.github.com>
johnuopini
pushed a commit
to johnuopini/openhab-addons
that referenced
this pull request
Jun 11, 2023
* main: (43 commits) [systeminfo] Upgrade OSHI dependency for latest fixes/improvements (openhab#11274) [openweathermap]: Fix NPE on OneCall-API (#125740) and reduce min refreshInterval to support paid plans (openhab#11255) [LuxtronikHeatpump] Adds additional setting for heating limit temperature (openhab#11273) [telegram] [influxdb] Update okhttp3 lib (openhab#11130) [chamberlainmyq] Added new Close Error and Open Error Switch Items fo… (openhab#11115) [mqtt-homeassistant] Refactoring: fixed under_score/CamelCase usages and nullable annotations (openhab#11120) [miio] Automatic create experimental support for (unsupported) miot devices (openhab#11149) [kodi] Add channel for KODI JSON-RPC call Input.ButtonEvent (openhab#11181) Added possiblity to send WOL Requests to configured Hostname, also removed unnecessary unit from Timeout Annotation in WakeOnLanPacketSenderTest (openhab#11199) [melcloud] Fix thing type id in documentation [melcloud] Fix thing type id in documentation [lifx] Support HEV clean cycle (openhab#11262) Rename feature.xml in order to exclude it from feature aggregation (openhab#11266) [surepetcare] Check for null before updating pet location channels (openhab#11235) [miele] Fix multicast and multi-protocol support (ZigBee/Wi-Fi) (openhab#11244) Upgrade to Karaf 4.3.3 (openhab#11261) [telegram] Add event channels and Answer overload (openhab#9251) [homematic] Remove double press events and improve long press events for button trigger (openhab#11186) [somfytahoma] Fixed rssi channels creation & properties updating (openhab#11254) [hdpowerview] Add Hub configuration option hardRefreshBatteryLevel (openhab#11260) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 4 event trigger channels that fire when messages or query callbacks are received, presenting the entire message as the payload for easier use in rules.
messageEventprovides simplified message propertiesmessageRawEventprovides the entire message object from the Telegram librarycallbackEventprovides simplified callback query propertiescallbackRawEventprovides the entire callback query object from the Telegram libraryAdditionally, a new overload to the
sendTelegramAnsweraction was added that allows you to provide thecallbackIdandmessageIdthat would normally be retrieved by a lookup in the handler. This can be used to answer queries that were sent before openHAB restarted by saving thecallbackIdandmessageIdoutside the binding, or to answer queries directly instead of viareplyId.callbackIdandmessageIdare provided in both callback events.I have tested all changes locally using rules.
This is my first time building anything Java and there is one thing that was/is not working in the build that I was not able to figure out. Both
OH-INF/binding/binding.xmlandOH-INF/thing/thing-types.xmlare empty in the built JARs, regardless of which build process I run. Is this normal for local builds? I will be checking the automated build to see if the results are the same. Any insight would be much appreciated.Another question I had is about how many things should go into one PR. I am working on other changes that will add a new action
and modify the return values for actions to provide data that the new action would use. It won't be a breaking change, as the return values will still be falsy if the action failed and true-ish if it succeeds.Seems the concept of falsy doesn't exist in a strictly typed language like Java, so changing the return type of the actions with be a breaking change.Should I include those commits in this PR for consiceness, or make a separate PR for them?