[Broadlinkthermostat] Initial contribution

[flo-02-mu]

This is a new binding to support thermostats that are based on a broadlink chips and sold with different brand names (see https://community.openhab.org/t/electronic-heating-thermostat-reverse-engineering-beok-floureon-decdeal/39251).

While there is already another broadlink binding in development (https://community.openhab.org/t/broadlink-binding-for-rmx-a1-spx-and-mp-any-interest/22768) they both focus on different things, that's why I decided to create a separate binding.

Unfortunately the binding includes a library in the lib folder which is not an osgi bundle. The distributed version is a jdk11 patched version of https://github.com/mob41/broadlink-java-api/

Myself and other users have been using this binding for quite a while, that's why I'd like to get this into the official distribution.
Discussion for this binding takes place at https://community.openhab.org/t/broadlink-floureon-hysen-thermostat-binding/81921

[fwolter]

Thanks for your contribution! I reviewed your code and here is my feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

[flo-02-mu]

Thanks for your contribution! I reviewed your code and here is my feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

Thank You for your fast feedback. I incorporated the quick wins and will take care about the dateformatter in the next days.
The only issue that remains is about the external library: It does exist on maven central, but with a non-java-11 compatible version, and there is not much activity on the repo. But duplicating the functionality of that library would be pretty sad, too.

[fwolter]

You're welcome. Shouldn't run any much older JAR version with the current Java version?

[flo-02-mu]

You're welcome. Shouldn't run any much older JAR version with the current Java version?

You're completely right, I was mistaken on that. I thought it would be missing the jaxb lib, but it seems to not miss that one "transitively". Also the handling in the feature.xml file seems to be not needed anymore... so the lib is not bundled anymore, but just referenced as compile dependency in the pom.
All other changes are done, let me know if there is anything else that I should change.

[fwolter]

That the transitive dependency isn't missing is a coincidence as it is propably used somewhere else in OH. The transitive dependencies need to be added to the pom.xml.

[flo-02-mu]

That the transitive dependency isn't missing is a coincidence as it is propably used somewhere else in OH. The transitive dependencies need to be added to the pom.xml.
I added the jaxb dependency via <feature dependency="true">openhab.tp-jackson</feature> in feature.xml

[fwolter]

Just to avoid confusion, did you click on "Load more ..." in my review comments? Because you fixed all visible but none of the hidden comments.

[flo-02-mu]

Just to avoid confusion, did you click on "Load more ..." in my review comments? Because you fixed all visible but none of the hidden comments.

🤦 indeed, I missed them in the first place. They are now processed.

[fwolter]

There is one checkstyle warning left. You could take a look at target/code-analysis/report.html.

There are some compiler warnings about null access left. To fix these, you need to store the field to a local variable and do the null check on that.

[flo-02-mu]

There is one checkstyle warning left. You could take a look at target/code-analysis/report.html.

There are some compiler warnings about null access left. To fix these, you need to store the field to a local variable and do the null check on that.

Cool, I was always wondering how to deal with the null checks -> Should all be solved. I did not have a checkstyle warning - is it still present?

[fwolter]

Did you finished making all changes?

[flo-02-mu]

Did you finished making all changes?

As far as I can see, yes, everything is pushed.

[fwolter]

LGTM

As this is a new binding, another maintainer needs to review your code before it can be merged.

[scrakcho]

Sorry but how time ussualy take to merge an addon?

[fwolter]

It depends on when another maintainer finds time to do the second review. But the forum link might bring you to a JAR file, so that you can install the add-on in advance.

[Hilbrand]

Here is the second review. One additional comment. You need to update the copyright year. You can do this by running mvn license:format on your binding.

[Hilbrand]

LGTM