[icalendar] Ensure Bridge is initialized and calendar is available to update child Things #9337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Things Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
bug
daMihe
approved these changes
Dec 12, 2020
J-N-K
requested changes
Dec 12, 2020
Comment on lines
396
to
398
| for (Thing childThing : getThing().getThings()) { | ||
| updateChild(childThing.getHandler()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (Thing childThing : getThing().getThings()) { | |
| updateChild(childThing.getHandler()); | |
| } | |
| getThing().getThings().forEach(childThing -> updateChild(childThing.getHandler()); |
There was a problem hiding this comment.
I expected this comment ... Why didn't I implemented it in this way directly. 😉
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
J-N-K
approved these changes
Dec 12, 2020
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
… update child Things (openhab#9337) * Ensure Bridge is initialized and calendar is available to update child Things
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
… update child Things (openhab#9337) * Ensure Bridge is initialized and calendar is available to update child Things Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9029 and #9230
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de