[miio] suggest correct devicenames in readmehelper #9379
Conversation
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcelrv
added
the
enhancement
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
| "aiicn.curtain.r51": "智能窗帘控制器", | ||
| "aiicn.light.pwm2": "LED驱动器", | ||
| "aiicn.light.r01": "单路接收器", |
There was a problem hiding this comment.
I'm not sure that chinese names would really help english speakers know what they are looking at...
There was a problem hiding this comment.
I'm sure not... these devices don't have an English description in the cloud, guess they are only for sale in CN.
This list is all devices that are known for Xiaomi, that does not mean they are included in OH..
Dunno an easy fix for this (I can delete all non-english ones, but that does not solve anything)
There was a problem hiding this comment.
I'm not really sure there is a good fix either. But I think as long as you only show the device name as additional information for the device and not as the key identifier for the device, both in openHAB and in documentation, then I think we should be ok.
There was a problem hiding this comment.
When I actually implement such a device I normally use the English names. Until very recent I didn't even know what is the name of a device according to Xiaomi. I used a mix of commercial names ( how they call the devices on the webshops) or generic names based on the model e.g aiicn.light.r01 would become aiicn light, and it still unclear Google translate as final solution
Long story short... When I actually add a device, I'll add it with an English name.
The inclusion here in the readme maker is just to speedup/simplify the creation of the actual Java devicelist file.
* [miio] suggest correct devicenames in readmehelper * add newline at file end to make git happy * [miio] update logic for mapping in readmeComments * Allow readme maker to fix mappings based on the current options. * [miio] make readmeOptionMapping static Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] suggest correct devicenames in readmehelper * add newline at file end to make git happy * [miio] update logic for mapping in readmeComments * Allow readme maker to fix mappings based on the current options. * [miio] make readmeOptionMapping static Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
* [miio] suggest correct devicenames in readmehelper * add newline at file end to make git happy * [miio] update logic for mapping in readmeComments * Allow readme maker to fix mappings based on the current options. * [miio] make readmeOptionMapping static
* [miio] suggest correct devicenames in readmehelper * add newline at file end to make git happy * [miio] update logic for mapping in readmeComments * Allow readme maker to fix mappings based on the current options. * [miio] make readmeOptionMapping static Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] suggest correct devicenames in readmehelper * add newline at file end to make git happy * [miio] update logic for mapping in readmeComments * Allow readme maker to fix mappings based on the current options. * [miio] make readmeOptionMapping static Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com