New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[smhi] Add aggregated channels for daily forecast. #9387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updates to use Optionals instead of @nullables, and add unit tests Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
cpmeister
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Dec 15, 2020
fwolter
requested changes
Dec 15, 2020
...es/org.openhab.binding.smhi/src/main/java/org/openhab/binding/smhi/internal/SmhiHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.smhi/src/main/resources/OH-INF/thing/channel-types.xml
Show resolved
Hide resolved
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
fwolter
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As OH3 is already feature-freezed, your PR will be merged as soon as OH3 is released. Your changes will go into OH3.1, then.
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Add aggregated channels for daily forecast. Also updates to use Optionals instead of @nullables, and add unit tests * Revert unsing explicit unit definition Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Add aggregated channels for daily forecast. Also updates to use Optionals instead of @nullables, and add unit tests * Revert unsing explicit unit definition Signed-off-by: Anders Alfredsson <andersb86@gmail.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* Add aggregated channels for daily forecast. Also updates to use Optionals instead of @nullables, and add unit tests * Revert unsing explicit unit definition
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Add aggregated channels for daily forecast. Also updates to use Optionals instead of @nullables, and add unit tests * Revert unsing explicit unit definition Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates to use Optionals instead of
@Nullable
s, and add unit testsSigned-off-by: Anders Alfredsson andersb86@gmail.com